rspec/rules/S1821/java/rule.adoc

63 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
Nested ``++switch++`` structures are difficult to understand because you can easily confuse the cases of an inner ``++switch++`` as belonging to an outer statement or expression. Therefore nested ``++switch++`` statements and expressions should be avoided.
Specifically, you should structure your code to avoid the need for nested ``++switch++`` statements or expressions, but if you cannot, then consider moving the inner ``++switch++`` to another method.
2020-06-30 12:47:33 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2020-06-30 12:47:33 +02:00
----
void foo(int n, int m) {
switch (n) {
case 0:
switch (m) { // Noncompliant; nested switch
// ...
}
case 1:
// ...
default:
// ...
}
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2020-06-30 12:47:33 +02:00
----
void foo(int n, int m) {
switch (n) {
case 0:
bar(m);
case 1:
// ...
default:
// ...
}
}
void bar(int m){
switch(m) {
// ...
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]