rspec/rules/S2737/plsql/rule.adoc

48 lines
898 B
Plaintext
Raw Normal View History

== Why is this an issue?
An ``++EXCEPTION WHEN ... THEN++`` clause that only rethrows the caught exception has the same effect as omitting the ``++EXCEPTION++`` clause altogether and letting it bubble up automatically.
2020-06-30 12:48:07 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:48:07 +02:00
----
BEGIN
SELECT 1/0;
EXCEPTION
WHEN ZERO_DIVIDE THEN
RAISE; -- Noncompliant
WHEN OTHERS THEN
RAISE; -- Noncompliant
END;
----
Such clauses should either be removed or populated with the appropriate logic.
2020-06-30 12:48:07 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:48:07 +02:00
----
BEGIN
SELECT 1/0;
EXCEPTION
WHEN ZERO_DIVIDE THEN
2020-06-30 12:48:07 +02:00
-- do something to manage the division by zero
COMMIT;
WHEN OTHERS THEN
ROLLBACK;
END;
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]