rspec/rules/S3923/abap/rule.adoc

59 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
Having all branches of a `CASE` or `IF` chain with the same implementation indicates a problem.
2020-06-30 12:48:39 +02:00
In the following code:
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,abap]
2020-06-30 12:48:39 +02:00
----
IF a >0. "Noncompliant
2020-06-30 12:48:39 +02:00
doSomething.
ELSE IF b> 0.
doSomething.
ELSE.
doSomething.
ENDIF.
CASE i. "Noncompliant
2020-06-30 12:48:39 +02:00
WHEN 1 OR 3.
doSomething.
WHEN 2.
doSomething.
WHEN OTHERS.
doSomething.
ENDCASE.
----
Either there is a copy-paste error that needs fixing or an unnecessary `CASE` or `IF` chain that needs removing.
=== Exceptions
2020-06-30 12:48:39 +02:00
This rule does not apply to `IF` chains without final `ELSE`, nor to `CASE` without a `WHEN OTHERS` clause.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
[source,abap]
2020-06-30 12:48:39 +02:00
----
IF a >0. "no issue, this could have been done on purpose to make the code more readable
doSomething.
ELSEIF b> 0.
doSomething.
ENDIF.
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]