rspec/rules/S4586/comments-and-links.adoc

16 lines
556 B
Plaintext
Raw Normal View History

=== on 16 Apr 2018, 15:00:41 Amaury Levé wrote:
\[~ann.campbell.2] Could you please review?
=== on 17 Apr 2018, 21:43:26 Ann Campbell wrote:
\[~amaury.leve] I'm confused. The title says "in a method *not* marked as async" and the description talks about "Returning ``++null++`` from a *non*-``++async++``".
Also, this title doesn't follow the format: X should [not] Y
=== on 18 Apr 2018, 09:30:40 Amaury Levé wrote:
Thank you for the review. Does it looks better now?
=== on 18 Apr 2018, 13:43:19 Ann Campbell wrote:
Yes, looks good [~amaury.leve]