rspec/rules/S134/csharp/rule.adoc

53 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Nested ``++if++``, ``++switch++``, ``++for++``, ``++foreach++``, ``++while++``, ``++do++``, and ``++try++`` statements are key ingredients for making what's known as "Spaghetti code".
2021-02-02 15:02:10 +01:00
2020-06-30 12:47:33 +02:00
Such code is hard to read, refactor and therefore maintain.
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
With the default threshold of 3:
2022-02-04 17:28:24 +01:00
[source,csharp]
2020-06-30 12:47:33 +02:00
----
if (condition1) // Compliant - depth = 1
{
/* ... */
if (condition2) // Compliant - depth = 2
{
/* ... */
for(int i = 0; i < 10; i++) // Compliant - depth = 3, not exceeding the limit
{
/* ... */
if (condition4) // Noncompliant - depth = 4
{
if (condition5) // Depth = 5, exceeding the limit, but issues are only reported on depth = 4
{
/* ... */
}
return;
}
}
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../parameters.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]