rspec/rules/S5708/php/rule.adoc

63 lines
1.3 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
Instances of classes that do not derive from the "Throwable" interface cannot be used in a PHP "throw" statement. Thus, it does not make sense to try to catch such objects within a "try-catch" block.
2021-02-02 15:02:10 +01:00
Many built-in exceptions such as "Exception" and the SPL exception classes do implement the "Throwable" interface and can be extended when creating custom exceptions.
2021-02-02 15:02:10 +01:00
This rule raises an issue when the classes used to specify the type of objects to be caught in a "try-catch" block do not derive from "Throwable" .
=== Noncompliant code example
2022-02-04 17:28:24 +01:00
[source,php]
----
class NoThrowable {}
try {
foo();
} catch (NoThrowable $e) { // Noncompliant
}
----
=== Compliant solution
2022-02-04 17:28:24 +01:00
[source,php]
----
<?php
class SomeThrowable implements Throwable {
// Implementation of the Throwable methods
}
try {
foo();
} catch (SomeThrowable $e) { // Compliant
}
class SomeCustomException extends Exception {}
try {
foo();
} catch (SomeCustomException $e) { // Compliant
}{code}
 
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::message.adoc[]
include::highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]