44 lines
1.4 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
On the principle that clearer code is better code, you should explicitly `import` the things you want to use in a module. Using ``++import *++`` imports everything in the module and risks confusing maintainers. Similarly, ``++export * from "module";++`` imports and then re-exports everything in the module and risks confusing not just maintainers but also the module's users.
2020-06-30 12:48:07 +02:00
=== Code examples
2020-06-30 12:48:07 +02:00
==== Noncompliant code example
[source,javascript,diff-id=1,diff-type=noncompliant]
2020-06-30 12:48:07 +02:00
----
import * as Imported from "aModule"; // Noncompliant
----
==== Compliant solution
[source,javascript,diff-id=1,diff-type=compliant]
----
import {aType, aFunction} from "aModule";
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Explicitly import the specific member needed.
'''
== Comments And Links
(visible only on this page)
=== on 5 Feb 2016, 15:31:27 Elena Vilchik wrote:
\[~ann.campbell.2] Actually there is no problems with scopes or name conflicts when using wildcard in JS: all you have imported are properties of `Imported`. So I would just remove first sentence and keep the second one reworked a bit: "Listing the necessary imports makes clear what's wanted."
=== on 5 Feb 2016, 16:39:27 Ann Campbell wrote:
See what you think now [~elena.vilchik]
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]