2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2020-06-30 12:47:33 +02:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Noncompliant code example
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,go]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
|
|
|
switch i {
|
|
|
|
case 1:
|
|
|
|
doFirstThing()
|
|
|
|
doSomething()
|
|
|
|
case 2:
|
|
|
|
doSomethingElse()
|
|
|
|
case 3: // Noncompliant; duplicates case 1's implementation
|
|
|
|
doFirstThing()
|
|
|
|
doSomething()
|
|
|
|
default:
|
|
|
|
doTheRest()
|
|
|
|
}
|
|
|
|
|
|
|
|
if a >= 0 && a < 10 {
|
|
|
|
doFirstThing()
|
|
|
|
doSomething()
|
|
|
|
} else if a >= 10 && a < 20 {
|
|
|
|
doSomethingElse()
|
|
|
|
} else if a >= 20 && a < 50 {
|
|
|
|
doFirstThing()
|
|
|
|
doSomething() // Noncompliant; duplicates first condition
|
|
|
|
} else {
|
|
|
|
doTheRest()
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Exceptions
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2021-01-27 13:42:22 +01:00
|
|
|
Blocks in an ``++if++`` chain or ``++case++`` blocks that contain a single line of code are ignored.
|
2020-06-30 14:49:38 +02:00
|
|
|
|
2023-05-25 14:18:12 +02:00
|
|
|
[source,go]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
|
|
|
if a == 1 {
|
|
|
|
doSomething() //no issue, usually this is done on purpose to increase the readability
|
|
|
|
} else if a == 2 {
|
|
|
|
doSomethingElse()
|
|
|
|
} else {
|
|
|
|
doSomething()
|
|
|
|
}
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|