diff --git a/rules/S7437/metadata.json b/rules/S7437/metadata.json new file mode 100644 index 0000000000..2c63c08510 --- /dev/null +++ b/rules/S7437/metadata.json @@ -0,0 +1,2 @@ +{ +} diff --git a/rules/S7437/rust/metadata.json b/rules/S7437/rust/metadata.json new file mode 100644 index 0000000000..09afb3989b --- /dev/null +++ b/rules/S7437/rust/metadata.json @@ -0,0 +1,24 @@ +{ + "title": "Variables should be swapped using `std::mem::swap`", + "type": "BUG", + "status": "ready", + "remediation": { + "func": "Constant\/Issue", + "constantCost": "5min" + }, + "tags": [ + "clippy" + ], + "defaultSeverity": "Blocker", + "ruleSpecification": "RSPEC-7437", + "sqKey": "S7437", + "scope": "All", + "defaultQualityProfiles": ["Sonar way"], + "quickfix": "unknown", + "code": { + "impacts": { + "RELIABILITY": "HIGH" + }, + "attribute": "LOGICAL" + } +} diff --git a/rules/S7437/rust/rule.adoc b/rules/S7437/rust/rule.adoc new file mode 100644 index 0000000000..f2b99c3561 --- /dev/null +++ b/rules/S7437/rust/rule.adoc @@ -0,0 +1,29 @@ + +== Why is this an issue? +The sequence `foo = bar; bar = foo` looks like a failed attempt to swap the values of two variables. This code mistakenly reassigns both variables, leading to incorrect and unintended behavior. Using `std::mem::swap` ensures a correct and intended swap. + + +=== Code examples + +==== Noncompliant code example +[source,rust,diff-id=1,diff-type=noncompliant] +---- +let mut foo = 1; +let mut bar = 2; +foo = bar; // Noncompliant +bar = foo; // Noncompliant +---- + +==== Compliant solution + +[source,rust,diff-id=1,diff-type=compliant] +---- +let mut foo = 1; +let mut bar = 2; +std::mem::swap(&mut foo, &mut bar); // Compliant +---- + +== Resources +=== Documentation + +* Clippy Lints - https://rust-lang.github.io/rust-clippy/master/index.html#almost_swapped