Create rule S6717(secrets): Slack Workflow Webhook URLs should not be disclosed (#2942)
You can preview this rule [here](https://sonarsource.github.io/rspec/#/rspec/S6717/secrets) (updated a few minutes after each push). ## Review A dedicated reviewer checked the rule description successfully for: - [ ] logical errors and incorrect information - [ ] information gaps and missing content - [ ] text style and tone - [ ] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) --------- Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
This commit is contained in:
parent
ec4643680c
commit
57e9ea916f
2
rules/S6717/metadata.json
Normal file
2
rules/S6717/metadata.json
Normal file
@ -0,0 +1,2 @@
|
|||||||
|
{
|
||||||
|
}
|
58
rules/S6717/secrets/metadata.json
Normal file
58
rules/S6717/secrets/metadata.json
Normal file
@ -0,0 +1,58 @@
|
|||||||
|
{
|
||||||
|
"title": "Slack workflow webhook URLs should not be disclosed",
|
||||||
|
"type": "VULNERABILITY",
|
||||||
|
"code": {
|
||||||
|
"impacts": {
|
||||||
|
"SECURITY": "HIGH"
|
||||||
|
},
|
||||||
|
"attribute": "TRUSTWORTHY"
|
||||||
|
},
|
||||||
|
"status": "ready",
|
||||||
|
"remediation": {
|
||||||
|
"func": "Constant\/Issue",
|
||||||
|
"constantCost": "30min"
|
||||||
|
},
|
||||||
|
"tags": [
|
||||||
|
"cwe",
|
||||||
|
"cert"
|
||||||
|
],
|
||||||
|
"extra": {
|
||||||
|
"replacementRules": [
|
||||||
|
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"defaultSeverity": "Blocker",
|
||||||
|
"ruleSpecification": "RSPEC-6717",
|
||||||
|
"sqKey": "S6717",
|
||||||
|
"scope": "All",
|
||||||
|
"securityStandards": {
|
||||||
|
"CWE": [
|
||||||
|
798,
|
||||||
|
259
|
||||||
|
],
|
||||||
|
"OWASP": [
|
||||||
|
"A3"
|
||||||
|
],
|
||||||
|
"CERT": [
|
||||||
|
"MSC03-J."
|
||||||
|
],
|
||||||
|
"OWASP Top 10 2021": [
|
||||||
|
"A7"
|
||||||
|
],
|
||||||
|
"PCI DSS 3.2": [
|
||||||
|
"6.5.10"
|
||||||
|
],
|
||||||
|
"PCI DSS 4.0": [
|
||||||
|
"6.2.4"
|
||||||
|
],
|
||||||
|
"ASVS 4.0": [
|
||||||
|
"2.10.4",
|
||||||
|
"3.5.2",
|
||||||
|
"6.4.1"
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"defaultQualityProfiles": [
|
||||||
|
"Sonar way"
|
||||||
|
],
|
||||||
|
"quickfix": "unknown"
|
||||||
|
}
|
48
rules/S6717/secrets/rule.adoc
Normal file
48
rules/S6717/secrets/rule.adoc
Normal file
@ -0,0 +1,48 @@
|
|||||||
|
include::../../../shared_content/secrets/description.adoc[]
|
||||||
|
|
||||||
|
== Why is this an issue?
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/rationale.adoc[]
|
||||||
|
|
||||||
|
=== What is the potential impact?
|
||||||
|
|
||||||
|
Slack Workflow webhook URLs have different effects depending on their
|
||||||
|
permissions: They can be used only to write Slack posts or to trigger other
|
||||||
|
workflows.
|
||||||
|
|
||||||
|
Below are some real-world scenarios that illustrate some impacts of an attacker
|
||||||
|
exploiting the secret.
|
||||||
|
|
||||||
|
:secret_type: webhook
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/impact/phishing.adoc[]
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/impact/malware_distribution.adoc[]
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/impact/codeless_vulnerability_chaining.adoc[]
|
||||||
|
|
||||||
|
== How to fix it
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/fix/revoke.adoc[]
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/fix/vault.adoc[]
|
||||||
|
|
||||||
|
=== Code examples
|
||||||
|
|
||||||
|
:example_secret: https://hooks.slack.com/workflows/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
|
||||||
|
:example_name: slack_webhook_url
|
||||||
|
:example_env: SLACK_WEBHOOK_URL
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/examples.adoc[]
|
||||||
|
|
||||||
|
//=== How does this work?
|
||||||
|
|
||||||
|
//=== Pitfalls
|
||||||
|
|
||||||
|
//=== Going the extra mile
|
||||||
|
|
||||||
|
== Resources
|
||||||
|
|
||||||
|
include::../../../shared_content/secrets/resources/standards.adoc[]
|
||||||
|
|
||||||
|
//=== Benchmarks
|
Loading…
x
Reference in New Issue
Block a user