ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Modify rule S6932: Update code example (#4563)

Browse Source
This commit is contained in:
Mary Georgiou 2024-12-17 17:28:30 +01:00 committed by GitHub
parent 77c4627ffb
commit 5e18970336
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
rules/S6932/csharp/rule.adoc
View File

@ -69,7 +69,6 @@ public IActionResult Post()
var name = Request.Form["name"]; // Noncompliant: Request.Form var name = Request.Form["name"]; // Noncompliant: Request.Form
var birthdate = DateTime.Parse(Request.Form["Birthdate"]); // Noncompliant: Request.Form var birthdate = DateTime.Parse(Request.Form["Birthdate"]); // Noncompliant: Request.Form
var origin = Request.Headers[HeaderNames.Origin]; // Noncompliant: Request.Headers
var locale = Request.Query.TryGetValue("locale", out var locales) var locale = Request.Query.TryGetValue("locale", out var locales)
? locales.ToString() ? locales.ToString()
: "en-US"; // Noncompliant: Request.Query : "en-US"; // Noncompliant: Request.Query
@ -163,6 +162,17 @@ public ActionResult Post(User user, [Bind(Prefix = "locale")] string cultureName
// ... // ...
} }
} }
public IActionResult Post()
{
var origin = Request.Headers[HeaderNames.Origin]; // Compliant: Access via non-constant field
var nameField = "name";
var name = Request.Form[nameField]; // Compliant: Access via local
var birthdate = DateTime.Parse(Request.Form["Birthdate"]); // Compliant: Access via constant and variable keys is mixed.
// Model binding would only work partially in the method, so we do not raise here.
return Ok();
// ..
}
---- ----
include::../how-does-this-work.adoc[] include::../how-does-this-work.adoc[]