ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Modify rule S3252: add diff view

Browse Source
This commit is contained in:
Amelie Renard 2023-10-05 11:38:04 +02:00 committed by Amélie Renard
parent faf38605f7
commit 5e831aed2f
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
rules/S3252/cfamily/rule.adoc
View File

@ -4,7 +4,7 @@ In the interest of code clarity, ``++static++`` member variables of a base class
=== Noncompliant code example === Noncompliant code example
[source,cpp] [source,cpp,diff-id=1,diff-type=noncompliant]
---- ----
class Parent { class Parent {
public: public:
@ -14,8 +14,7 @@ class Parent {
class Child : public Parent { class Child : public Parent {
public: public:
Child() : myColor(Child::defaultColor) // Compliant, this is a constant Child() : myColor(Child::defaultColor) { // Compliant: defaultColor is a constant
{
Child::count++; // Noncompliant Child::count++; // Noncompliant
} }
}; };
@ -23,7 +22,7 @@ class Child : public Parent {
=== Compliant solution === Compliant solution
[source,cpp] [source,cpp,diff-id=1,diff-type=compliant]
---- ----
class Parent { class Parent {
public: public:
@ -33,8 +32,7 @@ class Parent {
class Child : public Parent { class Child : public Parent {
public: public:
Child() : myColor(Child::defaultColor) // Compliant, this is a constant Child() : myColor(Child::defaultColor) { // Compliant: defaultColor is a constant
{
Parent::count++; Parent::count++;
} }
}; };
@ -100,7 +98,7 @@ In this case it would be:
=== on 23 Jan 2016, 14:53:05 Ann Campbell wrote: === on 23 Jan 2016, 14:53:05 Ann Campbell wrote:
That's fine [~alban.auzeill]. That's fine [~alban.auzeill].
include::../comments-and-links.adoc[] include::../comments-and-links.adoc[]