From 8586551b59f8bddd511a3b3495b69ce0ab4a8f53 Mon Sep 17 00:00:00 2001 From: teemu-rytilahti-sonarsource Date: Tue, 4 Mar 2025 09:50:45 +0100 Subject: [PATCH] Add newlines around includes in secrets template (#4718) * Add newlines around includes in secrets template * Mention that new lines are needed around includes --------- Co-authored-by: Daniel Teuchert Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com> --- .../rspec_template/single_language/secrets/rule.adoc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/rspec-tools/rspec_template/single_language/secrets/rule.adoc b/rspec-tools/rspec_template/single_language/secrets/rule.adoc index 4de72c822a..40427fd7d3 100644 --- a/rspec-tools/rspec_template/single_language/secrets/rule.adoc +++ b/rspec-tools/rspec_template/single_language/secrets/rule.adoc @@ -19,7 +19,7 @@ include::../../../shared_content/secrets/rationale.adoc[] include::../../../shared_content/secrets/impact/generic_impact.adoc[] -// Uncomment the following line, if specifying detailed impacts from below: +// Uncomment the following line, if specifying detailed impacts from below (also make sure to have new lines around the uncommented includes): // include::../../../shared_content/secrets/impact/specific_impact_intro.adoc[] // Secret may allow hosting arbitrary files @@ -88,15 +88,19 @@ include::../../../shared_content/secrets/impact/generic_impact.adoc[] == How to fix it // 1. Revoke leaked secrets + include::../../../shared_content/secrets/fix/revoke.adoc[] // 2. Analyze recent use to identify misuse + include::../../../shared_content/secrets/fix/recent_use.adoc[] // 3. Use a secret vault in the future + include::../../../shared_content/secrets/fix/vault.adoc[] // 4. Never hard-code secrets + include::../../../shared_content/secrets/fix/default.adoc[] // OAuth PKCE is very specific to OAuth 2.0