Create rule S2198: Unnecessary mathematical comparisons should not be made (#4692)
* Add rust to rule S2198 * Add rule description * Update rule.adoc --------- Co-authored-by: sallaigy <sallaigy@users.noreply.github.com> Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
This commit is contained in:
parent
feaf726b3a
commit
d17e141be3
7
rules/S2198/rust/metadata.json
Normal file
7
rules/S2198/rust/metadata.json
Normal file
@ -0,0 +1,7 @@
|
||||
{
|
||||
"title": "Unnecessary mathematical comparisons should not be made",
|
||||
"tags": [
|
||||
"clippy",
|
||||
"suspicious"
|
||||
]
|
||||
}
|
18
rules/S2198/rust/rule.adoc
Normal file
18
rules/S2198/rust/rule.adoc
Normal file
@ -0,0 +1,18 @@
|
||||
== Why is this an issue?
|
||||
|
||||
An expression like `min <= x` may misleadingly imply that it is possible for `x` to be less than the minimum. Expressions like `max < x` are likely mistakes, as they can never be true. These comparisons involving minimum or maximum values for their type with integer and boolean types are often unintentional and can lead to confusion and potentially incorrect program logic.
|
||||
|
||||
=== Noncompliant code example
|
||||
|
||||
[source,rust]
|
||||
----
|
||||
let vec: Vec<isize> = Vec::new();
|
||||
if vec.len() <= 0 {} // Noncompliant: 0 is the minimum value for usize, this is always true.
|
||||
|
||||
if 100 > i32::MAX {} // Noncompliant: i32::MAX is the maximum value for i32, this is always false.
|
||||
----
|
||||
|
||||
== Resources
|
||||
=== Documentation
|
||||
|
||||
* Clippy Lints - https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
|
Loading…
x
Reference in New Issue
Block a user