From e7c5865c645d1d0268b89a1c9e6ec005c056545e Mon Sep 17 00:00:00 2001 From: Quentin Jaquier Date: Fri, 7 Mar 2025 14:04:22 +0100 Subject: [PATCH] SONARGO-393 Modify rule S4423 for Go: remove examples for HTTP servers (#4726) --- rules/S4423/go/how-to-fix-it/stdlib.adoc | 48 ------------------------ 1 file changed, 48 deletions(-) diff --git a/rules/S4423/go/how-to-fix-it/stdlib.adoc b/rules/S4423/go/how-to-fix-it/stdlib.adoc index 9160bdd164..a53b89d021 100644 --- a/rules/S4423/go/how-to-fix-it/stdlib.adoc +++ b/rules/S4423/go/how-to-fix-it/stdlib.adoc @@ -28,25 +28,6 @@ func main() { } ---- -For HTTP servers: - -[source,go,diff-id=2,diff-type=noncompliant] ----- -import ( - "net/http" -) - -func main() { - http.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) { - w.Write([]byte("Hello world!\n")) - }) - err := http.ListenAndServeTLS(":443", "tls.crt", "tls.key", nil) // Noncompliant: TLS 1.0 by default for servers - if err != nil { - panic(err) - } -} ----- - ==== Compliant solution For HTTP clients: @@ -67,35 +48,6 @@ func main() { } ---- -For HTTP servers: - -[source,go,diff-id=2,diff-type=compliant] ----- -import ( - "crypto/tls" - "net/http" -) - -func main() { - mux := http.NewServeMux() - mux.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) { - w.Write([]byte("Hello world!\n")) - }) - cfg := &tls.Config{ - MinVersion: tls.VersionTLS12, - } - srv := &http.Server{ - Addr: ":443", - Handler: mux, - TLSConfig: cfg, - } - err := srv.ListenAndServeTLS("tls.crt", "tls.key") - if err != nil { - panic(err) - } -} ----- - === How does this work?