diff --git a/rspec-tools/rspec_tools/validation/rule-metadata-schema.json b/rspec-tools/rspec_tools/validation/rule-metadata-schema.json index b1f601a7cb..3a83234db4 100644 --- a/rspec-tools/rspec_tools/validation/rule-metadata-schema.json +++ b/rspec-tools/rspec_tools/validation/rule-metadata-schema.json @@ -77,6 +77,13 @@ "$ref": "#/definitions/time" } } + }, { + "additionalProperties": false, + "properties": { + "func": { + "const": "Unpredictable" + } + } } ] }, @@ -231,7 +238,7 @@ "definitions": { "time": { "type": "string", - "pattern": "^[ ]*[0-9]+[ ]*(mn|min|h|d)$" + "pattern": "^[ ]*[1-9][0-9]*[ ]*(mn|min|h|d)$" } } } diff --git a/rules/S1134/metadata.json b/rules/S1134/metadata.json index 2c0990d071..983e09c4da 100644 --- a/rules/S1134/metadata.json +++ b/rules/S1134/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "cwe" diff --git a/rules/S1135/metadata.json b/rules/S1135/metadata.json index cc20189e91..1eb1c66ca8 100644 --- a/rules/S1135/metadata.json +++ b/rules/S1135/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "cwe" diff --git a/rules/S1239/cfamily/metadata.json b/rules/S1239/cfamily/metadata.json index ddeff24236..3b6cbd456e 100644 --- a/rules/S1239/cfamily/metadata.json +++ b/rules/S1239/cfamily/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S124/metadata.json b/rules/S124/metadata.json index 64d71fb7ca..a185453e1b 100644 --- a/rules/S124/metadata.json +++ b/rules/S124/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1251/cfamily/metadata.json b/rules/S1251/cfamily/metadata.json index 88103d07c5..3959829934 100644 --- a/rules/S1251/cfamily/metadata.json +++ b/rules/S1251/cfamily/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1256/cfamily/metadata.json b/rules/S1256/cfamily/metadata.json index 27ef87b672..4106529b67 100644 --- a/rules/S1256/cfamily/metadata.json +++ b/rules/S1256/cfamily/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1267/cfamily/metadata.json b/rules/S1267/cfamily/metadata.json index bd0fc4ba94..c9e7381472 100644 --- a/rules/S1267/cfamily/metadata.json +++ b/rules/S1267/cfamily/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1272/cfamily/metadata.json b/rules/S1272/cfamily/metadata.json index fc4c8d17e8..1813ffeb08 100644 --- a/rules/S1272/cfamily/metadata.json +++ b/rules/S1272/cfamily/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1489/abap/metadata.json b/rules/S1489/abap/metadata.json index eee1939637..340b2c4021 100644 --- a/rules/S1489/abap/metadata.json +++ b/rules/S1489/abap/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1490/abap/metadata.json b/rules/S1490/abap/metadata.json index 50a8c7245d..c89369cd3d 100644 --- a/rules/S1490/abap/metadata.json +++ b/rules/S1490/abap/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1509/abap/metadata.json b/rules/S1509/abap/metadata.json index 7a3c8141c9..b34f80504b 100644 --- a/rules/S1509/abap/metadata.json +++ b/rules/S1509/abap/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1681/cobol/metadata.json b/rules/S1681/cobol/metadata.json index 456a4485c2..29b3ff0b44 100644 --- a/rules/S1681/cobol/metadata.json +++ b/rules/S1681/cobol/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S1914/cfamily/metadata.json b/rules/S1914/cfamily/metadata.json index ff3faa785e..ae3305be9e 100644 --- a/rules/S1914/cfamily/metadata.json +++ b/rules/S1914/cfamily/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S2113/java/metadata.json b/rules/S2113/java/metadata.json index 72b1a5246e..a9e173d34b 100644 --- a/rules/S2113/java/metadata.json +++ b/rules/S2113/java/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "bug" diff --git a/rules/S2253/metadata.json b/rules/S2253/metadata.json index aa2f2793bf..802d041c06 100644 --- a/rules/S2253/metadata.json +++ b/rules/S2253/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S2260/cfamily/metadata.json b/rules/S2260/cfamily/metadata.json index ded19e10bb..b4f697c8b0 100644 --- a/rules/S2260/cfamily/metadata.json +++ b/rules/S2260/cfamily/metadata.json @@ -1,7 +1,6 @@ { "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "sqKey": "ParsingError" } diff --git a/rules/S3417/xml/metadata.json b/rules/S3417/xml/metadata.json index d16968a592..8fe75f2d4c 100644 --- a/rules/S3417/xml/metadata.json +++ b/rules/S3417/xml/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "maven" diff --git a/rules/S3546/java/metadata.json b/rules/S3546/java/metadata.json index 23564efddf..e3f0c20a88 100644 --- a/rules/S3546/java/metadata.json +++ b/rules/S3546/java/metadata.json @@ -3,8 +3,7 @@ "type": "BUG", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "denial-of-service" diff --git a/rules/S3575/csharp/metadata.json b/rules/S3575/csharp/metadata.json index 1ebf513423..61091d6fea 100644 --- a/rules/S3575/csharp/metadata.json +++ b/rules/S3575/csharp/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "finding", diff --git a/rules/S3688/metadata.json b/rules/S3688/metadata.json index c0651fe0d4..cbc3f8fd32 100644 --- a/rules/S3688/metadata.json +++ b/rules/S3688/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S3938/cobol/metadata.json b/rules/S3938/cobol/metadata.json index 261e5eba31..346b9296be 100644 --- a/rules/S3938/cobol/metadata.json +++ b/rules/S3938/cobol/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S4011/java/metadata.json b/rules/S4011/java/metadata.json index 256a16d069..ea140cceea 100644 --- a/rules/S4011/java/metadata.json +++ b/rules/S4011/java/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S4439/javascript/metadata.json b/rules/S4439/javascript/metadata.json index 4f5c4c7d87..470a5138ed 100644 --- a/rules/S4439/javascript/metadata.json +++ b/rules/S4439/javascript/metadata.json @@ -3,8 +3,7 @@ "type": "BUG", "status": "closed", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "antipattern", diff --git a/rules/S5639/cfamily/metadata.json b/rules/S5639/cfamily/metadata.json index bb3fd9912c..29e50a41f1 100644 --- a/rules/S5639/cfamily/metadata.json +++ b/rules/S5639/cfamily/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ diff --git a/rules/S6212/java/metadata.json b/rules/S6212/java/metadata.json index f93c9e8022..de0c76d4d6 100644 --- a/rules/S6212/java/metadata.json +++ b/rules/S6212/java/metadata.json @@ -3,8 +3,7 @@ "type": "CODE_SMELL", "status": "ready", "remediation": { - "func": "Constant\/Issue", - "constantCost": "0min" + "func": "Unpredictable" }, "tags": [ "java10"