From f6dfcca980666b447fbd3b06e526a0a0924717d3 Mon Sep 17 00:00:00 2001 From: Anton Haubner Date: Thu, 3 Aug 2023 17:09:14 +0200 Subject: [PATCH] Modify rule S2734: Python: Don't replace with S935 (#2774) S935 has been merged with S6658. As part of that merge, S935 has been restricted to a specific set of special functions for now, not including `__init__`. Hence, we keep S2734 at the moment, until S935 is extended to cover more functions. See also * https://github.com/SonarSource/sonar-python/pull/1529#discussion_r1282759218 * https://github.com/SonarSource/sonar-python/pull/1528 * https://sonarsource.slack.com/archives/CFUS31LRE/p1690534750237959 --- rules/S2734/python/metadata.json | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/rules/S2734/python/metadata.json b/rules/S2734/python/metadata.json index e68d0bfd79..88386ccd85 100644 --- a/rules/S2734/python/metadata.json +++ b/rules/S2734/python/metadata.json @@ -1,7 +1,7 @@ { "title": "\"__init__\" should not return a value", "type": "BUG", - "status": "superseded", + "status": "ready", "remediation": { "func": "Constant\/Issue", "constantCost": "5min" @@ -9,14 +9,6 @@ "tags": [ ], - "extra": { - "replacementRules": [ - "RSPEC-935" - ], - "legacyKeys": [ - - ] - }, "defaultSeverity": "Blocker", "ruleSpecification": "RSPEC-2734", "sqKey": "S2734",