From f93da5854a62972b2cd5b5effa34c9d17fbd5e37 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 19 Mar 2025 15:07:55 +0100
Subject: [PATCH] Create rule S1764: Identical expressions should not be used
 on both sides of a binary operator (#4681)

* Add rust to rule S1764

* Add rule description

* Whitespace

* Update metadata.json

* Fix JSON syntax

* Update rule.adoc

* Update rule.adoc

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
---
 rules/S1764/rust/metadata.json |  7 ++++++
 rules/S1764/rust/rule.adoc     | 40 ++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 rules/S1764/rust/metadata.json
 create mode 100644 rules/S1764/rust/rule.adoc

diff --git a/rules/S1764/rust/metadata.json b/rules/S1764/rust/metadata.json
new file mode 100644
index 0000000000..48d7fcd489
--- /dev/null
+++ b/rules/S1764/rust/metadata.json
@@ -0,0 +1,7 @@
+{
+  "title": "Identical expressions should not be used on both sides of a binary operator",
+  "tags": [
+    "cert",
+    "clippy"
+  ]
+}
diff --git a/rules/S1764/rust/rule.adoc b/rules/S1764/rust/rule.adoc
new file mode 100644
index 0000000000..0ecb03bb06
--- /dev/null
+++ b/rules/S1764/rust/rule.adoc
@@ -0,0 +1,40 @@
+== Why is this an issue?
+
+Using the same value on either side of a binary operator is almost always a mistake. In the case of logical operators, it is either a copy/paste error and therefore a bug, or it is simply wasted code, and should be simplified. In the case of bitwise operators and most binary mathematical operators, having the same value on both sides of an operator yields predictable results, and should be simplified.
+
+=== Noncompliant code example
+
+[source,rust]
+----
+if a == a { // always true
+  doZ();
+}
+if a != a  { // always false
+  doY();
+}
+
+assert_eq!(a, a); // always true
+----
+
+== Resources
+=== Documentation
+
+* Clippy Lints - https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
+
+ifdef::env-github,rspecator-view[]
+
+'''
+== Implementation Specification
+(visible only on this page)
+
+include::../message.adoc[]
+
+include::../highlighting.adoc[]
+
+'''
+== Comments And Links
+(visible only on this page)
+
+include::../comments-and-links.adoc[]
+
+endif::env-github,rspecator-view[]