Create rule S1764: Identical expressions should not be used on both sides of a binary operator (#4681)

* Add rust to rule S1764

* Add rule description

* Whitespace

* Update metadata.json

* Fix JSON syntax

* Update rule.adoc

* Update rule.adoc

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
This commit is contained in:
github-actions[bot] 2025-03-19 15:07:55 +01:00 committed by GitHub
parent aa593087ba
commit f93da5854a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 47 additions and 0 deletions

View File

@ -0,0 +1,7 @@
{
"title": "Identical expressions should not be used on both sides of a binary operator",
"tags": [
"cert",
"clippy"
]
}

View File

@ -0,0 +1,40 @@
== Why is this an issue?
Using the same value on either side of a binary operator is almost always a mistake. In the case of logical operators, it is either a copy/paste error and therefore a bug, or it is simply wasted code, and should be simplified. In the case of bitwise operators and most binary mathematical operators, having the same value on both sides of an operator yields predictable results, and should be simplified.
=== Noncompliant code example
[source,rust]
----
if a == a { // always true
doZ();
}
if a != a { // always false
doY();
}
assert_eq!(a, a); // always true
----
== Resources
=== Documentation
* Clippy Lints - https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]