Cristian Ambrosini
31917356e4
Apply comments
2024-05-03 14:46:47 +02:00
Cristian Ambrosini
4bb015ef3f
Draft rule specification
2024-05-03 14:46:47 +02:00
cristian-ambrosini-sonarsource
53e5d95e4f
Create rule S6678
2024-05-03 14:46:38 +02:00
github-actions[bot]
4ec4bb3f9d
Create rule S6966: Awaitable method should be used ( #3854 )
2024-05-03 13:55:11 +02:00
github-actions[bot]
21225209cd
Create rule S6968: Actions that return a value should be annotated with ProducesResponseTypeAttribute containing the return type ( #3865 )
...
* Create rule S6968
* First implementation
* Review 1
* Review 2
---------
Co-authored-by: gregory-paidis-sonarsource <gregory-paidis-sonarsource@users.noreply.github.com>
Co-authored-by: Gregory Paidis <gregory.paidis@sonarsource.com>
2024-05-03 07:58:26 +00:00
github-actions[bot]
1cc1063f89
Create rule S6964: The value type properties of a model class should be nullable or marked as "Required" to avoid under-posting. ( #3850 )
2024-05-03 09:32:59 +02:00
github-actions[bot]
af37eec4ac
Create rule S6967: ModelState.IsValid should be called in controller actions ( #3856 )
2024-05-03 09:31:51 +02:00
github-actions[bot]
e6453d5e7b
Create rule S6965: You should use HttpAttribute in API controller actions ( #3851 )
2024-05-03 09:23:46 +02:00
github-actions[bot]
0c27b86a7a
Create rule S6960: Controllers should not have too many responsibilities ( #3845 )
2024-05-03 09:16:59 +02:00
github-actions[bot]
a446adc1e1
Create rule S6962: You should pool HTTP connections with HttpClientFactory ( #3847 )
2024-04-24 14:12:29 +02:00
Mary Georgiou
0dc667373d
Deprecate S6803 ( #3910 )
2024-04-24 13:37:29 +02:00
Pavel Mikula
ae5e8db3d4
Close S2353 ( #3902 )
2024-04-24 10:13:58 +02:00
Victor
8f18cbd013
Fix S5822: wrong escaping ( #3906 )
...
* Fix S6822: Missing resources
* Fix S5822: wrong escaping
* Fix
2024-04-23 14:49:53 +02:00
Victor
53df9ce0f6
Fix S4784: Wrong escaping ( #3907 )
2024-04-23 14:49:40 +02:00
Victor
ff00ed21c4
Fix S6822: Missing resources ( #3905 )
2024-04-23 14:21:01 +02:00
Victor
6f40329a15
Fix S3402: Wrong escaping ( #3908 )
2024-04-23 14:20:10 +02:00
Victor
73d7ae7f25
Fix S2699: Fix list format ( #3909 )
2024-04-23 14:19:49 +02:00
Victor
ed43d82a2b
Fix S5254: Wrong RSPEC on metadata.json ( #3904 )
2024-04-23 14:19:38 +02:00
gaetan-ferry-sonarsource
ab6bf73b3f
Modify rule S5496: Add an how to fix session for Java and Groovy (APPSEC-1587) ( #3900 )
2024-04-23 14:15:29 +02:00
Marcin Stachniuk
def7b6c0ee
SONARIAC-1429 S1192: String literals should be raised less often ( #3903 )
...
* SONARIAC-1429 S1192: String literals should be raised less often
* Code review remarks
Co-authored-by: Peter Trifanov <peter.trifanov@sonarsource.com>
---------
Co-authored-by: Peter Trifanov <peter.trifanov@sonarsource.com>
2024-04-23 11:00:18 +02:00
Pavel Mikula
399f313abf
S2951: Rename ( #3901 )
2024-04-23 08:40:33 +02:00
Victor
9ab2702f26
Modify rule S1093: Add <menu> as allowed parent element for <li> ( #3890 )
...
* Modify rule S1093: Add `<menu>` as allowed parent element for `<li>`
* Add compliant example
2024-04-19 17:09:53 +02:00
Marco Kaufmann
4f43403029
Modify rule S3740: added examples and explanation about "cast", "instanceof" and wildcards ( #3899 )
2024-04-19 13:51:27 +02:00
github-actions[bot]
fb5ed78cc6
Create rule S5260 ( #3887 )
...
* Add javascript to rule S5260
* JS-6 Add rspec for S5260
---------
Co-authored-by: zglicz <zglicz@users.noreply.github.com>
Co-authored-by: Michal Zgliczynski <michal.zgliczynski@sonarsource.com>
2024-04-19 11:12:27 +02:00
Victor
71474b3b21
Rename rule S6855 to S4084 ( #3895 )
2024-04-19 09:41:26 +02:00
Victor
210c908a01
Rename rule S6854 to S1090 ( #3894 )
2024-04-19 09:41:14 +02:00
Victor
b759f8b026
Rename rule S6849 to S5254 ( #3896 )
2024-04-19 09:41:00 +02:00
github-actions[bot]
b91030a2d1
Create rule S6961: API Controllers should derive from ControllerBase instead of Controller ( #3846 )
2024-04-19 08:59:27 +02:00
github-actions[bot]
848e7c2048
Create rule S6975 ( #3892 )
...
* Create rule S6975
* SONARIAC-1424 Split S6956 RSPEC into 2 rules
* Code review remarks
---------
Co-authored-by: mstachniuk <mstachniuk@users.noreply.github.com>
Co-authored-by: Marcin Stachniuk <marcin.stachniuk@sonarsource.com>
2024-04-18 16:58:16 +02:00
gaetan-ferry-sonarsource
173a43b3dd
Modify rule S5147: Adding a how to fix section for Spring Data Redis (APPSEC-1565) ( #3870 )
2024-04-18 14:09:08 +00:00
github-actions[bot]
846d6c7568
Create rule S5496: Server-side templates should not be vulnerable to injection attacks ( #3861 )
...
* Add java to rule S5496
* Add S5496 for Java
* Adjustments based on review
* Fix to make asciidoc tests pass
---------
Co-authored-by: daniel-teuchert-sonarsource <daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Daniel Teuchert <daniel.teuchert@sonarsource.com>
Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
2024-04-18 15:26:08 +02:00
Ghislain Piot
2a35b19260
Modify rule S935: fix typo ( #3893 )
2024-04-18 13:24:22 +00:00
github-actions[bot]
b64b26b71a
Create rule S5256 ( #3886 )
...
* Add javascript to rule S5256
* [JS-3] Add Rspec
---------
Co-authored-by: zglicz <zglicz@users.noreply.github.com>
Co-authored-by: Michal Zgliczynski <michal.zgliczynski@sonarsource.com>
2024-04-18 11:38:03 +02:00
github-actions[bot]
2e71406bdc
Create rule S5264 ( #3889 )
...
* Add javascript to rule S5264
* Add rule S5264 to JS
---------
Co-authored-by: vdiez <vdiez@users.noreply.github.com>
Co-authored-by: Victor <victor.diez@sonarsource.com>
2024-04-17 15:24:34 +02:00
Eric Morand
9e171fa100
Add S1082 HTML variant to the "Sonar way" profile ( #3881 )
2024-04-16 16:44:24 +02:00
Eric Morand
d906701736
Mark S1086 HTML variant as deprecated ( #3879 )
...
As required by SONARHTML-234
2024-04-16 16:43:49 +02:00
Eric Morand
a42c984138
Mark S1089 HTML variant as deprecated ( #3878 )
...
As required by SONARHTML-233
2024-04-16 16:10:23 +02:00
Eric Morand
a04035d924
Mark S1091 HTML variant as deprecated ( #3880 )
...
As required by SONARHTML-235
2024-04-16 15:54:37 +02:00
github-actions[bot]
0e7442f08f
Create rule S5257 ( #3882 )
...
* Add javascript to rule S5257
* Add S5257 to JS
* add react tag
---------
Co-authored-by: vdiez <vdiez@users.noreply.github.com>
Co-authored-by: Victor <victor.diez@sonarsource.com>
2024-04-16 15:54:20 +02:00
Eric Morand
3f8b524a39
Resolve SONARHTML-232 (Deprecate S1092) ( #3877 )
2024-04-16 15:28:17 +02:00
Eric Morand
32d21525d3
Resolve SONARHTML-231 - Deprecate S1085:html ( #3874 )
...
* Resolve SONARHTML-231
* Remove the rule from SonarWay profile
2024-04-15 16:57:10 +02:00
Marcin Stachniuk
cffa338ea2
SONARIAC-1381 S6956 improve description ( #3875 )
...
* SONARIAC-1381 S6956 improve description
* Code review remarks
Co-authored-by: Jonas Wielage <jonas.wielage@sonarsource.com>
---------
Co-authored-by: Jonas Wielage <jonas.wielage@sonarsource.com>
2024-04-15 16:56:41 +02:00
Nils Werner
7e0731106a
Modify rule S6437: Fix JSON code examples ( #3873 )
2024-04-15 15:29:42 +02:00
Tim Pohlmann
2f851ec442
Modify rule S2094: Add an exception ( #3867 )
2024-04-15 10:51:00 +02:00
Nils Werner
a603a39cd8
Modify rule S1192: Add exception for ARM ( #3871 )
2024-04-15 08:42:09 +00:00
Tim Pohlmann
eda6b67051
Modify rule S1104: Add exception for [Serializable] ( #3539 )
2024-04-15 07:32:55 +00:00
github-actions[bot]
ac24b76b0f
Create rule S6899 ( #3589 )
2024-04-12 16:03:12 +02:00
github-actions[bot]
473c6826ad
Create rule S6819 ( #3866 )
...
* Add html to rule S6819
* Add rule S6819 for html
* add noncompliant comments
---------
Co-authored-by: vdiez <vdiez@users.noreply.github.com>
Co-authored-by: Victor <victor.diez@sonarsource.com>
2024-04-12 11:18:00 +02:00
github-actions[bot]
4250db6bfc
Create rule S6824: Add the rule implementation for html ( #3852 )
...
* Add html to rule S6824
* Update PR with shared message
---------
Co-authored-by: zglicz <zglicz@users.noreply.github.com>
Co-authored-by: Michal Zgliczynski <michal.zgliczynski@sonarsource.com>
2024-04-12 09:52:52 +02:00
github-actions[bot]
6ab887f6fb
Create rule S6886 ( #3572 )
...
* Create rule S6886
* Specify rule
* CR fixes
* CR fixes
* Modify rule classification and impacts
* Invert two words
---------
Co-authored-by: maksim-grebeniuk-sonarsource <maksim-grebeniuk-sonarsource@users.noreply.github.com>
Co-authored-by: Maksim Grebeniuk <maksim.grebeniuk@sonarsource.com>
Co-authored-by: Ghislain Piot <ghislain.piot@sonarsource.com>
2024-04-11 17:54:23 +02:00
