ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,322 Commits 329 Branches 2 Tags
Commit Graph

5322 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rudy Regazzoni
266cde4510
SONARGO-118 Update S2068 exception category (#4823) 2025-03-27 09:26:11 +00:00
hashicorp-vault-sonar-prod[bot]
538d0b0b4f
update coverage information (#4849) 
Co-authored-by: SonarTech <sonartech@sonarsource.com>
 2025-03-27 02:49:10 +00:00
Egon Okerman
6b9c19eceb
Update rule S7201: Disable rule and move rule text to S6363 (SONARKT-636) (#4802) 
* Close S7201

* Update S6363 with updated descriptions

* Update OWASP categories with S7201 info
 2025-03-26 10:57:39 +00:00
github-actions[bot]
1490c6d3f0
Modify rule S3776: Add Rust (#4825) 
* Add rust to rule S3776

* Update rule.adoc

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-26 09:36:59 +00:00
Arseniy Zaostrovnykh
110ce01fce
Modify rule S5443(cfamily): Fix src blocks highlighting (#4837) 2025-03-26 08:36:49 +00:00
Loïc Joly
d2964e7f0b
Revert "Fix frontend_tests job long running times (#4829)" (#4836) 
This workaround should no longer be required, the initial bug in SCA analysis has been fixed.

This reverts commit 1012f37ffaf9774ad41f4826ea5854ae08893ec7.
 2025-03-26 06:25:52 +00:00
hashicorp-vault-sonar-prod[bot]
ccef1ab5e6
update coverage information (#4835) 
Co-authored-by: SonarTech <sonartech@sonarsource.com>
 2025-03-26 02:48:47 +00:00
Peter Trifanov
d4177370f1
SONARIAC-1868 S6273 should support prefixes and not be in sonar-way (#4824) 2025-03-25 15:38:55 +00:00
github-actions[bot]
f15fa27234
SONARIAC-1869 Create rule S7452 AWS resource tags should have valid format (#4821) 
* Create rule S7452

* SONARIAC-1869 Create rule S7452 AWS resource tags should have valid format

---------

Co-authored-by: petertrr <petertrr@users.noreply.github.com>
Co-authored-by: Peter Trifanov <peter.trifanov@sonarsource.com>
 2025-03-25 15:32:07 +00:00
Pierre-Loup
84d701ffe5
Create rule S5344 for Kotlin (SONARKT-582) (#4803) 
* Create rule S5344 for Kotlin

* Apply review suggestions
 2025-03-25 15:04:15 +00:00
Arseniy Zaostrovnykh
1012f37ffa
Fix frontend_tests job long running times (#4829) 2025-03-25 13:57:34 +00:00
Arseniy Zaostrovnykh
f18135cc24
Adjust update_coverage GH Action to work with Merge Queue (#4806) 
* Try merging with the queue

* Provide github token

* Fix syntax

* Get GITHUB_TOKEN from vault

* Add the PR label

* Wait for the new PR to merge

* Fix working dir

* Inline the script

* Checkout master

* Install python for slack notifications

* Fix logging

* install rspec-tools

* Log actual PR-merge status

* Final adjustments

* Set check interval to 20 seconds

* Test failure

* Fix pr close command

* Revert "Test failure"

This reverts commit c3c2b845feaa047a62ef19fb34c805bf3ef7a23f.

* Update .github/workflows/update_coverage.yml

---------

Co-authored-by: Fred Tingaud <95592999+frederic-tingaud-sonarsource@users.noreply.github.com>
 2025-03-21 16:58:53 +00:00
Gyula Sallai
a8ad04a813
Modify rules S106,S126,S1612,S2148,S7411,S920 Remove from SonarWay (#4820) 2025-03-21 12:54:12 +00:00
hashicorp-vault-sonar-prod[bot]
c9b1950aa9
update coverage information (#4819) 
Co-authored-by: SonarTech <sonartech@sonarsource.com>
 2025-03-21 11:00:05 +00:00
Arseniy Zaostrovnykh
cff5da40b3
Add line to conflict with coverage update (#4816) 
* Add line to conflict with coverage update

* Add another line to engender conflict
 2025-03-21 10:18:21 +00:00
Arseniy Zaostrovnykh
1dca1a1b3f
Add line to conflict with coverage update (#4814) 2025-03-21 10:06:49 +00:00
hashicorp-vault-sonar-prod[bot]
3b7ef14b40
update coverage information (#4813) 
Co-authored-by: SonarTech <sonartech@sonarsource.com>
 2025-03-21 09:54:17 +00:00
Arseniy Zaostrovnykh
0a35748341
Revert "Update coverage information (#4808)" (#4811) 
This reverts commit e240ba5d737b0b0a465ba23a6f99a2e0d41ba5bb.
 2025-03-21 09:34:52 +00:00
hashicorp-vault-sonar-prod[bot]
e240ba5d73
Update coverage information (#4808) 
* Try merging with the queue

* Provide github token

* Fix syntax

* Get GITHUB_TOKEN from vault

* Add the PR label

* update coverage information

---------

Co-authored-by: Arseniy Zaostrovnykh <necto.ne@gmail.com>
Co-authored-by: SonarTech <sonartech@sonarsource.com>
 2025-03-21 08:16:22 +00:00
Pierre-Loup
dd52d59602
Modify rule S6249: update message (#935) 
* S6249: Update issue message

* Add secondary location

* Update code example

Remove "mynoncompliant" from the resource names.
Add language specificators for code blocks

* Apply suggestions from code review

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

* Update secondary location issue message

---------

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
 2025-03-20 14:11:28 +00:00
Pierre-Loup
84ac3f2f9f
Fix missing CWE link for S5542 (#4805) 2025-03-20 13:09:00 +00:00
Pavel Mikula
bfd616337b
Update Jira project keys for T-SQL, PL/SQL and VB6 (#4804) 2025-03-20 09:57:00 +00:00
GabinL21
cd6491db81
SONARTEXT-418 Create rules S7209 to S7402 (#4801) 
* SONARTEXT-418 Create rules S7209 to S7402

* SONARTEXT-418 Create rules S7209 to S7402

* SONARTEXT-418 Add PKCE to OAuth2 secrets

* SONARTEXT-418 Fix validation
 2025-03-19 20:11:43 +00:00
Antonio Aversa
1a1a60f52d
SONARKT-569 Modify rule S4830: add support for WebViews (#4673) 
* SONARKT-569 Modify rule S4830: add support for WebViews

* Fix list of allowed frameworks

* Add Google Support link

* Have non-compliant and compliant code examples next to each other and in diff

* Update rules/S4830/kotlin/how-to-fix-it/android-webview.adoc

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>

* Update rules/S4830/kotlin/how-to-fix-it/android-webview.adoc

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>

---------

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
 2025-03-19 15:31:02 +00:00
Antonio Aversa
d41b77b623
DART-213 Modify rules S1161, S7055: update descriptions and messages (#4799) 
* DART-213 Modify rule S1161: update message details

* S7055: Update description

* Update rule.adoc
 2025-03-19 15:28:12 +00:00
github-actions[bot]
74068df10a
Create rule S1862: Related "if/else if" statements should not have the same condition (#4687) 
* Add rust to rule S1862

* Add rule description

* Fix errors

* Add link to Clippy lint

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 15:22:56 +00:00
github-actions[bot]
164b14aedc
Create rule S107: Functions should not have too many parameters (#4699) 
* Add rust to rule S107

* Update RSPEC

* Remove tag

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
 2025-03-19 14:54:18 +00:00
github-actions[bot]
2713aeaed6
Create rule S3498: Field init shorthand should be used (#4727) 
* Add rust to rule S3498

* Update RSPEC

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 14:46:55 +00:00
github-actions[bot]
ef35f53a80
Create rule S4325: Redundant casts should be avoided (#4729) 
* Add rust to rule S4325

* Update RSPEC

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 14:46:46 +00:00
Yassin Kammoun
c5bb992c80
Create rule S1858: "to_string()" should never be called on a String value (#4730) 
* Add rust to rule S1858

* Update RSPEC

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
 2025-03-19 14:42:54 +00:00
github-actions[bot]
06ad3ace6f
Create rule S106: Standard outputs should not be used directly to log anything (#4735) 
* Add rust to rule S106

* Update RSPEC

* Fix RSPEC

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 14:40:00 +00:00
github-actions[bot]
bd332080f2
Create rule S7439 Comparisons with overlapping ranges that are always false should not be made (#4782) 
* Create rule S7439

* Update rule.adoc

* Update metadata.json

* Update rule.adoc

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:10:52 +00:00
github-actions[bot]
1de188a9e5
Create rule S7443 Calls to std::mem::transmute should not be evaluated eagerly (#4786) 
* Create rule S7443

* Update metadata.json

* Update rule.adoc

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:10:47 +00:00
github-actions[bot]
d4cbb1c40b
Create rule S7449 The #[inline] attribute should not be used on trait methods without implementation (#4793) 
* Create rule S7449

* Update metadata.json

* Update rule.adoc

* Update rule.adoc

* Update rule.adoc

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:10:41 +00:00
github-actions[bot]
70168e8e61
Create rule S7450 Synchronization locks should not be dropped immediately after acquisition (#4794) 
* Create rule S7450

* Update metadata.json

* Update rule.adoc

* Update rule.adoc

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:10:35 +00:00
github-actions[bot]
29af6f4517
Create rule S7438 Incompatible bit masks should not be used in comparisons (#4781) 
* Create rule S7438

* Update rule.adoc

* Update metadata.json

* Update metadata.json

* Update metadata.json

* Update rule.adoc

* Update metadata.json

* Update rule.adoc

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:10:14 +00:00
github-actions[bot]
00d540f5ed
Create rule S7437 Variables should be swapped using std::mem::swap (#4780) 
* Create rule S7437

* Update rule.adoc

* Update metadata.json

* Update metadata.json

* Update metadata.json

* Update metadata.json

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:10:07 +00:00
github-actions[bot]
a02eec56d4
Create rule S7433 Raw pointers should not be casted to slices with differently sized elements (#4774) 
* Create rule S7433

* Update metadata.json

* Update rule.adoc

* Update rule.adoc

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:10:01 +00:00
github-actions[bot]
7b234485eb
Create rule S7428 Case mismatches in pattern arms of match expressions should be avoided (#4769) 
* Create rule S7428

* Update rule.adoc

* Update metadata.json

* Update metadata.json

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:09:52 +00:00
github-actions[bot]
8e35213fbb
Create rule S7426 C-like enums should not have unportable variants (#4767) 
* Create rule S7426

* Update rule.adoc

* Update metadata.json

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:09:47 +00:00
github-actions[bot]
c83072239e
Create rule S7424 Avoid manual PartialEq implementation with a derived Hash (#4765) 
* Create rule S7424

* Update rule.adoc

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:09:42 +00:00
github-actions[bot]
b16523921f
Create rule S7417 Manual PartialOrd implementation should be avoided when Ord is derived (#4757) 
* Create rule S7417

* Update rule.adoc

* Update metadata.json

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:09:19 +00:00
github-actions[bot]
cdb05a081b
Create rule S7413 Await should be used for awaitable returns in async blocks and functions (#4752) 
* Create rule S7413

* Update rule.adoc

* Update metadata.json

* Update rule.adoc

* Update rule.adoc

* Update metadata.json

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:09:13 +00:00
github-actions[bot]
d17e141be3
Create rule S2198: Unnecessary mathematical comparisons should not be made (#4692) 
* Add rust to rule S2198

* Add rule description

* Update rule.adoc

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:09:07 +00:00
github-actions[bot]
feaf726b3a
Create rule S6164: Mathematical constants should not be hardcoded (#4690) 
* Add rust to rule S6164

* Add rule description

* Update rule.adoc

* Add link to Clippy lint

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 14:08:57 +00:00
github-actions[bot]
faeaec31d0
Modify rule S5856: Add language Rust (#4678) 
* Add rust to rule S5856

* Add rule description

* Fix header

* Add Clippy tag and link to Clippy lint

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 14:08:10 +00:00
github-actions[bot]
f93da5854a
Create rule S1764: Identical expressions should not be used on both sides of a binary operator (#4681) 
* Add rust to rule S1764

* Add rule description

* Whitespace

* Update metadata.json

* Fix JSON syntax

* Update rule.adoc

* Update rule.adoc

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2025-03-19 14:07:55 +00:00
github-actions[bot]
aa593087ba
Create rule S6466: Accessing an array element should not trigger a panic (#4684) 
* Add rust to rule S6466

* Update RSPEC

* Remove tag

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 13:38:59 +00:00
github-actions[bot]
5def9014ed
Create rule S6913: Clamping values with cmp::min and cmp::max should use correct ranges (#4689) 
* Add rust to rule S6913

* Update RSPEC

* Remove tag

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 13:38:53 +00:00
github-actions[bot]
0b6c98a1f0
Create rule S4962: "std::ptr::null" should be used to denote the null pointer (#4697) 
* Add rust to rule S4962

* Remove tag

---------

Co-authored-by: yassin-kammoun-sonarsource <yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
 2025-03-19 13:38:48 +00:00