## Review
A dedicated reviewer checked the rule description successfully for:
- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
Languages for which some unique descriptions remain are kept.
This cleaning removes the following rules that were implemented in no
language:
[S1947, S2085, S2086, S2609, S2610, S2614, S2643, S2773, S2776, S3268,
S3272, S3361]
The point of this branch is the second commit that changes
validate_asciidoc.sh. The first one is taken from another PR and should
not be reviewed.
The previous version of the validation could handle the following case:
```asciidoc
:path: path/to/file.adoc
include::{path}[]
```
This new validation also adds support for the case of a variable inside
a path:
```asciidoc
:language: csharp
include::rules/S1000/{language}/file.adoc[]
```
We do not plan to implement these rules as-is. Some have better
alternatives. Some will be covered by MISRA C++:2023 rules.
Co-authored-by: Fred Tingaud <frederic.tingaud@sonarsource.com>
When an include is not surrounded by empty lines, its content is inlined
on the same line as the adjacent content. That can lead to broken tags
and other display issues.
This PR fixes all such includes and introduces a validation step that
forbids introducing the same problem again.
## Review
A dedicated reviewer checked the rule description successfully for:
- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
---------
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
## Review
A dedicated reviewer checked the rule description successfully for:
- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
---------
Co-authored-by: Victor <106590915+victor-diez-sonarsource@users.noreply.github.com>
These rules do not make sense in C++ or are already covered by other
rules.
S140 -- XPath, not relevant
S1166 -- Java, we also have S2486
S1168 -- Java
S1444 -- Java
S1698 -- Java
S1944 -- Other rules: S855, S856, S859
S2189 -- Covered by S5271
S2201 -- Relevant, although could be rephrase: Pure function should be
marked nodiscard, which is S6007
S2251 -- The issue can detected by other means (like OOB)
S2384 -- Java
S3366 -- Java
S3931 -- S1121 is more general