ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,529 Commits 329 Branches 2 Tags
Commit Graph

2529 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Čaba Šagi
c34296e707
Modify rule S2290: Update to LaYC (#2178) 2023-06-14 17:17:39 +02:00
Čaba Šagi
9b7e0791b4
Modify rule S2445: Update to LayC (#2184) 2023-06-14 15:58:29 +02:00
Cristian Ambrosini
dafa102cc0
Modify rule S4583: Update to LaYC (#2185) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 15:44:31 +02:00
Čaba Šagi
285e392afb
Modify rule S4277: Update to LaYC (#2177) 2023-06-14 15:13:08 +02:00
Costin Zaharia
823c9677c9
Modify rule S3445: LaYC format (#2151) 2023-06-14 15:00:43 +02:00
Martin Strecker
b2ead97d57
Modify rule S4275: LaYC format (#2168) 
Update rule content and descriptions to LaYC format.
[S4275: Getters and setters should access the expected
fields](https://sonarsource.github.io/rspec/#/rspec/S4275)

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 14:59:18 +02:00
Fred Tingaud
2cf7d97fd2
Remove languages that were never implemented for shared rules 
Rules that were never implemented for any language are also removed.

Removing, per language:

## cobol
[S103, S1068, S1075, S1125, S1139, S1151, S126, S1301, S1488, S1607,
S1614, S1615, S1639, S1751, S1763, S1820, S1821, S1909, S1940, S1968,
S2024, S2145, S2189, S2190, S2197, S2251, S2252, S2760, S3047, S3269,
S3516, S3635, S3638, S3639, S3645, S3650, S3651, S3776, S3830, S3931,
S4109, S4143, S4158, S4165, S4632, S4663, S5871, S6194, S6273]

## csharp
[S1034, S1103, S1105, S1106, S1107, S1108, S1126, S1131, S1142, S115,
S1166, S117, S119, S1223, S124, S1247, S1312, S1314, S139, S140, S1448,
S1578, S1695, S1707, S1820, S1872, S1874, S1941, S1968, S1987, S2095,
S2107, S2108, S2139, S2145, S2147, S2149, S2159, S2177, S2189, S2205,
S2250, S2301, S2334, S2373, S2490, S2544, S2588, S2596, S2597, S2690,
S2691, S2702, S2752, S2833, S3041, S3044, S3047, S3062, S3065, S3075,
S3076, S3087, S3222, S3239, S3269, S3317, S3325, S3359, S3375, S3414,
S3473, S3516, S3518, S4030, S4165, S4470, S4632, S4977, S5359, S5871,
S6061, S6147, S6194, S864, S867, S899, S997]

## flex
[S1034, S104, S105, S1067, S1075, S109, S1103, S1104, S1105, S1106,
S1107, S1108, S1109, S1110, S1119, S1121, S1126, S113, S1131, S1141,
S1143, S1168, S1192, S1200, S121, S1226, S1247, S126, S1264, S1291,
S139, S1450, S1479, S1488, S1546, S1607, S1656, S1659, S1751, S1763,
S1764, S1782, S1845, S1854, S1858, S1862, S1872, S1905, S1940, S1941,
S1987, S1990, S1994, S2039, S2123, S2139,2145, S2149, S2156, S2159,
S2189, S2190, S2197, S2198, S2201, S2205, S2234, S2251, S2252, S2259,
S2301, S2387, S2440, S2583, S2588, S2589, S2596, S2597, S2639, S2681,
S2691, S2737, S2752, S2757, S2760, S2761, S2887, S2963, S3031, S3041,
S3047, S3065, S3075, S3076, S3222, S3239, S3241, S3242, S3269, S3358,
S3370, S3440, S3458, S3516, S3518, S3776, S3872, S3981, S4025, S4143,
S4144, S4158, S4165, S4632, S4663, S5871, S6194, S878, S881, S899]

## java
[S1034, S1131, S1247, S1453, S1707, S1772, S1782, S1888, S1968, S1990,
S2107, S2108, S2145, S2149, S2198, S2205, S2327, S2373, S2436, S2490,
S2526, S2588, S2596, S2597, S2690, S2691, S2702, S2738, S2752, S2760,
S2814, S2833, S2963, S2997, S3018, S3019, S3031, S3041, S3044, S3062,
S3075, S3076, S3087, S3222, S3239, S3241, S3249, S3263, S3269, S3317,
S3353, S3359, S3370, S3375, S3397, S3440, S3458, S3473, S3604, S3872,
S3887, S3949, S4025, S4030, S4136, S4158, S4632, S4663, S5780, S5781,
S5871, S6194, S787]

## php
[S1034, S109, S1104, S1107, S1119, S1120, S1128, S1143, S1199, S1213,
S1247, S1450, S1694, S1707, S1845, S1858, S1872, S1905, S1941, S1952,
S1968, S1987, S1994, S2095, S2108, S2114, S2139, S2145, S2149, S2156,
S2159, S2177, S2189, S2190, S2197, S2205, S2252, S2259, S2301, S2387,
S2583, S2588, S2589, S2596, S2597, S2639, S2691, S2752, S2760, S2814,
S2833, S3010, S3041, S3047, S3065, S3075, S3239, S3254, S3269, S3400,
S3440, S3458, S3466, S3516, S3518, S3872, S3931, S4030, S4165, S4188,
S4275, S4632, S4663, S5797, S5871, S6194, S864, S899]

## pli
[S104, S105, S1066, S1067, S1068, S1075, S108, S1110, S1135, S1151,
S1172, S1186, S1247, S125, S126, S1291, S1301, S138, S1451, S1479,
S1481, S1488, S1607, S1614, S1615, S1656, S1737, S1745, S1751, S1763,
S1764, S1821, S1854, S1862, S1871, S1909, S1940, S2527, S2583, S2589,
S2681, S2757, S3516, S3633, S3635, S3637, S3638, S3639, S3640, S3641,
S3643, S3644, S3645, S3647, S3650, S3651, S3652, S3776, S3890, S3923,
S3973, S4632, S4663, S5871, S6194, S864]

## abap
[S1045, S1075, S1135, S1144, S1186, S1226, S1291, S138, S1448, S1451,
S1479, S1601, S1607, S1763, S1820, S1821, S1854, S1905, S1909, S1940,
S2147, S2189, S2190, S2387, S2527, S2583, S2589, S2737, S2760, S3047,
S3269, S3358, S3516, S3635, S3637, S3638, S3639, S3640, S3641, S3644,
S3645, S3647, S3650, S3651, S3652, S4109, S4165, S4632, S4663, S5871,
S6194, S864]

## plsql
[S105, S1067, S1075, S1120, S1139, S1186, S1226, S1247, S138, S1488,
S1578, S1607, S1639, S1737, S1738, S1909, S2234, S2583, S2589, S2814,
S3269, S3270, S3358, S3516, S3518, S3635, S3637, S3638, S3639, S3640,
S3644, S3645, S3647, S3650, S3652, S3776, S3890, S3931, S3981, S4109,
S4165, S4413, S4632, S4663, S5871, S6194, S864]

## python
[S105, S1067, S1075, S109, S1125, S1126, S1128, S115, S1155, S1247,
S126, S1314, S1448, S1450, S1488, S1695, S1696, S1820, S1872, S1905,
S1941, S1952, S1987, S1996, S2095, S2114, S2139, S2145, S2149, S2166,
S2189, S2197, S2205, S2251, S2252, S2301, S2321, S2588, S2596, S2597,
S2639, S2691, S2752, S2760, S2833, S2963, S3041, S3047, S3065, S3075,
S3239, S3241, S3254, S3269, S3440, S3458, S3466, S3696, S3717, S3723,
S3872, S4030, S4158, S4165, S4632, S4663, S5871, S6194, S864, S899,
S907]

## javascript
[S1065, S1068, S1103, S1104, S1106, S1107, S1108, S1109, S1142, S1144,
S1147, S115, S1151, S116, S1199, S1200, S1247, S1291, S140, S1448,
S1450, S1578, S1607, S1659, S1707, S1820, S1845, S1872, S1905, S1941,
S1952, S1968, S1987, S1996, S2039, S2108, S2145, S2149, S2159, S2190,
S2205, S2252, S2301, S2326, S2372, S2387, S2588, S2596, S2597, S2691,
S2752, S2830, S2887, S2959, S3041, S3047, S3065, S3075, S3235, S3239,
S3325, S3440, S3458, S3518, S3872, S4025, S4487, S4632, S4663, S5603,
S5871, S6194, S864, S899]

## rpg
[S1066, S107, S1075, S1110, S1135, S1172, S1186, S124, S1247, S1291,
S1301, S131, S1448, S1479, S1481, S1578, S1607, S1614, S1615, S1735,
S1739, S1741, S1745, S1751, S1763, S1821, S1854, S1909, S1940, S1968,
S2189, S2190, S2197, S2251, S2252, S2260, S2527, S2583, S2589, S2757,
S2760, S3047, S3269, S3516, S3635, S3637, S3638, S3639, S3640, S3641,
S3643, S3644, S3645, S3647, S3650, S3651, S3652, S3776, S3890, S3923,
S4109, S4158, S4165, S4632, S4663, S5871, S6194, S864]

## rust
[S1066, S1067, S1172, S125, S1763, S2757, S2761, S3358, S3776, S3923,
S3981, S4143, S4144, S4663, S5871, S6194]

## solidity
[S1066, S1067, S125, S2757, S3776, S3923, S3981, S4143, S4144, S5871,
S6194]

## vbnet
[S1068, S1104, S1105, S1106, S1126, S1131, S1142, S1143, S1144, S116,
S119, S124, S1247, S125, S127, S140, S1448, S1488, S1578, S1607,1669,
S1694, S1695, S1696, S1698, S1707, S1763, S1820, S1845, S1854, S1858,
S1872, S1905, S1941, S1968, S1987, S2096, S2108, S2139, S2145, S2149,
S2159, S2189, S2190, S2197, S2198, S2201, S2205, S2250, S2251, S2301,
S2334, S2583, S2588, S2589, S2596, S2597, S2691, S2760, S3041, S3047,
S3236, S3239, S3242, S3269, S3376, S3440, S3458, S3516, S3518, S3626,
S3688, S3872, S3902, S3906, S3908, S3925, S3993, S3994, S3995, S3996,
S3997, S4004, S4005, S4018, S4022, S4023, S4026, S4030, S4040, S4158,
S4165, S4220, S4456, S4457, S4462, S4470, S4632, S5871, S6061, S6194,
S864, S899]

## html
[S1075, S1143, S1291, S1707, S1952, S2166, S2197, S2201, S2205, S2251,
S2588, S2596, S2597, S4632, S4663, S5871]

## tsql
[S1075, S1125, S1226, S1741, S1854, S2234, S2524, S2544, S2583, S2589,
S2757, S3270, S3618, S3651, S3776, S3830, S3981, S4158, S4165, S4632,
S4663, S5245, S5871, S6194, S864]

## vb6
[S1075, S1110, S1144, S1172, S1192, S1226, S125, S126, S127, S1291,
S134, S1448, S1451, S1481, S1578, S1607, S1656, S1707, S1751, S1763,
S1764, S1854, S1858, S1862, S1871, S1909, S1940, S1941,1987, S2145,
S2149, S2189, S2190, S2197, S2198, S2205, S2234, S2251, S2252, S2259,
S2301, S2583, S2588, S2596, S2597, S2760, S2761, S3047, S3269, S3440,
S3458, S3516, S3626, S3776, S3923, S3981, S4143, S4144, S4158, S4165,
S4632, S4663, S5871, S6145, S6146, S6194, S899]

## swift
[S109, S1103, S1119, S1121, S1185, S1226, S1247, S127, S1270, S1291,
S1448, S1450, S1537, S1545, S1578, S1607, S1707, S1874, S1968, S2039,
S2114, S2123, S2177, S2234, S2253, S2301, S2373, S2440, S2490, S2583,
S2588, S2589, S2596, S2597, S2639, S2691, S2752, S2833, S2931, S3019,
S3031, S3041, S3044, S3047, S3065, S3075, S3076, S3239, S3241, S3242,
S3244, S3254, S3269, S3317, S3353, S3366, S3370, S3397, S3398, S3440,
S3458, S3466, S3516, S3518, S3688, S3872, S3931, S3949, S4025, S4030,
S4158, S4165, S4200, S4275, S4487, S4503, S4632, S4663, S5359, S5871,
S6194, S864, S867, S925]

## cfamily
[S1104, S1105, S1106, S1107, S1108, S1109, S1124, S1125, S1126, S114,
S115, S119, S1192, S1200, S1247, S1312, S1450, S1453, S1488, S1595,
S1607, S1782, S1845, S1888, S1899, S1941, S1952, S1968, S2039, S2096,
S2108, S2139, S2149, S2159, S2164, S2166, S2177, S2198, S2205, S2252,
S2326, S2327, S2440, S2490, S2588, S2596, S2597, S2639, S2691, S2752,
S2760, S2833, S2963, S3031, S3038, S3044, S3047, S3065, S3075, S3076,
S3235, S3239, S3241, S3242, S3269, S3317, S3353, S3370, S3397, S3398,
S3440, S3466, S3872, S3878, S3981, S3984, S3985, S4025, S4158, S4165,
S4275, S4503, S4632, S4663, S4970, S5871]

## xml
[S1128, S1291, S1707, S4632, S4663]

## kotlin
[S113, S2583, S3011, S3973, S4143, S5871, S6194]

## scala
[S113, S2583, S2757, S2761, S3011, S3358, S3981, S4143, S5871, S6194]

## go
[S1155, S125, S127, S2114, S2197, S2583, S3626, S4487, S4632, S5871,
S6194, S899]

## ruby
[S125, S2583, S3973, S3981, S4143, S5871, S6194]

## apex
[S2761, S3358, S3981, S4143, S5871, S6194]

## css
[S4632, S5871]
 2023-06-14 14:43:06 +02:00
Cristian Ambrosini
aaa468bf3a
Modify rule S1134: Update to LaYC (#2189) 
I removed abap, flex, pli and rpg dummy implementations since they're
not implemented in the corresponding analyzer and there are no tickets
open to do so.
 2023-06-14 14:23:44 +02:00
Costin Zaharia
afefc85dac
Modify rule S1144: LaYC format (#2183) 2023-06-14 14:04:05 +02:00
Arseniy Zaostrovnykh
5d36aa982f
Fix the preview page deployment: require write access for the action 2023-06-14 10:16:57 +00:00
Sebastien Marichal
2a6106862e
Modify rule S1944: Improve VB.NET example (#2182) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 11:13:10 +02:00
Fred Tingaud
a3f81b0b6c
Modify rule S3358: LaYC for Nested ternaries 
Co-authored-by: Amélie Renard <44666826+amelie-renard-sonarsource@users.noreply.github.com>
 2023-06-14 08:47:35 +00:00
Čaba Šagi
4b843bf87a
Modify rule S5034: Update to LaYC (#2152) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 10:23:06 +02:00
Johann Beleites
a664bedde9
Deprecate rule S1610 [SONARJAVA-4485] (#2161) 2023-06-14 10:05:19 +02:00
SonarTech
520a6dc896 update coverage information 2023-06-14 00:34:20 +00:00
Fred Tingaud
a08c3bbd23
Modify Rule S3011: LaYC reflection 
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
 2023-06-13 19:24:21 +02:00
Fred Tingaud
35036fffff
Add check that each section is used only once 
There was already a check for section duplication, but only in "How to
fix it". This changes the test to cover all sections.
And fixing the rules that this new validation fails on.

Also making test_modify_rule.py run on Windows.

---------

Co-authored-by: Christophe Zürn <36889251+christophe-zurn-sonarsource@users.noreply.github.com>
 2023-06-13 18:03:28 +02:00
Arseniy Zaostrovnykh
a3b1a2445d
Improve PR-scan rate limiting behavior when listing all new rules under specification 
Propagate the GITHUB_TOKEN to the `predeploy` action to enable
authorized read access to the list of open PRs.
Also specify explicitly that the action requires read access to PRs
 2023-06-13 17:13:23 +02:00
Čaba Šagi
e2d06c1e1c
Modify rule S3217: Adapt to LaYC (#2175) 2023-06-13 17:09:18 +02:00
Amélie Renard
04d2e44657
Modify rule S110: LaYC format 2023-06-13 16:32:31 +02:00
Amélie Renard
6ebac03a85
Modify rule S100: fix LaYC for Java and JS/TS (#2165) 2023-06-13 16:27:23 +02:00
Sebastien Marichal
f3e1b88f9d
Modify rule S2234: LaYC format (#2172) 2023-06-13 16:14:37 +02:00
Gregory Paidis
cbbe7126e5
Modify rule S2225: LaYC format (#2173) 2023-06-13 16:11:53 +02:00
Sebastien Marichal
e8c9d1d972
Modify rule S4635: Improve code example (#2143) 2023-06-13 16:01:46 +02:00
cynthiabethea
24f34c42dd
Modify rule S6426: LaYC format (#2121) 2023-06-13 16:01:15 +02:00
Victor
24763c9ddc
Modify rule S1472: Adapt to LaYC (#2153) 2023-06-13 13:06:23 +00:00
Antonio Aversa
63c46d9b4b
Modify rule S3464: fix grammar, links, resources, rspecator (#2164) 2023-06-13 14:08:13 +02:00
Gregory Paidis
e1d18a26b3
S4015: Migrate to LAYC level 2 (#2134) 2023-06-13 12:23:03 +02:00
Sebastien Marichal
950617a825
Modify rule S3265: LaYC format (#2150) 2023-06-13 11:36:14 +02:00
Dorian Burihabwa
089fad36d5
Deprecate rule S1114 (#2162) 2023-06-13 11:31:26 +02:00
Antonio Aversa
f1a5a79e73
Modify rule S2692: fix non-compliant code example (#2158) 2023-06-13 11:14:41 +02:00
Antonio Aversa
630df42477
Modify rule S3451: fix non-compliant block (#2157) 2023-06-13 11:11:31 +02:00
Antonio Aversa
0cf7742d2e
Modify rule S2437: fix VB.NET links and rspecator (#2159) 2023-06-13 11:05:22 +02:00
Sebastien Marichal
800c2f647c
Modify rule S1944: LaYC format (#2131) 2023-06-13 10:52:19 +02:00
Cristian Ambrosini
5e048dd441
Modify rule S4019: LaYC format (#2141) 2023-06-13 09:45:25 +02:00
Victor
63488517d8
Modify rule S4275: Adapt to LaYC (#2105) 2023-06-13 09:16:19 +02:00
Antonio Aversa
112b5c8134
Modify rule S1215: LaYC format (#2128) 2023-06-13 08:18:53 +02:00
SonarTech
55d325debb update coverage information 2023-06-13 00:32:55 +00:00
Marco Kaufmann
c5f4f33c6d
Modify rule S2975: Reworked into new educational format (#2107) 2023-06-12 18:36:39 +02:00
Marco Kaufmann
8973e2be96
Modify rule S2165: Reworked into new educational format (#2149) 2023-06-12 18:10:51 +02:00
Marco Kaufmann
4ac3e2c027
Modify rule S2160: Reworked into new educational format (#2126) 2023-06-12 18:10:24 +02:00
Marco Kaufmann
d6ffc40042
Modify rule S2157: Reworked into new educational format (#2101) 2023-06-12 18:09:33 +02:00
hendrik-buchwald-sonarsource
d3b00511bb
Modify rule S5547: LaYC format (#2023) 2023-06-12 15:58:19 +02:00
Čaba Šagi
91d028fdb6
Modify rule S3871: Update to LaYC (#2138) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
 2023-06-12 15:18:25 +02:00
Fred Tingaud
28657dcc74
Modify rule S4143: Adapt to LaYC (#1931) 2023-06-12 14:18:01 +02:00
Sebastien Marichal
9e3cc3533a
Modify rule S3973: Remove unsupported languages (#2118) 2023-06-12 12:30:49 +02:00
Arseniy Zaostrovnykh
d4f555ef9c
Add a checkbox for the PR title guidelines 2023-06-12 11:57:47 +02:00
leonardo-pilastri-sonarsource
06cf53d7a8
SONARJAVA-4492 Add missing space after backtick for S2441 (#2147) 2023-06-12 11:17:30 +02:00
Alban Auzeill
283866408b
Modify rule S2055(Java): Update rule according to the LayC (#2084) 2023-06-12 10:40:53 +02:00
Sebastien Marichal
31a1f3c8f8
Modify rule S2222: Update code examples diff type (#2142) 2023-06-12 10:24:02 +02:00