* Create rule S6392
* Add first draft
* improve title
* add last commit to this PR regarding public network access
* add metadata tags
* changed title
* converted ask yourself into generic cloud
* converted description into generic cloud
* moved aws links to see
* converted recommended to generic cloud
* convertion of recommended -- added a special case
* add cwe
* add note in recommended section, not sure about this one
* add another cwe
* add first version of rule conversion
* final rule version
* removed leftover code
* Update rules/S6329/description.adoc
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
* Update rules/S6329/terraform/rule.adoc
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
* changed case for bulleted list
* improved specs after review
* removed potential confusion
* changed company<->organization
* Update rules/S6329/ask-yourself.adoc
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
* Update rules/S6329/description.adoc
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
* Make generic
* Add GCP code sample
* Update rules/S6329/terraform/rule.adoc
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
* Fix syntax
Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
* Create rule S6404
* initial draft
* new ideas
* last little fixes before draft v1
* draftv1
* final version
* improved the text
* last commit
* very last
* Add code highlighted tag to code example
Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
* Create rule S6400
* first draft
* second draft
* relecture
* last relecture du matin
* another idea, last paragraph may be overkill
* add small precision for new resources
* Add code highlighted tag to code example
Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
* add GCP balancers
* rephrase sentence
* fix after review
* Add code highlighted tag to code example
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
* Create rule S6407
* add rspecs6407 terraform
* fix typo in see section
* fixes after review
* Add code highlighted tag to code example
Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
* Create rule S6405
* init s6405
* fixes after review
* Add code highlighted tag to code example
Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
* Create rule S6402
* init s6402
* fix
* fixes after review
* fixes after new review
* Add code highlighted tag to code example
Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
* Create rule S6401
* init s6401
* fix small typo
* fixes after review
* Add code highlighted tag to code example
Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
* Modify rule S4423[terraform]:Add SSL policy for Google Cloud load balancers
* Add custom message and update code examples
* Add code highlighted tag to code example
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
The main changes are:
* Split RuleCreator: move some of its content to RspecRepo and to
RuleEditor in new modules.
* Refactor tests accordingly.
Other less important changes:
* Sort and remove unnecessary imports
* Remove unimplemented functions and unnecessary classes
* Make some functions private
* Move pushd from utils to tests where it is only used
* Reduce code duplication here and there
* Remove unnecessary Mock in some tests
* Improve coverage for add_language_to_rule