1051 Commits

Author SHA1 Message Date
hendrik-buchwald-sonarsource
4e659743db
Modify Rule S6329: Make generic and add GCP (#733)
* Create rule S6392

* Add first draft

* improve title

* add last commit to this PR regarding public network access

* add metadata tags

* changed title

* converted ask yourself into generic cloud

* converted description into generic cloud

* moved aws links to see

* converted recommended to generic cloud

* convertion of recommended -- added a special case

* add cwe

* add note in recommended section, not sure about this one

* add another cwe

* add first version of rule conversion

* final rule version

* removed leftover code

* Update rules/S6329/description.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* Update rules/S6329/terraform/rule.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* changed case for bulleted list

* improved specs after review

* removed potential confusion

* changed company<->organization

* Update rules/S6329/ask-yourself.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* Update rules/S6329/description.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* Make generic

* Add GCP code sample

* Update rules/S6329/terraform/rule.adoc

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

* Fix syntax

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
2022-03-03 09:41:02 +01:00
github-actions[bot]
0357b3b2df
Create rule S6409: Enabling Attribute-Based Access Control for Kubernetes is security-sensitive (#737)
* Create rule S6409

* Add description

* Update rules/S6409/terraform/rule.adoc

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

Co-authored-by: hendrik-buchwald-sonarsource <hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Hendrik Buchwald <hendrik.buchwald@sonarsource.com>
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-03-02 20:54:36 +00:00
github-actions[bot]
5e09bc9f04
Create rule S6404[terraform]: Granting public access to GCP resources is security-sensitive (#713)
* Create rule S6404

* initial draft

* new ideas

* last little fixes before draft v1

* draftv1

* final version

* improved the text

* last commit

* very last

* Add code highlighted tag to code example

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 20:31:57 +00:00
github-actions[bot]
0aeb50c127
Create rule S6400[Terraform]: Granting highly privileged GCP resource rights is security-sensitive (#685)
* Create rule S6400

* first draft

* second draft

* relecture

* last relecture du matin

* another idea, last paragraph may be overkill

* add small precision for new resources

* Add code highlighted tag to code example

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 20:25:17 +00:00
eric-therond-sonarsource
3069550d46
Modify rule S5332[terraform]: add GCP load balancers (#760)
* add GCP balancers

* rephrase sentence

* fix after review

* Add code highlighted tag to code example

Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:19:10 +00:00
github-actions[bot]
b486a5246d
Create rule S6407[terraform]: Creating App Engine handlers without requiring TLS is security-sensitive (#725)
* Create rule S6407

* add rspecs6407 terraform

* fix typo in see section

* fixes after review

* Add code highlighted tag to code example

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:02:00 +00:00
github-actions[bot]
d01eb2f856
Create rule S6405[terraform] Enabling project-wide SSH keys to access VM instances is security-sensitive (#720)
* Create rule S6405

* init s6405

* fixes after review

* Add code highlighted tag to code example

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 13:55:09 +00:00
github-actions[bot]
bf856aefb2
Create rule S6402[terraform] Creating DNS zones without DNSSEC enabled is security-sensitive (#691)
* Create rule S6402

* init s6402

* fix

* fixes after review

* fixes after new review

* Add code highlighted tag to code example

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:47:12 +01:00
github-actions[bot]
1e02f0224c
Create rule S6401[terraform] Creating keys without a rotation period is security-sensitive (#687)
* Create rule S6401

* init s6401

* fix small typo

* fixes after review

* Add code highlighted tag to code example

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:33:39 +01:00
github-actions[bot]
aa6068e86e
Create rule S6410: Google Cloud load balancers SSL policies should not offer weak cipher suites (#741)
* Create rule S6410

* Add custom message

* Apply suggestions from code review

Co-authored-by: eric-therond-sonarsource <56015232+eric-therond-sonarsource@users.noreply.github.com>

* Update highlighting file extension

* Add code highlighted tag to code example

Co-authored-by: pierre-loup-tristant-sonarsource <pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Pierre-Loup Tristant <pierre-loup.tristant@sonarsource.com>
Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <56015232+eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 13:20:34 +00:00
github-actions[bot]
0417b41432
Modify rule S5495: mark quick fix as "covered" 2022-03-02 13:11:27 +00:00
Pierre-Loup
378f48c68d
Modify rule S4423[terraform]:Add SSL policy for Google Cloud load balancers (#761)
* Modify rule S4423[terraform]:Add SSL policy for Google Cloud load balancers

* Add custom message and update code examples

* Add code highlighted tag to code example

Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:04:14 +01:00
tomasz-kaminski-sonarsource
0a963a89fa
Modify rules S3608,S5019: Provide quickfix information
Co-authored-by: Tomasz Kamiński <tomasz.kamiński@sonarsource.com>
2022-03-02 11:49:55 +01:00
github-actions[bot]
75e88b6dda
Modify rule S5954: mark quick fix as "partial" and update rule title 2022-03-01 14:12:42 +00:00
Čaba Šagi
6117e282f6
Modify rule S4035: Cleanup Noncompliant example (#850) 2022-02-28 15:20:24 +01:00
tomasz-kaminski-sonarsource
917b6e916e
Modify rule S6011: Provide quickfix information 2022-02-28 15:06:16 +01:00
Marco Antognini
26e3ebc7ec Refactor rspec-tools and other cleanups
The main changes are:
 * Split RuleCreator: move some of its content to RspecRepo and to
   RuleEditor in new modules.
 * Refactor tests accordingly.

Other less important changes:
 * Sort and remove unnecessary imports
 * Remove unimplemented functions and unnecessary classes
 * Make some functions private
 * Move pushd from utils to tests where it is only used
 * Reduce code duplication here and there
 * Remove unnecessary Mock in some tests
 * Improve coverage for add_language_to_rule
2022-02-28 12:08:21 +01:00
Marco Antognini
dbb8027666 RULEAPI-748: Add new workflow to update quickfix status 2022-02-28 12:08:21 +01:00
SonarTech
60b973cf44 update coverage information 2022-02-26 00:32:15 +00:00
github-actions[bot]
4a750be849
Create rule S6354: Testable date/time provider should be used (#285) 2022-02-25 14:45:53 +01:00
Loris S
424a792370
Modify multiple rules: fixing missing double quotes and other typos (#846) 2022-02-23 13:50:31 +00:00
SonarTech
37a4c3f7a7 update coverage information 2022-02-23 12:05:38 +00:00
eric-therond-sonarsource
aa8b82989c
update sensitive code samples s6249 (#845) 2022-02-22 18:09:50 +01:00
Evgeny Mandrikov
34aad572a9
BUILD-1287 Add .github/CODEOWNERS 2022-02-22 17:21:19 +01:00
Fred Tingaud
1c7fadf592 Modify rule S6023: Add an example with std::move 2022-02-22 15:05:52 +01:00
Fred Tingaud
27f3bb0963 Modify rule S6023: Mark quickfix as covered 2022-02-22 15:05:52 +01:00
github-actions[bot]
4b9ca66416
Create rule S6403[terraform] Creating GCP SQL instances without requiring TLS is security-sensitive (#712)
* Create rule S6403

* init s6403

* fixes after review

* Add message for omitted attributes. (#844)

* Add message for omitted attributes.

* Update rules/S6403/message.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* Add new source tags for code examples

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-02-22 11:01:40 +00:00
SonarTech
14d0ef7a8c update coverage information 2022-02-22 00:31:52 +00:00
github-actions[bot]
2c94f81cc5
Create rule S6406[terraform]: Excessive Granting Of GCP IAM Permissions Is Security-Sensitive (#724)
* Create rule S6406

* first draft

* draft part2

* user-friendly draft v3

* light fix

* add link

* fix snippets columns

* final draft

* add metadata - 15min time because it's long

* Light -> Lightweight

* modern->sophisticated

* fix punctuation

* suggestion for snippets

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>

* Update rules/S6406/terraform/rule.adoc

Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>

* Update rules/S6406/terraform/rule.adoc

Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

* Update rules/S6406/terraform/rule.adoc

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-02-18 16:26:42 +00:00
Pavel Mikula
0852b8714e
Modify rule S107: Fix C# example (#839) 2022-02-18 15:53:40 +01:00
Pavel Mikula
18c48813f6
Modify rule S107: Improve C# and VB.NET examples (#835) 2022-02-18 15:03:19 +01:00
Yassin Kammoun
335c2577c8
Modify rule S4328: Clarify what kind of problems could arise (#832)
Co-authored-by: Elena Vilchik <elena.vilchik@sonarsource.com>
2022-02-18 13:26:45 +00:00
Pavel Mikula
424c6dabdb
Modify rule S107: Synchronize exception for VB.NET with C# (#833) 2022-02-18 14:15:34 +01:00
Yassin Kammoun
a4e2e09d94
Modify rule S3317: Consider dot notation in filenames (#830) 2022-02-18 08:47:39 +00:00
Elena Vilchik
f9b555a4fa
Fix code example for JavaScript/S5843 (#659) 2022-02-18 08:35:04 +00:00
Yassin Kammoun
1951cd3baa
Modify rule S3735: Ignore JavaScript promises (#722) 2022-02-18 08:28:27 +00:00
Tibor Blenessy
2e49d6f58d
Update metadata for JS quickfixes (#809) 2022-02-18 08:20:48 +00:00
Yassin Kammoun
e864c4a697
Modify rule S1172: Match the behaviour of TypeScript compiler for JS/TS (#827)
Co-authored-by: vilchik.elena <elena.vilchik@sonarsource.com>
2022-02-18 08:15:47 +00:00
SonarTech
911d9e5f42 update coverage information 2022-02-18 00:32:28 +00:00
Dorian Burihabwa
769637860e
Modify rule S4601: Improve phrasing (#829) 2022-02-17 14:34:11 +01:00
Arseniy Zaostrovnykh
2ae2a1cf69
Modify Rule S1314: add quickfix and mention character literals CPP-3223
Implementation PR: https://github.com/SonarSource/sonar-cpp/pull/1785
2022-02-17 12:09:22 +00:00
Marco Antognini
5e4eb65257
Modify rule S6004: Mark quickfix as partial 2022-02-17 10:34:33 +00:00
SonarTech
cfd0d063b1 update coverage information 2022-02-17 00:32:00 +00:00
Arseniy Zaostrovnykh
9ceab1d675
Update rule S6020: implement a quick fix
Implementation PR https://github.com/SonarSource/sonar-cpp/pull/1788
2022-02-16 16:35:50 +01:00
Yassin Kammoun
24f9a0adbe
Modify rule S1763: Remove unsupported exceptions (#822) 2022-02-16 09:37:07 +00:00
Yassin Kammoun
5b5ba6b297
Modify rule S4204: Improve rule description (#826) 2022-02-16 10:31:39 +01:00
SonarTech
b55cbdf38b update coverage information 2022-02-16 00:31:35 +00:00
eric-therond-sonarsource
6fbd1856ba
Modify rule S2755[java]: Allow setExpandEntityReferences solution for openJDK >=13 (#299) 2022-02-15 16:51:53 +00:00
hendrik-buchwald-sonarsource
2a1211dc20
Modify rule S6173: Update default severity (#667) 2022-02-15 17:40:35 +01:00
eric-therond-sonarsource
fdd602f70d
update android rule tags metadata (#824) 2022-02-15 15:33:03 +01:00