3303 Commits

Author SHA1 Message Date
Marco Borgeaud
915ef808a2
RULEAPI-788 Turn diff-view validation on (#2883) 2023-09-14 12:03:01 +02:00
Loris S
84d9a3c065
Modify S6338: Improve samples (#3072)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-14 11:50:10 +02:00
daniel-teuchert-sonarsource
c8a953286f
APPSEC-1083: S6382 Fixed incorrect ARM examples (#3056)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2023-09-14 11:41:28 +02:00
github-actions[bot]
e61222637f
Create rule S6766: JSX special characters should be escaped (#3057)
https://github.com/SonarSource/SonarJS/issues/4139
2023-09-14 11:15:57 +02:00
Rudy Regazzoni
30036c6eb4
Modify rule S6388: Remove diff-id on compliant example without non-compliant equivalent (#3070)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

[Related
issue](https://github.com/SonarSource/rspec/pull/1925#pullrequestreview-1624869461)
2023-09-14 09:56:56 +02:00
github-actions[bot]
e4e7d4738e
Create rule S6767: Unused React typed props should be removed (#3059) 2023-09-14 09:39:26 +02:00
SonarTech
70f705394d update coverage information 2023-09-14 00:33:59 +00:00
Egon Okerman
a9c9fb99ff
Modify rule S4423, S6378, S6387, S6656: Fix diff view errors in ARM examples (#3067)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-13 17:48:09 +02:00
Marco Borgeaud
3075880d75
Modify rule S127: fix diff-id and diff-type (#3035) 2023-09-13 16:44:16 +02:00
Marco Borgeaud
11a2f3acbd
Modify rule S2251: fix diff-id (#3036) 2023-09-13 16:39:32 +02:00
github-actions[bot]
a630b5dd26
Create rule S6759: React props should be read-only (#3043) 2023-09-13 15:58:40 +02:00
daniel-teuchert-sonarsource
9a888ec176
APPSEC-1082 Validate S6381 ARM (#3022)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-13 15:50:36 +02:00
daniel-teuchert-sonarsource
c02882ec9f
APPSEC-1082: S6381 Adjust code examples so that they can be scanned by Sonarqube (#3050)
This PR adjusts the JSON code examples and adds a name field that is
needed for the files to be recognized by sonar-iac-plugin.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-13 15:49:57 +02:00
daniel-teuchert-sonarsource
b22dae5811
APPSEC-1080: S6364 Adjust the retention period of the compliant examples (#3049)
This PR adjusts the retention period from the compliant examples so that
they do not raise security hotspots when scanned with the Sonarway
profile.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-13 15:49:15 +02:00
daniel-teuchert-sonarsource
9f5a87c298
Arm/make examples schema compliant (#3047)
This PR changes the JSON examples for ARM rules to make sure that the
code samples will be scanned by sonar-iac-plugin.
To ensure this all resources need a name field and the schema URL has to
be an https and not http URL.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-13 15:48:50 +02:00
daniel-teuchert-sonarsource
2b6572864d
APPSEC-1077: S6329 Improve examples fso that they can be scanned with sonar-iac (#3048)
This PR fixes the code examples for ARM for rule S6329 so that they can
be scanned with Sonarqube.
The schema URL for the JSON examples has to be https and for the bicep
examples, the correct quotes need to be used.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-13 15:48:25 +02:00
Rudy Regazzoni
d2c8e2fdad
Modify rule S6388: Add language AzureResourceManager (Bicep) (#1925)
Specification ticket:
https://sonarsource.atlassian.net/browse/SONARIAC-759
2023-09-13 15:29:57 +02:00
github-actions[bot]
bc5795a24c
Create rule S6761: children and dangerouslySetInnerHTML should not be used together (#3045)
https://github.com/SonarSource/SonarJS/issues/4136
2023-09-13 11:36:36 +02:00
Angelo
c4bf7e1391
Fix typo in S1774 rule.adoc and remove broken link in S6411 rule.adoc (#3053) 2023-09-13 10:28:37 +02:00
Egon Okerman
905365e865
Modify rule S6380: Add language AzureResourceManager (Bicep) (#2298) 2023-09-13 10:27:43 +02:00
Egon Okerman
17040a154f
Modify rule S6656: add language AzureResourceManager (Bicep) (#2356) 2023-09-13 10:27:13 +02:00
Egon Okerman
bc2c537f49
Modify rule S6378: Add language AzureResourceManager (Bicep) (#2255) 2023-09-13 10:26:31 +02:00
Egon Okerman
ebc3f49dd0
Modify rule S6364: Add language AzureResourceManager (Bicep) (#1913) 2023-09-13 10:25:38 +02:00
Egon Okerman
4c61cfe3b9
Modify rule S6387: Add language AzureResourceManager (Bicep) (#1907) 2023-09-13 10:25:18 +02:00
Egon Okerman
897bb45fbf
Modify rule S4423: Add language AzureResourceManager (Bicep) (#1879) 2023-09-13 10:25:04 +02:00
github-actions[bot]
9b3de2dd1f
Create rule S6763: "shouldComponentUpdate" should not be defined when extending "React.PureComponent" (#3051) 2023-09-13 09:28:25 +02:00
SonarTech
84d49d5c29 update coverage information 2023-09-13 00:32:47 +00:00
github-actions[bot]
320b22a2fb
Create rule S6757: this should not be used in functional components (#3040)
https://github.com/SonarSource/SonarJS/issues/4133
2023-09-12 16:36:10 +02:00
Marco Borgeaud
b7ad927009
Modify rule S6600: remove extra diff-view (#3039) 2023-09-12 15:21:04 +02:00
Marco Borgeaud
367e056eaf
Modify rule S2004: remove extra diff-view (#3038) 2023-09-12 15:20:48 +02:00
Marco Borgeaud
65e74c0a9e
Modify rule S1599: remove extra diff-view (#3037) 2023-09-12 15:20:32 +02:00
Marco Borgeaud
7f98f4246c
RULEAPI-788 Allow multiple compliant solutions (#3034)
See https://discuss.sonarsource.com/t/layc-diff-view-validation/15392/7
2023-09-12 13:16:52 +02:00
Marco Borgeaud
aecbd213d7
Modify rule S1048: remove extra space in code snippet 2023-09-12 11:08:49 +02:00
github-actions[bot]
6e57fd6621
Create rule S6754: The return value of "useState" should be destructured and named symmetrically (#3027) 2023-09-12 09:53:37 +02:00
github-actions[bot]
bad897989e
Create rule S6748: React children should not be passed as prop (#3014)
https://github.com/SonarSource/SonarJS/issues/4129
2023-09-12 09:48:05 +02:00
github-actions[bot]
f441c79d18
Create rule S6756: \"setState\" should use a callback when referencing the previous state (#3031) 2023-09-12 09:38:39 +02:00
SonarTech
99d7952a2b update coverage information 2023-09-12 00:32:32 +00:00
github-actions[bot]
eafd5fac25
Create rule S6750: The return value of \"ReactDOM.render\" should not be used (#3017) 2023-09-11 11:52:43 +02:00
daniel-teuchert-sonarsource
36f172fa8a
APPSEC-1053 Validate S6648 ARM default value for secret (#3019)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-11 10:02:45 +02:00
daniel-teuchert-sonarsource
8e2f0268bd
APPSEC-1049 Validate S6382 for ARM (#3024)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-11 09:07:59 +02:00
SonarTech
823100a75b update coverage information 2023-09-09 00:33:07 +00:00
Marcin Stachniuk
babdfd5c94
Modify rule S6597: "WORKDIR" instruction should be used instead of "cd" commands (#3028)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Jonas Wielage <127737854+jonas-wielage-sonarsource@users.noreply.github.com>
2023-09-08 21:40:09 +02:00
Mary Georgiou
fa3a50811e
Pull requests list Modify S4818: Delete (#3001)
Deleting S4818 as it has been deprecated.
Deprecated since:

sonar-dotnet 8.9.0.19135, released on Jun 26, 2020
SQ 8.4.0.35506 on Jul 3, 2020.
2023-09-08 13:45:00 +02:00
daniel-teuchert-sonarsource
a91542370a
APPSEC-1056 Modify S6336(secrets): Make text compliant (#3013)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2023-09-08 10:00:48 +02:00
daniel-teuchert-sonarsource
fcda64cd35
APPSEC-1050 Modify S6378(ARM): Fix typo and adjust code examples (#3010)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-07 17:36:14 +02:00
daniel-teuchert-sonarsource
66d3ddb728
APPSEC-1015 Validate S6379(secrets): ARM (#3018)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-07 17:35:51 +02:00
Loris S
f2bf838cde
Modify S6388(ARM): Fix diffs (#3025)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-07 17:30:00 +02:00
Loris S
23fc89f4e5
APPSEC-1061 Modify S6292(secrets): Make text compliant (#3008)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-07 16:57:08 +02:00
SonarTech
1eb17f2185 update coverage information 2023-09-07 00:32:48 +00:00
github-actions[bot]
cb28ce6141
Create rule S6749: Redundant React fragments should be removed (#3016) 2023-09-06 15:58:00 +02:00