89 Commits

Author SHA1 Message Date
Loris S
936d78a18d
Modify S5547(PL/SQL): Migrate to LayC - code re-creation (#3358)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-10-26 08:35:54 +00:00
Marco Borgeaud
34814f787b
Remove links to SANS Top 25 CWEs (#3322)
These links are no longer relevant since SANS now just link to CWE, and we already have links to CWEs.
2023-10-18 13:16:00 +00:00
Marco Borgeaud
41ee3f5305
Normalize Wikipedia and Microsoft links in CFamily (#3321)
Update docs.microsoft.com to learn.microsoft.com.
2023-10-18 12:28:32 +00:00
Marco Borgeaud
ec58c48c37
Normalize links to C++ reference (#3298) 2023-10-17 14:17:15 +02:00
Loris S
3b1f9991d5
Modify docs: Add showcase rules (#3300)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: nicolas-gauthier-sonarsource <121794895+nicolas-gauthier-sonarsource@users.noreply.github.com>
2023-10-17 07:59:24 +00:00
github-actions[bot]
5ed9a4f18a
Create rule S6807: DOM elements with ARIA roles should have the required properties (#3224)
https://github.com/SonarSource/SonarJS/issues/4243
2023-10-11 08:47:14 +02:00
John-Clifton-SonarSource
7015855f79
Add additional LayC guidance in docs (#3193)
Adding in additional material and a bit of refactoring for clarity.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2023-10-04 11:19:33 +01:00
github-actions[bot]
e4e7d4738e
Create rule S6767: Unused React typed props should be removed (#3059) 2023-09-14 09:39:26 +02:00
github-actions[bot]
a630b5dd26
Create rule S6759: React props should be read-only (#3043) 2023-09-13 15:58:40 +02:00
Egon Okerman
17040a154f
Modify rule S6656: add language AzureResourceManager (Bicep) (#2356) 2023-09-13 10:27:13 +02:00
Egon Okerman
0aa80c7af2
Modify rule S2647: Update to LaYC format (APPSEC-970) (#2917)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-09-05 13:46:16 +00:00
Egon Okerman
b0968585b4
Modify rule S6432: update to LaYC format (APPSEC-974) (#2972)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-31 15:05:45 +02:00
Egon Okerman
d408fe4dd9
Modify rule S6301: update to LaYC format (APPSEC-973) (#2984)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-30 13:55:19 +02:00
Egon Okerman
efcf2bdd1a
Modify rule S6317: Update to LayC format (APPSEC-968) (#2949)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-30 11:56:31 +02:00
sebastien-andrivet-sonarsource
2d4813b028
Modify rule S5876: Update to LayC format (APPSEC-969) (#2967)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
2023-08-30 09:09:58 +02:00
sebastien-andrivet-sonarsource
89de4d7476
Modify rule S2115: Update to LaYC format (APPSEC-799) (#2927)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-25 14:34:42 +02:00
Loris S
a0abb99f76
Modify S2596(javascript): Convert to LayC (#2901)
This PR also removes the java folder because it is not implemented and
has no implementation plan. This PR was made spontaneously during
Daniel's onboarding.

---------

Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
2023-08-18 09:31:06 +00:00
github-actions[bot]
10cb45778a
Create rule S4423: add Go (APPSEC-905) (#2830)
Research ticket:
[APPSEC-905](https://sonarsource.atlassian.net/browse/APPSEC-905)

You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S4423/go) (updated a
few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)



[APPSEC-905]:
https://sonarsource.atlassian.net/browse/APPSEC-905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: egon-okerman-sonarsource <egon-okerman-sonarsource@users.noreply.github.com>
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
2023-08-16 13:53:27 +02:00
Michael Jabbour
32232051fd
Add clean code taxonomy properties to metadata schema (#2792) 2023-08-04 16:55:03 +02:00
Pierre-Loup
2336aba6a7
Modify rule S6648: Add language AzureResourceManager (Bicep) (#2277)
[Specification
ticket](https://sonarsource.atlassian.net/browse/APPSEC-803)
[Implementation
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-896)

Main PR for ARM templates:
https://github.com/SonarSource/rspec/pull/2250

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: pierre-loup-tristant-sonarsource <pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
2023-08-02 15:17:24 +02:00
Loris S
bef49d6a16
Modify S4423(Azure): Add MSSQL sample (#2532)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-07-20 16:09:48 +02:00
Fred Tingaud
dc89dd499c
Create a shared_content folder at root 2023-07-20 12:17:32 +02:00
Amélie Renard
b724d1f7c4
RULEAPI-791 LaYC: add "External coding guidelines" subtitle in the "Resources" section (#2454) 2023-07-13 18:18:01 +02:00
Marco Borgeaud
3caf52608d
Cross reference guides and cosmetics improvements (#2432)
Indent sections in the rule description guide to improve readability.
Cross-reference the link standard in the rule description guide.

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-07-11 08:18:38 +01:00
Arseniy Zaostrovnykh
543d93befd
Fix the rule-id link format (#2408)
Rule IDs are [automatically
transformed](https://github.com/SonarSource/sonar-rule-api/blob/master/src/main/java/com/sonarsource/ruleapi/asciidoctor/AsciiDoctorConverter.java#L111)
into link placeholders by rule-api. These placeholders are translated
into autolinks by the products.
If these IDs appear within other links, it might [break some
products](https://discuss.sonarsource.com/t/cross-rule-references-inside-a-tags-in-html-rule-descriptions/14971/4).

Moreover, the generated autolinks are product-specific, and cannot be
encoded statically in the rule description.
2023-07-05 14:30:33 +00:00
github-actions[bot]
ea1d71f510
Create rule S6656: add language AzureResourceManager (JSON) (#2322)
Specification ticket:
[APPSEC-805](https://sonarsource.atlassian.net/browse/APPSEC-805)
Implementation ticket:
[SONARIAC-930](https://sonarsource.atlassian.net/browse/SONARIAC-930)
[RSPEC
Preview](https://sonarsource.github.io/rspec/#/rspec/S6656/azureresourcemanager)

Bicep PR for S6656: #2356

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)



[APPSEC-805]:
https://sonarsource.atlassian.net/browse/APPSEC-805?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[SONARIAC-930]:
https://sonarsource.atlassian.net/browse/SONARIAC-930?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: egon-okerman-sonarsource <egon-okerman-sonarsource@users.noreply.github.com>
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
2023-07-04 18:10:44 +02:00
github-actions[bot]
b11bd37556
Create rule S6648: Secure strings and objects should not have default values (APPSEC-803) (#2250)
[Specification
ticket](https://sonarsource.atlassian.net/browse/APPSEC-803)
[Implementation
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-896)
[RSPEC
Preview](https://sonarsource.github.io/rspec/#/rspec/S6648/azureresourcemanager)

Bicep PR: https://github.com/SonarSource/rspec/pull/2277

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: pierre-loup-tristant-sonarsource <pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Pierre-Loup Tristant <pierre-loup.tristant@sonarsource.com>
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
2023-07-03 17:54:12 +02:00
John-Clifton-SonarSource
0aa6cea0ff
Update link_formatting.adoc (#2362)
Added in CWE as pre-defined link.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-07-03 16:05:22 +01:00
Amélie Renard
ee50358ea1
Update LaYC "More info" section with "Related rules" subtitle 2023-07-03 15:10:21 +02:00
John-Clifton-SonarSource
13b37adc81
Update link_formatting.adoc (#2341)
Fixed rule link example so that rule number was also part of the
underlined link.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-07-03 10:38:22 +01:00
John-Clifton-SonarSource
55e9cb9961
Create link formatting.adoc (#2324)
Added in formatting guidance for links that appear in rules.

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Martin Strecker <103252490+martin-strecker-sonarsource@users.noreply.github.com>
2023-06-29 14:04:43 +01:00
Loris S
c622e8e4d3
Modify S5527: Learn-As-You-Code migration (#2269)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-28 17:11:41 +02:00
hendrik-buchwald-sonarsource
40e915bf59
Modify rule S5659: LaYC format (#2272) 2023-06-28 16:26:16 +02:00
hendrik-buchwald-sonarsource
a8961d6437
Modify rule S2755: LaYC format (#2245) 2023-06-22 11:25:00 +02:00
Fred Tingaud
51369b610e
Make sure that includes are always surrounded by empty lines (#2270)
When an include is not surrounded by empty lines, its content is inlined
on the same line as the adjacent content. That can lead to broken tags
and other display issues.
This PR fixes all such includes and introduces a validation step that
forbids introducing the same problem again.
2023-06-22 10:38:01 +02:00
Loris S
1a84c758e1
Modify S4423: Learn-As-You-Code Migration (#2097)
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 15:36:01 +00:00
hendrik-buchwald-sonarsource
d825cbc5b9
Modify rule S4830: LaYC format (#2176) 2023-06-20 13:26:14 +02:00
Loris S
9e9c990658
Modify S5542: Learn-As-You-Code migration (#2011)
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 10:27:53 +02:00
hendrik-buchwald-sonarsource
d3b00511bb
Modify rule S5547: LaYC format (#2023) 2023-06-12 15:58:19 +02:00
John-Clifton-SonarSource
603acc3d7b
Create tone_guide.adoc (#2088)
Created a tone guide to help rules authors make their content as
compelling for their users as possible.

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
2023-06-07 12:32:04 +01:00
Sebastien Marichal
a549ff28d4 Modify rule S2187: LaYC format (#2042) 2023-06-07 12:01:33 +02:00
Cristian Ambrosini
d18a0f74ab Modify rule S2699: Migrate to new educational format (#1956) 2023-06-07 12:01:33 +02:00
Cristian Ambrosini
82e7c93900 Modify rule S2970: LaYC format (#1985) 2023-06-07 12:01:33 +02:00
Christophe Zürn
fb4ba0d61d
Update README and validation to reflect new guidelines (#1951)
Co-authored-by: Elena Vilchik <elena.vilchik@sonarsource.com>
2023-05-30 11:00:48 +02:00
Jonas Wielage
98a4f7ad7e
Modify rule S6349: Update for educational format (#1845) 2023-05-11 10:26:42 +02:00
Christophe Zurn
62f01f07fe Update documentation, disallow standard rule format, add allowed sections in 'Why is it an issue?' 2023-05-05 16:29:04 +02:00
Christophe Zürn
0195cdabdd Update docs/description.adoc
Co-authored-by: Victor <106590915+victor-diez-sonarsource@users.noreply.github.com>
2023-05-05 16:29:04 +02:00
Christophe Zurn
daea3fea27 RULEAPI-785 RSPEC: education format "How to fix it" section should be optional 2023-05-05 16:29:04 +02:00
Costin Zaharia
5352da5b03
Add Benchmarks as a supported section on Resources (#1812) 2023-04-27 10:07:31 +02:00
Martin Strecker
41bb545c92
metadata.adoc: add link to the Coding rule guidelines on SonarQube (#1641) 2023-03-15 13:13:35 +00:00