16 Commits

Author SHA1 Message Date
Pierre-Loup
770348d041
Avoid OWASP Top 10 security-standard mismatch between metadata and description links (RULEAPI-798) (#3537)
* Add check for security standard mismatch

* Fix security standard mismatches

* Fix Resources/Standards links for secrets rules

* Fix check

* Fix links and update security standard mapping

* Fix maintanability issue

* Apply review suggestions

* Apply suggestions from code review

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>

* Fix typo

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>

---------

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
2024-01-17 17:20:28 +01:00
Marco Borgeaud
ce07d261a4
Diff blocks: fix some incorrect use for terraform (#2806)
Improvement identified in #2790.

Add a prefix to the diff-id when it is used multiple times in different
"how to fix it in XYZ" sections to avoid ambiguity and pedantically
follow the spec:

> A single and unique diff-id should be used only once for each type of
code example as shown in the description of a rule.
2023-08-10 15:57:41 +02:00
Loris S
bef49d6a16
Modify S4423(Azure): Add MSSQL sample (#2532)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-07-20 16:09:48 +02:00
Fred Tingaud
51369b610e
Make sure that includes are always surrounded by empty lines (#2270)
When an include is not surrounded by empty lines, its content is inlined
on the same line as the adjacent content. That can lead to broken tags
and other display issues.
This PR fixes all such includes and introduces a validation step that
forbids introducing the same problem again.
2023-06-22 10:38:01 +02:00
Loris S
1a84c758e1
Modify S4423: Learn-As-You-Code Migration (#2097)
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 15:36:01 +00:00
Fred Tingaud
16f6c0aecf
Inline adoc when include has no additional value (#1940)
Inline adoc files when they are included exactly once.

Also fix language tags because this inlining gives us better information
on what language the code is written in.
2023-05-25 14:18:12 +02:00
Victor
fe961619f9 migrate rule descriptions to new education format 2023-05-05 16:29:04 +02:00
Loris S
9d8b209353
Modify Multiple Rules(IAC): Remove Non-IAC-Based Standards in Metadata (APPSEC-5) (#1238) 2022-09-14 10:29:18 +02:00
Pierre-Loup
7194184e3a
Modify S4423: Fix See section for CF and TF (#1250) 2022-09-13 16:56:07 +02:00
Pierre-Loup
faa24755ff
Modify S4423: Fix messages for Terraform and Cloudformation 2022-03-14 13:28:34 +00:00
Pierre-Loup
378f48c68d
Modify rule S4423[terraform]:Add SSL policy for Google Cloud load balancers (#761)
* Modify rule S4423[terraform]:Add SSL policy for Google Cloud load balancers

* Add custom message and update code examples

* Add code highlighted tag to code example

Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:04:14 +01:00
Fred Tingaud
b4161466e6
RULEAPI-661: Add syntax coloring 2022-02-04 16:28:24 +00:00
hendrik-buchwald-sonarsource
f3384de644
Modify rule S4423: Add cloud tags (#628)
* Add Azure tag

* Add AWS tag

* Move tags to terraform subdir

* Change order

Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
2022-01-19 10:42:40 +00:00
hendrik-buchwald-sonarsource
936b04b3b0
Create rule S4423[terraform]: Add AWS Elasticsearch Domain (#481)
* Add description

* Fix wrong name

* Add code sample introduction

Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-01-10 13:37:41 +00:00
Pierre-Loup
c6f14b6a20
Add AWS tag to IaC rules (#662) 2021-12-16 15:02:01 +01:00
github-actions[bot]
3226c7a243
Create rule S4423[terraform]: Add AWS API Gateway Domain Name (#456)
* Add terraform to rule S4423

* Add terraform

* Include main description

* Improve description

* Update rules/S4423/description.adoc

Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>

* Update rules/S4423/terraform/rule.adoc

Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>

* Add highlight

* Add aws_api_gatewayv2_domain_name example

* Add highlight

* Change noncompliant api gateway v2

* Fix wrong apigatewayv2 name

* Add code sample introduction

Co-authored-by: hendrik-buchwald-sonarsource <hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Hendrik Buchwald <hendrik.buchwald@sonarsource.com>
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-11-08 09:10:28 +00:00