ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3,421 Commits 329 Branches 2 Tags
Commit Graph

3421 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marco Borgeaud
aecbd213d7
Modify rule S1048: remove extra space in code snippet 2023-09-12 11:08:49 +02:00
github-actions[bot]
6e57fd6621
Create rule S6754: The return value of "useState" should be destructured and named symmetrically (#3027) 2023-09-12 09:53:37 +02:00
github-actions[bot]
bad897989e
Create rule S6748: React children should not be passed as prop (#3014) 
https://github.com/SonarSource/SonarJS/issues/4129
 2023-09-12 09:48:05 +02:00
github-actions[bot]
f441c79d18
Create rule S6756: \"setState\" should use a callback when referencing the previous state (#3031) 2023-09-12 09:38:39 +02:00
SonarTech
99d7952a2b update coverage information 2023-09-12 00:32:32 +00:00
github-actions[bot]
eafd5fac25
Create rule S6750: The return value of \"ReactDOM.render\" should not be used (#3017) 2023-09-11 11:52:43 +02:00
daniel-teuchert-sonarsource
36f172fa8a
APPSEC-1053 Validate S6648 ARM default value for secret (#3019) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-11 10:02:45 +02:00
daniel-teuchert-sonarsource
8e2f0268bd
APPSEC-1049 Validate S6382 for ARM (#3024) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-11 09:07:59 +02:00
SonarTech
823100a75b update coverage information 2023-09-09 00:33:07 +00:00
Marcin Stachniuk
babdfd5c94
Modify rule S6597: "WORKDIR" instruction should be used instead of "cd" commands (#3028) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Jonas Wielage <127737854+jonas-wielage-sonarsource@users.noreply.github.com>
 2023-09-08 21:40:09 +02:00
Mary Georgiou
fa3a50811e
Pull requests list Modify S4818: Delete (#3001) 
Deleting S4818 as it has been deprecated.
Deprecated since:

sonar-dotnet 8.9.0.19135, released on Jun 26, 2020
SQ 8.4.0.35506 on Jul 3, 2020.
 2023-09-08 13:45:00 +02:00
daniel-teuchert-sonarsource
a91542370a
APPSEC-1056 Modify S6336(secrets): Make text compliant (#3013) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
 2023-09-08 10:00:48 +02:00
daniel-teuchert-sonarsource
fcda64cd35
APPSEC-1050 Modify S6378(ARM): Fix typo and adjust code examples (#3010) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-07 17:36:14 +02:00
daniel-teuchert-sonarsource
66d3ddb728
APPSEC-1015 Validate S6379(secrets): ARM (#3018) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-07 17:35:51 +02:00
Loris S
f2bf838cde
Modify S6388(ARM): Fix diffs (#3025) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-07 17:30:00 +02:00
Loris S
23fc89f4e5
APPSEC-1061 Modify S6292(secrets): Make text compliant (#3008) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-07 16:57:08 +02:00
SonarTech
1eb17f2185 update coverage information 2023-09-07 00:32:48 +00:00
github-actions[bot]
cb28ce6141
Create rule S6749: Redundant React fragments should be removed (#3016) 2023-09-06 15:58:00 +02:00
Michael Jabbour
52a3774c6e
CPP-4618 Use consistent CCT attributes for rules similar to MISRA 2023 (#3015) 
Change the CCT attribute for some Sonar rules such that they are
consistent with the attribute chosen for similar MISRA 2023 rules.
 2023-09-06 14:26:36 +02:00
github-actions[bot]
4cb2e9d55b
Create rule S6747: JSX elements should not use unknown properties and attributes (#3012) 2023-09-06 12:36:13 +02:00
Mary Georgiou
14757fa3a4
Modify S4787: Delete (#3000) 
Deleting S4787 as it has been deprecated.
Deprecated since:

sonar-dotnet 8.9.0.19135, released on Jun 26, 2020
SQ 8.4.0.35506 on Jul 3, 2020.
 2023-09-06 09:20:27 +02:00
github-actions[bot]
a9ed8edc19
Create rule S6746: In React this.state should not be mutated directly (#3009) 
https://github.com/SonarSource/SonarJS/issues/4128
---------

Co-authored-by: alexander-kamushkin-sonarsource <alexander-kamushkin-sonarsource@users.noreply.github.com>
 2023-09-06 09:05:32 +02:00
Alejandro Álvarez Ayllón
e19f2c951d
Modify rule S1764: update to LaYC and sync with implementation 
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow the guidelines

---------

Co-authored-by: Amélie Renard <44666826+amelie-renard-sonarsource@users.noreply.github.com>
 2023-09-05 16:37:24 +02:00
Egon Okerman
29e3105062
Modify rule S2254: update to LaYC format (APPSEC-1043) (#3003) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-05 15:49:01 +02:00
Egon Okerman
0abf66041f
Update rule S5808: update to LaYC format (APPSEC-972) (#2991) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-05 15:48:54 +02:00
Egon Okerman
0aa80c7af2
Modify rule S2647: Update to LaYC format (APPSEC-970) (#2917) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-05 13:46:16 +00:00
sebastien-andrivet-sonarsource
db126ee15c
Deprecate rule S3884 (#3011) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-05 13:27:15 +02:00
SonarTech
1cf71ae475 update coverage information 2023-09-05 00:33:57 +00:00
Loris S
e6506c521c
Modify S6388(IAC): Fix diff IDs (#3004) 
## Why
https://cirrus-ci.com/task/4983664824549376?logs=asciidoc_tests#L117

## Outcome


https://github.com/SonarSource/rspec/blob/master/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_disks.noncompliant.adoc
is empty for no reason

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-04 14:36:39 +02:00
Egon Okerman
e0b8bea72f
Modify rule S2612, S4423 (Go): fix diff-view errors (#3005) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-09-04 14:23:47 +02:00
Loris S
4a579ed656
Modify S6173(Java): Improve samples (#3002) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
 2023-09-04 09:25:45 +00:00
SonarTech
687e024ef1 update coverage information 2023-09-01 00:34:02 +00:00
Loris Sierra
ea613bb1ae add daniel's suggestion 2023-08-31 16:09:32 +02:00
Loris Sierra
7227478644 Modify S6723(secrets): Fix docs links 2023-08-31 16:09:32 +02:00
Egon Okerman
b0968585b4
Modify rule S6432: update to LaYC format (APPSEC-974) (#2972) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-08-31 15:05:45 +02:00
github-actions[bot]
ec657c23c8
APPSEC-1040: S6739(secrets) Detect Redis credentials (#2988) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6739/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: daniel-teuchert-sonarsource <daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Daniel Teuchert <daniel.teuchert@sonarsource.com>
 2023-08-31 13:34:15 +02:00
github-actions[bot]
62c5e35e40
Create rule S6736(secrets): AMQP Credentials should not be disclosed (#2985) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6736/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: daniel-teuchert-sonarsource <daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Daniel Teuchert <daniel.teuchert@sonarsource.com>
Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
 2023-08-31 10:23:54 +02:00
github-actions[bot]
d87780b1f3 Create rule S6732(secrets): Stripe Keys should not be hardcoded (#2977) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6732/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
 2023-08-31 09:58:50 +02:00
github-actions[bot]
d9e2823570 Create rule S6733(secrets): Airtable API Keys should not be disclosed (#2978) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6733/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
 2023-08-31 09:58:50 +02:00
Loris S
b3284f8e93
Modify S5335(php): Title update (#2990) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-08-30 17:29:28 +02:00
Egon Okerman
d408fe4dd9
Modify rule S6301: update to LaYC format (APPSEC-973) (#2984) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-08-30 13:55:19 +02:00
Egon Okerman
efcf2bdd1a
Modify rule S6317: Update to LayC format (APPSEC-968) (#2949) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-08-30 11:56:31 +02:00
sebastien-andrivet-sonarsource
2d4813b028
Modify rule S5876: Update to LayC format (APPSEC-969) (#2967) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
 2023-08-30 09:09:58 +02:00
David Kunzmann
b16ef47d90
Modify rule S6661(Python): Fixing typo in title (#2980) 2023-08-30 09:09:00 +02:00
SonarTech
dc98d476c7 update coverage information 2023-08-30 00:32:39 +00:00
github-actions[bot]
392e33a6f7 Create rule S6718(secrets): Stripe Keys should not be disclosed (#2943) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6718/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
 2023-08-29 16:01:09 +02:00
github-actions[bot]
f283b8c276 Create rule S6731(secrets): Slack Bot Tokens should not be disclosed (#2973) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6731/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
 2023-08-29 16:01:09 +02:00
github-actions[bot]
990ffb5be5 Create rule S6723(secrets): Mailgun API keys should not be disclosed (#2948) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6723/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
 2023-08-29 16:01:09 +02:00
github-actions[bot]
8919bc0cbe Create rule S6710(secrets): Firebase Cloud Messaging keys should not be disclosed (#2923) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6710/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
 2023-08-29 16:01:09 +02:00
github-actions[bot]
557efaf3eb Create rule S6719(secrets): Alchemy keys should not be disclosed (#2944) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6719/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
 2023-08-29 16:01:09 +02:00