ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,113 Commits 329 Branches 2 Tags
Commit Graph

4113 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
github-actions[bot]
c5593190ce
Create rule S5344(python): Passwords should not be stored in plain-text or with a fast hashing algorithm (#3715) 2024-03-18 17:37:51 +01:00
github-actions[bot]
576a6152e0
Create rule S6377: XML signature should be verified securely (Python) (APPSEC-1588) (#3763) 2024-03-18 17:11:22 +01:00
Loghin Vlad-Andrei
260d4830b0
Modify rule S5566: Cover std::ranges::contains (CPP-5058) 
* Edit specification to account for C++23 std::*::contains

* Addressed PR review

* Links to cppreference

* Apply suggestions from code review

Co-authored-by: Marco Borgeaud <89914223+marco-antognini-sonarsource@users.noreply.github.com>

---------

Co-authored-by: Marco Borgeaud <89914223+marco-antognini-sonarsource@users.noreply.github.com>
 2024-03-18 17:50:43 +02:00
github-actions[bot]
afffac2329
Create rule S6947: Jobs should not have too many steps (#3757) 
* Create rule S6947

* Add rule description

* Extend scope to procedure

* Hide implementation detail

---------

Co-authored-by: rudy-regazzoni-sonarsource <rudy-regazzoni-sonarsource@users.noreply.github.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
 2024-03-18 14:48:27 +01:00
Nils Werner
3dbbac4652
Modify rule S103: Remove from default profile for PHP (#3776) 2024-03-18 11:53:59 +01:00
gaetan-ferry-sonarsource
b39f6f5790
Modify rule S2053: Add better code examples and more how to fix sections (#3704) 2024-03-18 09:32:06 +01:00
SonarTech
f795d7d9d9 update coverage information 2024-03-16 00:33:06 +00:00
Jamie Anderson
23afb17784
Modify rule S5542: Change text for rule update (#3719) 2024-03-15 15:49:46 +00:00
Costin Zaharia
11db2b6549
Modify rule S3416: remove from SonarWay (#3774) 2024-03-15 16:17:40 +01:00
github-actions[bot]
fb584ec82a
Create rule S6918: "tf.Variable" objects should be singletons when created inside of a "tf.function" (#3619) 2024-03-15 16:06:59 +01:00
kevin.hinz
7bb601b5d7
Modify rule S2551: clarify example used in the description (#3713) 
* Modify rule S2551: clarify example in description

* Modify rule S2551: improve word choice
 2024-03-15 14:40:37 +01:00
kevin.hinz
fc68332d73
Modify rule S3927: Update rule description (#3712) 
* Modify rule S3927: Update rule description

Changes suggested by the Docs Squad:
- use full word in place of short-hand text

* Update rule S3927: improve word choice

Co-authored-by: Tim Pohlmann <tim.pohlmann@sonarsource.com>

---------

Co-authored-by: Tim Pohlmann <tim.pohlmann@sonarsource.com>
 2024-03-15 14:38:53 +01:00
Fred Tingaud
294be1e6df
Frontend: Display an icon next to the title if a rule has no default quality profile 2024-03-15 12:36:48 +01:00
Costin Zaharia
fbe0e1b7ff
C# Logging rules: add impact and attribute (#3766) 2024-03-15 11:52:16 +01:00
SonarTech
4fba47bc78 update coverage information 2024-03-15 00:33:07 +00:00
github-actions[bot]
e71053d356
Create rule S6675: Trace.WriteLineIf should not be used with TraceSwitch levels (#2575) 2024-03-14 17:56:25 +01:00
github-actions[bot]
5ca970e1ac
Create rule S6673: Log message template placeholders should be in the right order (#2563) 2024-03-14 17:45:06 +01:00
github-actions[bot]
fcafb3e6f0
Create rule S6670: Trace.Write and Trace.WriteLine should not be used (#2538) 2024-03-14 17:44:12 +01:00
github-actions[bot]
460fc9c64c
Create rule S6664: too many logging calls within a code block (#2494) 2024-03-14 15:53:27 +00:00
Irina Batinic
e858b2b862
Modify rule S6916: Update description to remove if case, because it is excluded from the implementation (#3758) 2024-03-14 14:41:39 +01:00
Antonio Aversa
951c7da4b7
Modify rule S3416: add C# and VB.NET (#2528) 
* Modify rule S3416: add C# and VB.NET

* Add logging frameworks to the list of allowed frameworks

* Reverse adding logging frameworks

* Fix issues from adoc validation

* Review 1

* Fix tabbing

* Review 2

* Add list of supported frameworks

* Missed renames

* Add 'logging' tag

* Remove VB.NET

* Fix a minor typo

---------

Co-authored-by: Gregory Paidis <gregory.paidis@sonarsource.com>
Co-authored-by: Gregory Paidis <115458417+gregory-paidis-sonarsource@users.noreply.github.com>
 2024-03-14 14:22:26 +01:00
guillem-bartina-sonarsource
3c1d615467
Modify rules S1871 and S3923: Update description in accordance with the new understanding (#3752) 
* Update description of S3923

* Remove exception to the exception of S1871

* Fix typo

* Wording

* Wording

* Wording

* Resolve comments

* Resolve comments 2
 2024-03-14 13:42:02 +01:00
leonardo-pilastri-sonarsource
0cbad92698
Modify rule S6878: Remove one exception (#3760) 2024-03-14 11:53:55 +01:00
github-actions[bot]
467a918de6
Create rule S6930: Backslash should be avoided in route templates (#3662) example 2024-03-14 10:55:39 +01:00
github-actions[bot]
122087850e
Create rule S6936: Names of C standard library macros and functions should not be used as identifiers (split from S978) | Modify rule S978: remove parts covered by new rule (#3706) 
* Create rule S6936

* first draft

* Wording

* modify old rule

* Fixes new rule

* Add related to new rule

* Refine examples and error message

* First batch of fixes

* Fix noncompliant example

* Remove MISRA C 2004 references + LaYC format

* Fixes

---------

Co-authored-by: guillem-bartina-sonarsource <guillem-bartina-sonarsource@users.noreply.github.com>
Co-authored-by: guillem-bartina-sonarsource <guillem.bartrina@sonarsource.com>
 2024-03-14 10:46:09 +01:00
SonarTech
2b04a60e0e update coverage information 2024-03-14 00:33:00 +00:00
github-actions[bot]
efc6728641
Create rule S6938: Jobs number of steps should be below the hard limit of 255 (#3730) 
* Create rule S6938

* Add rule description

* Only display Implementation spec on GitHub

* Update rules/S6938/jcl/rule.adoc

Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>

* Change to bug version and remove parameter

* Changing rule title

* Address review comments

* fix impact

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
 2024-03-13 15:59:46 +01:00
github-actions[bot]
a1eebc5d98
Create rule S6940: Positional parameters must precede keyword parameters (#3738) 
* Create rule S6940

* Put jcl spec

* Address review comment

---------

Co-authored-by: rudy-regazzoni-sonarsource <rudy-regazzoni-sonarsource@users.noreply.github.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
 2024-03-13 15:18:06 +01:00
Loris S
c8fc3ffe00
Modify S3649(js): Fix code samples (#3759) 2024-03-13 13:06:25 +00:00
github-actions[bot]
a1a88a27d0
Create rule S6939: DD DATA should be delimited (#3734) 
* Create rule S6939

* Add rule description

* Update rules/S6939/jcl/rule.adoc

Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
 2024-03-13 11:06:53 +01:00
github-actions[bot]
a2241c39a3
Modify rule S100: add language JCL (#3723) 
* Add jcl to rule S100

* Provide JCL details

* Address review comment

---------

Co-authored-by: rudy-regazzoni-sonarsource <rudy-regazzoni-sonarsource@users.noreply.github.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
 2024-03-12 14:53:36 +01:00
Vincenzo Pellegrini
150702c311
Modify rule S1764: Add CFamily exception for left shift operator (#3680) 
Related to CPP-4234.
 2024-03-12 14:49:53 +01:00
github-actions[bot]
68e9c93d57
Create rule S1312: Add C# and VB.NET (#2488) 
* Add csharp to rule S1312

* First specification

* Fix ascii

* Improve description

* Address comments

* Add the list of supported frameworks

* Add links to supported frameworks

* Small fixes

* Add missing closing brace

* Add tag logging

* Remove VB.NET

* Fix code snippets

---------

Co-authored-by: cristian-ambrosini-sonarsource <cristian-ambrosini-sonarsource@users.noreply.github.com>
Co-authored-by: Cristian Ambrosini <cristian.ambrosini@sonarsource.com>
Co-authored-by: Gregory Paidis <gregory.paidis@sonarsource.com>
Co-authored-by: Gregory Paidis <115458417+gregory-paidis-sonarsource@users.noreply.github.com>
 2024-03-12 13:59:26 +01:00
Marco Borgeaud
7d29a87523
Delete rule S802 (CPP-1002) 2024-03-12 12:07:34 +01:00
github-actions[bot]
4bb4693dda
Modify rule S1544: add language JCL (#3725) 
* Add jcl to rule S1544

* feed jcl details

* fix parameter

* Address review comment

---------

Co-authored-by: rudy-regazzoni-sonarsource <rudy-regazzoni-sonarsource@users.noreply.github.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
 2024-03-12 11:03:58 +01:00
Johann Beleites
9e9a1a2ea5
Modify rule S6218: Correct typo (#3755) 2024-03-12 10:38:02 +01:00
SonarTech
17211b4e3d update coverage information 2024-03-12 00:32:42 +00:00
github-actions[bot]
cf7dd4781a
Create rule S6942: Procedures should not contain in-stream data (#3741) 
* Create rule S6942

* Add rule description

---------

Co-authored-by: sallaigy <sallaigy@users.noreply.github.com>
Co-authored-by: Gyula Sallai <gyula.sallai@sonarsource.com>
 2024-03-11 16:52:56 +01:00
Angelo Buono
47a517fc47
Modify rule S3457 with example using single quote (#3753) 2024-03-11 16:34:45 +01:00
github-actions[bot]
25e2d4c040
Create rule S6883 (#3569) 
* Create rule S6883

* Specify rule

* CR fixes

---------

Co-authored-by: maksim-grebeniuk-sonarsource <maksim-grebeniuk-sonarsource@users.noreply.github.com>
Co-authored-by: Maksim Grebeniuk <maksim.grebeniuk@sonarsource.com>
Co-authored-by: Ghislain Piot <ghislain.piot@sonarsource.com>
 2024-03-11 13:48:49 +01:00
github-actions[bot]
7330c5cad1
Create rule S6900 (#3591) 
* Create rule S6900

* Specify rule

* CR fixes

* CR fixes

---------

Co-authored-by: maksim-grebeniuk-sonarsource <maksim-grebeniuk-sonarsource@users.noreply.github.com>
Co-authored-by: Maksim Grebeniuk <maksim.grebeniuk@sonarsource.com>
 2024-03-11 13:41:36 +01:00
github-actions[bot]
33572f316c
Create rule S6882 (#3567) 
* Create rule S6882

* Specify rule

* CR fixes

* CR fixes

* Remove extra comments

---------

Co-authored-by: maksim-grebeniuk-sonarsource <maksim-grebeniuk-sonarsource@users.noreply.github.com>
Co-authored-by: Maksim Grebeniuk <maksim.grebeniuk@sonarsource.com>
Co-authored-by: Ghislain Piot <ghislain.piot@sonarsource.com>
 2024-03-11 13:26:40 +01:00
github-actions[bot]
fd4abe522e
Create rule S6890: zoneinfo should be preferred to pytz when using Python 3.9 and later (#3578) 
* Create rule S6890: zoneinfo should be preferred to pytz when using Python 3.9 and later

* Fix after review

* Fix after review

---------

Co-authored-by: guillaume-dequenne-sonarsource <guillaume-dequenne-sonarsource@users.noreply.github.com>
Co-authored-by: David Kunzmann <david.kunzmann@sonarsource.com>
Co-authored-by: Guillaume Dequenne <guillaume.dequenne@sonarsource.com>
 2024-03-11 11:57:19 +01:00
github-actions[bot]
6cef4fd8ca
Create rule S6903: Using timezone-aware "datetime" objects should be preferred over using "datetime.datetime.utcnow" and "datetime.datetime.utcfromtimestamp" (#3597) 
* Create rule S6903

* Create rule S6903: Using timezone aware "datetime"s should be preferred over using "datetime.datetime.utcnow" and "datetime.datetime.utcfromtimestamp"

* Fix after review

* Minor updates

---------

Co-authored-by: joke1196 <joke1196@users.noreply.github.com>
Co-authored-by: David Kunzmann <david.kunzmann@sonarsource.com>
Co-authored-by: Guillaume Dequenne <guillaume.dequenne@sonarsource.com>
 2024-03-11 11:53:04 +01:00
github-actions[bot]
acd7bf42a5
Create rule S6887: pytz.timezone should not be passed to the datetime.datetime constructor (#3573) 2024-03-11 11:15:08 +01:00
SonarTech
1ea0026393 update coverage information 2024-03-09 00:32:38 +00:00
github-actions[bot]
334e99d17a
Create rule S2139: Add C# (#2465) 2024-03-08 17:24:42 +01:00
Arseniy Zaostrovnykh
710031d3d8
Use the new channel name in update_coverage.yml 2024-03-08 16:39:14 +01:00
github-actions[bot]
df644a9db1
Create rule S6669: Logger field names should comply with a naming convention (#2533) 
* Create rule S6669

* First specification

* Add backticks

* Add compliant and noncompliant comments

* Add properties

* Use standard RSPEC format for links

* Change the scope to "Main"

* Fix default format regex

* Remove VB.NET

* Add logging tag

* Fix asciidoc issues

---------

Co-authored-by: cristian-ambrosini-sonarsource <cristian-ambrosini-sonarsource@users.noreply.github.com>
Co-authored-by: Cristian Ambrosini <cristian.ambrosini@sonarsource.com>
Co-authored-by: Gregory Paidis <gregory.paidis@sonarsource.com>
Co-authored-by: Gregory Paidis <115458417+gregory-paidis-sonarsource@users.noreply.github.com>
 2024-03-08 16:01:23 +01:00
github-actions[bot]
1ae135be36
Create rule S6672: Generic logger injection should match enclosing type (#2546) 
* Create rule S6672

* Fix inclusion

* Fix rspecator inclusion

* Code review 1

* Add logger tag

* Remove VB.NET

---------

Co-authored-by: antonioaversa <antonioaversa@users.noreply.github.com>
Co-authored-by: Antonio Aversa <antonio.aversa@sonarsource.com>
Co-authored-by: Gregory Paidis <gregory.paidis@sonarsource.com>
Co-authored-by: Gregory Paidis <115458417+gregory-paidis-sonarsource@users.noreply.github.com>
 2024-03-08 15:56:46 +01:00