ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,465 Commits 329 Branches 2 Tags
Commit Graph

1852 Commits

Author SHA1 Message Date
Antonio Aversa
c6e12bbf8d
Modify rule S3776: LaYC format (#2215) 2023-06-16 15:42:52 +02:00
Antonio Aversa
f7f5c521b6
Modify rule S4487: fix missing space in code example (#2224) 2023-06-16 15:42:30 +02:00
Amélie Renard
bc97d7b4ca
Modify rule S122: LaYC format 2023-06-16 13:38:45 +00:00
Antonio Aversa
057071b616
Modify rule S2198: LaYC format (#2156) 2023-06-16 15:37:20 +02:00
Čaba Šagi
53c580c9e7
Modify rule S2445: Fix java diff tag (#2221) 2023-06-16 15:21:46 +02:00
Čaba Šagi
4a0501a187
Modify rule S4277: Fix vbnet diff tag (#2222) 2023-06-16 15:13:15 +02:00
Čaba Šagi
3f380c4974
Modify rule S4158: Fix vb.net compliant solution formatting (#2219) 2023-06-16 14:56:08 +02:00
Martin Strecker
05590ca33f
Modify rule S2583: Fix quickfix field (#2216) 2023-06-16 12:57:15 +02:00
Martin Strecker
e409c102f2
Modify rule S2583: LaYC format (#2196) 
[S2583](https://sonarsource.github.io/rspec/#/rspec/S2583/csharp)

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-16 12:27:54 +02:00
Gregory Paidis
2aa6cde667
Modify rule S2190: LaYC format (#1962) 
Also remove unused languages.

---------

Co-authored-by: vilchik.elena <elena.vilchik@sonarsource.com>
 2023-06-16 12:23:50 +02:00
Čaba Šagi
3598b25d49
Modify rule S1110: Update dotnet part of the rule to LayC (#2214) 2023-06-16 11:18:11 +02:00
Antonio Aversa
d70b5b5faf
Modify rule S3464: fix VB.NET code example (#2212) 2023-06-16 11:03:44 +02:00
Amélie Renard
fcd323ebd3
Modify rule S108: fix Kotlin LaYC format 2023-06-16 10:35:12 +02:00
Mary Georgiou
48e3edab0a
Modify S3966: Fix broken argument (#2210) 2023-06-16 09:52:11 +02:00
Fred Tingaud
0bbdb53a0c
Modify Rule S2692: LaYC indexOf 
Co-authored-by: Amélie Renard <44666826+amelie-renard-sonarsource@users.noreply.github.com>
 2023-06-16 09:50:40 +02:00
Sebastien Marichal
9657591468
Modify rule S2589: LaYC format (#2195) 2023-06-16 09:28:19 +02:00
Fred Tingaud
49e4aff3ec
Modify Rule S2757: LaYC =+ 
Co-authored-by: Amélie Renard <44666826+amelie-renard-sonarsource@users.noreply.github.com>
 2023-06-15 19:30:44 +02:00
Amélie Renard
4a48939718
Modify rule S108: LaYC format 2023-06-15 19:03:19 +02:00
Čaba Šagi
8bd7d95bdb
Modify S4158: LayC format (#2208) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-15 17:37:19 +02:00
Mary Georgiou
6726dcc4b6
Modify rule S3966: Migrate to LaYC (#2135) 2023-06-15 17:26:30 +02:00
Cristian Ambrosini
fd97e50b11
Modify rule S1117: Update to LaYC (#2207) 2023-06-15 17:09:18 +02:00
cynthiabethea
09e3db2ac9
modify_S2639_layc_js_only (#2122) 
Made some updates to rule text for Java, Javascript, and the general
description for the other languages.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone

---------

Co-authored-by: Elena Vilchik <elena.vilchik@sonarsource.com>
 2023-06-15 15:56:08 +01:00
Gregory Paidis
cfb6eb88f4
Modify S1479: LAYC format (#2205) 2023-06-15 16:30:42 +02:00
Čaba Šagi
540bcd001c
Modify rule S1118: Update to LaYC (#2206) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-15 15:32:44 +02:00
Martin Strecker
f95d517a7c
Modify rule S4586: LaYC format (#2155) 
Update rule content and descriptions to LaYC format.
https://sonarsource.github.io/rspec/#/rspec/S4586

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-15 15:08:57 +02:00
Pavel Mikula
fe3d15fdc6
Modify rule S4158: Improve C# and VB.NET examples (#2181) 2023-06-15 13:54:49 +02:00
Amélie Renard
a5545cf46e
Modify rule S121: LaYC format 2023-06-15 11:57:45 +02:00
Martin Strecker
e77be4d8ae
Modify rule S2114: LaYC format (#2190) 2023-06-15 11:09:43 +02:00
Costin Zaharia
ea3ad82654
Modify rule S3655: LaYC format (#2204) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-15 11:08:34 +02:00
Sebastien Marichal
f34d52a1e1
Modify rule S1944: Fix detail in VB.NET example (#2203) 2023-06-15 10:52:04 +02:00
Gregory Paidis
ef35d53ede
Modify rule S2291: LAYC format (#2169) 2023-06-15 10:20:09 +02:00
Costin Zaharia
e6db263ce7
Modify rule 3442: apply LaYC format (#2194) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-15 09:34:26 +02:00
Victor
e150501da3
Modify rule S2137: Adapt to LaYC (#2167) 2023-06-15 09:33:20 +02:00
Antonio Aversa
6c5bfd51f6
Modify rule S2692: align C# and VB.NET examples (#2201) 2023-06-15 08:58:50 +02:00
Antonio Aversa
d4b7a21cc3
Modify rule S3464: fix code example (#2199) 2023-06-15 08:55:51 +02:00
Antonio Aversa
ec89f9dcd0
Modify rule S4487: LaYC format (#2198) 2023-06-15 08:54:48 +02:00
Čaba Šagi
c34296e707
Modify rule S2290: Update to LaYC (#2178) 2023-06-14 17:17:39 +02:00
Čaba Šagi
9b7e0791b4
Modify rule S2445: Update to LayC (#2184) 2023-06-14 15:58:29 +02:00
Cristian Ambrosini
dafa102cc0
Modify rule S4583: Update to LaYC (#2185) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 15:44:31 +02:00
Čaba Šagi
285e392afb
Modify rule S4277: Update to LaYC (#2177) 2023-06-14 15:13:08 +02:00
Costin Zaharia
823c9677c9
Modify rule S3445: LaYC format (#2151) 2023-06-14 15:00:43 +02:00
Martin Strecker
b2ead97d57
Modify rule S4275: LaYC format (#2168) 
Update rule content and descriptions to LaYC format.
[S4275: Getters and setters should access the expected
fields](https://sonarsource.github.io/rspec/#/rspec/S4275)

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 14:59:18 +02:00
Fred Tingaud
2cf7d97fd2
Remove languages that were never implemented for shared rules 
Rules that were never implemented for any language are also removed.

Removing, per language:

## cobol
[S103, S1068, S1075, S1125, S1139, S1151, S126, S1301, S1488, S1607,
S1614, S1615, S1639, S1751, S1763, S1820, S1821, S1909, S1940, S1968,
S2024, S2145, S2189, S2190, S2197, S2251, S2252, S2760, S3047, S3269,
S3516, S3635, S3638, S3639, S3645, S3650, S3651, S3776, S3830, S3931,
S4109, S4143, S4158, S4165, S4632, S4663, S5871, S6194, S6273]

## csharp
[S1034, S1103, S1105, S1106, S1107, S1108, S1126, S1131, S1142, S115,
S1166, S117, S119, S1223, S124, S1247, S1312, S1314, S139, S140, S1448,
S1578, S1695, S1707, S1820, S1872, S1874, S1941, S1968, S1987, S2095,
S2107, S2108, S2139, S2145, S2147, S2149, S2159, S2177, S2189, S2205,
S2250, S2301, S2334, S2373, S2490, S2544, S2588, S2596, S2597, S2690,
S2691, S2702, S2752, S2833, S3041, S3044, S3047, S3062, S3065, S3075,
S3076, S3087, S3222, S3239, S3269, S3317, S3325, S3359, S3375, S3414,
S3473, S3516, S3518, S4030, S4165, S4470, S4632, S4977, S5359, S5871,
S6061, S6147, S6194, S864, S867, S899, S997]

## flex
[S1034, S104, S105, S1067, S1075, S109, S1103, S1104, S1105, S1106,
S1107, S1108, S1109, S1110, S1119, S1121, S1126, S113, S1131, S1141,
S1143, S1168, S1192, S1200, S121, S1226, S1247, S126, S1264, S1291,
S139, S1450, S1479, S1488, S1546, S1607, S1656, S1659, S1751, S1763,
S1764, S1782, S1845, S1854, S1858, S1862, S1872, S1905, S1940, S1941,
S1987, S1990, S1994, S2039, S2123, S2139,2145, S2149, S2156, S2159,
S2189, S2190, S2197, S2198, S2201, S2205, S2234, S2251, S2252, S2259,
S2301, S2387, S2440, S2583, S2588, S2589, S2596, S2597, S2639, S2681,
S2691, S2737, S2752, S2757, S2760, S2761, S2887, S2963, S3031, S3041,
S3047, S3065, S3075, S3076, S3222, S3239, S3241, S3242, S3269, S3358,
S3370, S3440, S3458, S3516, S3518, S3776, S3872, S3981, S4025, S4143,
S4144, S4158, S4165, S4632, S4663, S5871, S6194, S878, S881, S899]

## java
[S1034, S1131, S1247, S1453, S1707, S1772, S1782, S1888, S1968, S1990,
S2107, S2108, S2145, S2149, S2198, S2205, S2327, S2373, S2436, S2490,
S2526, S2588, S2596, S2597, S2690, S2691, S2702, S2738, S2752, S2760,
S2814, S2833, S2963, S2997, S3018, S3019, S3031, S3041, S3044, S3062,
S3075, S3076, S3087, S3222, S3239, S3241, S3249, S3263, S3269, S3317,
S3353, S3359, S3370, S3375, S3397, S3440, S3458, S3473, S3604, S3872,
S3887, S3949, S4025, S4030, S4136, S4158, S4632, S4663, S5780, S5781,
S5871, S6194, S787]

## php
[S1034, S109, S1104, S1107, S1119, S1120, S1128, S1143, S1199, S1213,
S1247, S1450, S1694, S1707, S1845, S1858, S1872, S1905, S1941, S1952,
S1968, S1987, S1994, S2095, S2108, S2114, S2139, S2145, S2149, S2156,
S2159, S2177, S2189, S2190, S2197, S2205, S2252, S2259, S2301, S2387,
S2583, S2588, S2589, S2596, S2597, S2639, S2691, S2752, S2760, S2814,
S2833, S3010, S3041, S3047, S3065, S3075, S3239, S3254, S3269, S3400,
S3440, S3458, S3466, S3516, S3518, S3872, S3931, S4030, S4165, S4188,
S4275, S4632, S4663, S5797, S5871, S6194, S864, S899]

## pli
[S104, S105, S1066, S1067, S1068, S1075, S108, S1110, S1135, S1151,
S1172, S1186, S1247, S125, S126, S1291, S1301, S138, S1451, S1479,
S1481, S1488, S1607, S1614, S1615, S1656, S1737, S1745, S1751, S1763,
S1764, S1821, S1854, S1862, S1871, S1909, S1940, S2527, S2583, S2589,
S2681, S2757, S3516, S3633, S3635, S3637, S3638, S3639, S3640, S3641,
S3643, S3644, S3645, S3647, S3650, S3651, S3652, S3776, S3890, S3923,
S3973, S4632, S4663, S5871, S6194, S864]

## abap
[S1045, S1075, S1135, S1144, S1186, S1226, S1291, S138, S1448, S1451,
S1479, S1601, S1607, S1763, S1820, S1821, S1854, S1905, S1909, S1940,
S2147, S2189, S2190, S2387, S2527, S2583, S2589, S2737, S2760, S3047,
S3269, S3358, S3516, S3635, S3637, S3638, S3639, S3640, S3641, S3644,
S3645, S3647, S3650, S3651, S3652, S4109, S4165, S4632, S4663, S5871,
S6194, S864]

## plsql
[S105, S1067, S1075, S1120, S1139, S1186, S1226, S1247, S138, S1488,
S1578, S1607, S1639, S1737, S1738, S1909, S2234, S2583, S2589, S2814,
S3269, S3270, S3358, S3516, S3518, S3635, S3637, S3638, S3639, S3640,
S3644, S3645, S3647, S3650, S3652, S3776, S3890, S3931, S3981, S4109,
S4165, S4413, S4632, S4663, S5871, S6194, S864]

## python
[S105, S1067, S1075, S109, S1125, S1126, S1128, S115, S1155, S1247,
S126, S1314, S1448, S1450, S1488, S1695, S1696, S1820, S1872, S1905,
S1941, S1952, S1987, S1996, S2095, S2114, S2139, S2145, S2149, S2166,
S2189, S2197, S2205, S2251, S2252, S2301, S2321, S2588, S2596, S2597,
S2639, S2691, S2752, S2760, S2833, S2963, S3041, S3047, S3065, S3075,
S3239, S3241, S3254, S3269, S3440, S3458, S3466, S3696, S3717, S3723,
S3872, S4030, S4158, S4165, S4632, S4663, S5871, S6194, S864, S899,
S907]

## javascript
[S1065, S1068, S1103, S1104, S1106, S1107, S1108, S1109, S1142, S1144,
S1147, S115, S1151, S116, S1199, S1200, S1247, S1291, S140, S1448,
S1450, S1578, S1607, S1659, S1707, S1820, S1845, S1872, S1905, S1941,
S1952, S1968, S1987, S1996, S2039, S2108, S2145, S2149, S2159, S2190,
S2205, S2252, S2301, S2326, S2372, S2387, S2588, S2596, S2597, S2691,
S2752, S2830, S2887, S2959, S3041, S3047, S3065, S3075, S3235, S3239,
S3325, S3440, S3458, S3518, S3872, S4025, S4487, S4632, S4663, S5603,
S5871, S6194, S864, S899]

## rpg
[S1066, S107, S1075, S1110, S1135, S1172, S1186, S124, S1247, S1291,
S1301, S131, S1448, S1479, S1481, S1578, S1607, S1614, S1615, S1735,
S1739, S1741, S1745, S1751, S1763, S1821, S1854, S1909, S1940, S1968,
S2189, S2190, S2197, S2251, S2252, S2260, S2527, S2583, S2589, S2757,
S2760, S3047, S3269, S3516, S3635, S3637, S3638, S3639, S3640, S3641,
S3643, S3644, S3645, S3647, S3650, S3651, S3652, S3776, S3890, S3923,
S4109, S4158, S4165, S4632, S4663, S5871, S6194, S864]

## rust
[S1066, S1067, S1172, S125, S1763, S2757, S2761, S3358, S3776, S3923,
S3981, S4143, S4144, S4663, S5871, S6194]

## solidity
[S1066, S1067, S125, S2757, S3776, S3923, S3981, S4143, S4144, S5871,
S6194]

## vbnet
[S1068, S1104, S1105, S1106, S1126, S1131, S1142, S1143, S1144, S116,
S119, S124, S1247, S125, S127, S140, S1448, S1488, S1578, S1607,1669,
S1694, S1695, S1696, S1698, S1707, S1763, S1820, S1845, S1854, S1858,
S1872, S1905, S1941, S1968, S1987, S2096, S2108, S2139, S2145, S2149,
S2159, S2189, S2190, S2197, S2198, S2201, S2205, S2250, S2251, S2301,
S2334, S2583, S2588, S2589, S2596, S2597, S2691, S2760, S3041, S3047,
S3236, S3239, S3242, S3269, S3376, S3440, S3458, S3516, S3518, S3626,
S3688, S3872, S3902, S3906, S3908, S3925, S3993, S3994, S3995, S3996,
S3997, S4004, S4005, S4018, S4022, S4023, S4026, S4030, S4040, S4158,
S4165, S4220, S4456, S4457, S4462, S4470, S4632, S5871, S6061, S6194,
S864, S899]

## html
[S1075, S1143, S1291, S1707, S1952, S2166, S2197, S2201, S2205, S2251,
S2588, S2596, S2597, S4632, S4663, S5871]

## tsql
[S1075, S1125, S1226, S1741, S1854, S2234, S2524, S2544, S2583, S2589,
S2757, S3270, S3618, S3651, S3776, S3830, S3981, S4158, S4165, S4632,
S4663, S5245, S5871, S6194, S864]

## vb6
[S1075, S1110, S1144, S1172, S1192, S1226, S125, S126, S127, S1291,
S134, S1448, S1451, S1481, S1578, S1607, S1656, S1707, S1751, S1763,
S1764, S1854, S1858, S1862, S1871, S1909, S1940, S1941,1987, S2145,
S2149, S2189, S2190, S2197, S2198, S2205, S2234, S2251, S2252, S2259,
S2301, S2583, S2588, S2596, S2597, S2760, S2761, S3047, S3269, S3440,
S3458, S3516, S3626, S3776, S3923, S3981, S4143, S4144, S4158, S4165,
S4632, S4663, S5871, S6145, S6146, S6194, S899]

## swift
[S109, S1103, S1119, S1121, S1185, S1226, S1247, S127, S1270, S1291,
S1448, S1450, S1537, S1545, S1578, S1607, S1707, S1874, S1968, S2039,
S2114, S2123, S2177, S2234, S2253, S2301, S2373, S2440, S2490, S2583,
S2588, S2589, S2596, S2597, S2639, S2691, S2752, S2833, S2931, S3019,
S3031, S3041, S3044, S3047, S3065, S3075, S3076, S3239, S3241, S3242,
S3244, S3254, S3269, S3317, S3353, S3366, S3370, S3397, S3398, S3440,
S3458, S3466, S3516, S3518, S3688, S3872, S3931, S3949, S4025, S4030,
S4158, S4165, S4200, S4275, S4487, S4503, S4632, S4663, S5359, S5871,
S6194, S864, S867, S925]

## cfamily
[S1104, S1105, S1106, S1107, S1108, S1109, S1124, S1125, S1126, S114,
S115, S119, S1192, S1200, S1247, S1312, S1450, S1453, S1488, S1595,
S1607, S1782, S1845, S1888, S1899, S1941, S1952, S1968, S2039, S2096,
S2108, S2139, S2149, S2159, S2164, S2166, S2177, S2198, S2205, S2252,
S2326, S2327, S2440, S2490, S2588, S2596, S2597, S2639, S2691, S2752,
S2760, S2833, S2963, S3031, S3038, S3044, S3047, S3065, S3075, S3076,
S3235, S3239, S3241, S3242, S3269, S3317, S3353, S3370, S3397, S3398,
S3440, S3466, S3872, S3878, S3981, S3984, S3985, S4025, S4158, S4165,
S4275, S4503, S4632, S4663, S4970, S5871]

## xml
[S1128, S1291, S1707, S4632, S4663]

## kotlin
[S113, S2583, S3011, S3973, S4143, S5871, S6194]

## scala
[S113, S2583, S2757, S2761, S3011, S3358, S3981, S4143, S5871, S6194]

## go
[S1155, S125, S127, S2114, S2197, S2583, S3626, S4487, S4632, S5871,
S6194, S899]

## ruby
[S125, S2583, S3973, S3981, S4143, S5871, S6194]

## apex
[S2761, S3358, S3981, S4143, S5871, S6194]

## css
[S4632, S5871]
 2023-06-14 14:43:06 +02:00
Cristian Ambrosini
aaa468bf3a
Modify rule S1134: Update to LaYC (#2189) 
I removed abap, flex, pli and rpg dummy implementations since they're
not implemented in the corresponding analyzer and there are no tickets
open to do so.
 2023-06-14 14:23:44 +02:00
Costin Zaharia
afefc85dac
Modify rule S1144: LaYC format (#2183) 2023-06-14 14:04:05 +02:00
Sebastien Marichal
2a6106862e
Modify rule S1944: Improve VB.NET example (#2182) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 11:13:10 +02:00
Fred Tingaud
a3f81b0b6c
Modify rule S3358: LaYC for Nested ternaries 
Co-authored-by: Amélie Renard <44666826+amelie-renard-sonarsource@users.noreply.github.com>
 2023-06-14 08:47:35 +00:00
Čaba Šagi
4b843bf87a
Modify rule S5034: Update to LaYC (#2152) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-06-14 10:23:06 +02:00
Johann Beleites
a664bedde9
Deprecate rule S1610 [SONARJAVA-4485] (#2161) 2023-06-14 10:05:19 +02:00
Fred Tingaud
a08c3bbd23
Modify Rule S3011: LaYC reflection 
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
 2023-06-13 19:24:21 +02:00