2609 Commits

Author SHA1 Message Date
Andrea Guarino
88a814b01e
Adjust clean code attributes for DBD rules (#2952) 2023-08-24 10:05:19 +02:00
tomasz-kaminski-sonarsource
be4265a91f
Modify rule S2259: Expand and adjust for LaYC 2023-08-24 09:32:24 +02:00
github-actions[bot]
0e4746e235
Create rule S6708(secrets): Discord Webhook URLs should not be disclosed (#2919)
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6708/secrets)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: daniel-teuchert-sonarsource <daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Daniel Teuchert <daniel.teuchert@sonarsource.com>
Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2023-08-23 15:37:47 +02:00
Philipp Dominik Schubert
1e2bf05e5b
Modify rule S5280: Update quickfix status
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-23 15:28:39 +02:00
Philipp Dominik Schubert
00d10a799e
Modify rule S5280: Expand and adjust for LaYC
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-23 14:27:08 +02:00
Philipp Dominik Schubert
acaeb943cf
Modify rule S5273: Expand and adjust for LaYC
**Caution:** our analyzer currently does not correctly detect the issue
in the first code example in section `Why is this an issue?`.


## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-23 13:59:14 +02:00
Egon Okerman
ee3a611ce2
Modify rule S4347: Update to LayC format (APPSEC-975) (#2903)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-23 13:18:37 +02:00
Mary Georgiou
a4b68c982b
Modify S2255: Delete (#2930)
Deleting S2255 as it has been deprecated.
Deprecated since:
-  sonar-dotnet 8.9.0.19135, released on Jun 26, 2020
- SQ 8.4.0.35506 on Jul 3, 2020.
2023-08-23 10:58:18 +02:00
Tibor Blenessy
fa56bf4c9c
Modify rule S3699: Remove duplicated MDN prefix from links (#2932) 2023-08-23 10:25:03 +02:00
Anton Haubner
b5a123e90f
Modify rule S6416: Also check for IllegalStateException (#2826) 2023-08-23 10:10:34 +02:00
Antonio Aversa
f8b02f1be9
Modify rule S2589: fix missing diff-id (#2931)
Related to [this discuss
post](https://discuss.sonarsource.com/t/layc-diff-view-validation/15392/2?u=antonio.aversa).
2023-08-23 08:53:31 +02:00
Philipp Dominik Schubert
74e699cf15
Modify rule S3588: Expand and adjust for LaYC
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-22 14:33:47 +02:00
Philipp Dominik Schubert
70be86ab51
Modify rule S5308: Expand and adjust for LaYC (#2916)
## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: tomasz-kaminski-sonarsource <79814193+tomasz-kaminski-sonarsource@users.noreply.github.com>
2023-08-22 08:54:59 +00:00
Philipp Dominik Schubert
fa9676ea16
Modify rule S5488: Expand and adjust for LaYC
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-22 10:04:47 +02:00
Yassin Kammoun
881f0fd245
Modify rule S6661: Quote the method's name in the title (#2915)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-21 16:33:29 +02:00
Marco Borgeaud
8209548e54
Diff blocks: fix incorrect use for python (#2795)
Improvement identified in #2790.

Add a prefix to the diff-id when it is used multiple times in different
"how to fix it in XYZ" sections to avoid ambiguity and pedantically
follow the spec:

> A single and unique diff-id should be used only once for each type of
code example as shown in the description of a rule.

Obvious typos around `diff-type` were fixed.

An obvious extra use of diff blocks was removed.
2023-08-21 15:22:49 +02:00
Cristian Ambrosini
08247967e0
S2931: fix spacing (#2913)
Fixing tabs on Compliant solution snippet (it was showing `$nbsp;`)

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-21 11:22:22 +02:00
Loris S
cd03a1dd3d
Modify S5144&S6547: Improve fixes (#2912)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-21 10:51:21 +02:00
Ilia Kebets
4db020b283
Modify rule S1488: add code example when returning awaited promise (#2909)
Fixes https://github.com/SonarSource/eslint-plugin-sonarjs/issues/413
2023-08-21 10:28:17 +02:00
Loris S
5a15b560fd
APPSEC-843 Modify S3329: Mention FIPS-compliant PRNG (#2904)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
2023-08-21 07:55:20 +00:00
cynthiabethea
33d408cbfd
cyn/modify-S2696-layc-ltypo (#2910)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-18 16:52:42 +01:00
Marco Kaufmann
52a0ee1b41
Modify rule S106: reworked rule description for LaYC format, SONARJAVA-4570 (#2907) 2023-08-18 16:39:19 +02:00
Alban Auzeill
f57852ffb7
Modify rule S2189: Fix diff-id (#2908) 2023-08-18 16:01:09 +02:00
github-actions[bot]
de5d7d9043
Create rule S6485: Hash-based collections should be initlizialized with the related static method for better performance (#1441) 2023-08-18 16:00:26 +02:00
Alban Auzeill
a25eaee927
Modify rule S4838: Fix typos (#2906) 2023-08-18 13:55:15 +00:00
leonardo-pilastri-sonarsource
2808713f12
Modify rule S3020: better rule title (#2852) 2023-08-18 15:12:42 +02:00
Marco Kaufmann
92b3f17c07
Modify rule S5413: reworked rule description for LaYC format (#2905) 2023-08-18 14:16:29 +02:00
Yassin Kammoun
289a124d78
Modify rule S107: Do not count TypeScript parameter properties (#2898)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-18 14:01:14 +02:00
Dorian Burihabwa
9ce1a8de8e
Modify rule S2589: Fix typo and formatting in code examples [SONARJAVA-4463] (#2902) 2023-08-18 12:09:07 +02:00
github-actions[bot]
64f9977e49
Create rule S6399(C#): XML operations should not be vulnerable to injection attacks (#2860)
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6399/csharp)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: daniel-teuchert-sonarsource <daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Daniel Teuchert <daniel.teuchert@sonarsource.com>
Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2023-08-18 11:31:42 +02:00
Loris S
a0abb99f76
Modify S2596(javascript): Convert to LayC (#2901)
This PR also removes the java folder because it is not implemented and
has no implementation plan. This PR was made spontaneously during
Daniel's onboarding.

---------

Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
2023-08-18 09:31:06 +00:00
Irina Batinic
61b3938fc0
Modify rule S6073: reworked rule description for LaYC format (#2892) 2023-08-17 16:53:46 +02:00
Marco Kaufmann
7e57722182
Modify rule S127: reworked rule description for LaYC format (#2894) 2023-08-17 16:30:56 +02:00
erwan-serandour-sonarsource
ad0f7fd6dc
SONARJAVA-4463 add significant example to rule S2589 (#2900) 2023-08-17 15:53:33 +02:00
Irina Batinic
cb9bb3162a
Modify rule S1264: Update rule description according to the LaYC (#2891) 2023-08-17 15:25:56 +02:00
Marco Kaufmann
a8a91b23f7
Modify rule S1994: reworked rule description for LaYC format (#2889) 2023-08-17 14:54:01 +02:00
Marco Kaufmann
7e11ea7299
Modify rule S2251: reworked rule description for LaYC format (#2886) 2023-08-17 14:53:18 +02:00
github-actions[bot]
ae93071324
Create rule S2245: Add "Using pseudorandom number generators (PRNGs) is security-sensitive" to Go (#2824)
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S2245/go) (updated a
few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: sebastien-andrivet-sonarsource <sebastien-andrivet-sonarsource@users.noreply.github.com>
Co-authored-by: sebastien-andrivet-sonarsource <sebastien.andrivet@sonarsource.com>
2023-08-17 14:25:58 +02:00
github-actions[bot]
b5aa16faa3
Create rule S4507: Add "Delivering code in production with debug features activated is security-sensitive" to Go (#2858)
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S4507/go) (updated a
few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: sebastien-andrivet-sonarsource <sebastien.andrivet@sonarsource.com>
Co-authored-by: sebastien-andrivet-sonarsource <138577785+sebastien-andrivet-sonarsource@users.noreply.github.com>
Co-authored-by: Jamie Anderson <127742609+jamie-anderson-sonarsource@users.noreply.github.com>
2023-08-17 14:25:28 +02:00
erwan-serandour-sonarsource
ef25af53bc
SONARJAVA-4563 S1258 update documentation to support new annotation (#2899) 2023-08-17 14:18:19 +02:00
github-actions[bot]
a15c1733db
Create rule S6547(C#): Environment variables should not be defined from untrusted input (#2875)
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6547/csharp)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: daniel-teuchert-sonarsource <daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Daniel Teuchert <daniel.teuchert@sonarsource.com>
Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2023-08-17 12:58:46 +02:00
Anton Haubner
52b830187d
Modify rule S935: Fix ruleSpecification value in metadata (#2895) 2023-08-17 10:55:56 +02:00
Irina Batinic
5829684329
Modify rule S135: Update rule description according to the LaYC (#2888) 2023-08-16 15:21:28 +02:00
github-actions[bot]
10cb45778a
Create rule S4423: add Go (APPSEC-905) (#2830)
Research ticket:
[APPSEC-905](https://sonarsource.atlassian.net/browse/APPSEC-905)

You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S4423/go) (updated a
few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)



[APPSEC-905]:
https://sonarsource.atlassian.net/browse/APPSEC-905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: egon-okerman-sonarsource <egon-okerman-sonarsource@users.noreply.github.com>
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
2023-08-16 13:53:27 +02:00
chrislain-razafimahefa-sonarsource
d6296c69f4
Modify rule S6466: Fix typos (#2890) 2023-08-16 13:35:16 +02:00
github-actions[bot]
adac450cab
Create rule S2612: add Go (APPSEC-908) (#2869)
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S2612/go) (updated a
few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: egon-okerman-sonarsource <egon-okerman-sonarsource@users.noreply.github.com>
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
2023-08-16 11:42:20 +02:00
Antonio Aversa
1288ef29bf
Modify rules S1186, S2589, S2953: Fix incorrect use of diff blocks (#2884)
Related to
https://discuss.sonarsource.com/t/layc-diff-view-validation/15392

Fixes remaining issues for C#, VB.NET and VB6.

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-16 10:45:12 +02:00
Marco Kaufmann
d27acc7bf1
Modify rule S4838: reworked rule description for LayC format [SONARJAVA-4578] (#2885) 2023-08-16 10:26:18 +02:00
Leonardo Pilastri
898f00a110 Diff blocks: fix incorrect use for kotlin 2023-08-16 10:09:30 +02:00
github-actions[bot]
4532785786
Create rule S5332: Using clear-text protocols is security-sensitive (Go support) (#2874)
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S5332/go) (updated a
few minutes after each push).

Related tickets:
* Research ticket:
[APPSEC-898](https://sonarsource.atlassian.net/browse/APPSEC-898)
* Implementation ticket (HTTP):
[SONARSLANG-605](https://sonarsource.atlassian.net/browse/SONARSLANG-605)
* Implementation ticket (FTP):
[SONARSLANG-604](https://sonarsource.atlassian.net/browse/SONARSLANG-604)
* Implementation ticket (SMTP):
[SONARSLANG-603](https://sonarsource.atlassian.net/browse/SONARSLANG-603)

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-08-15 17:11:21 +01:00