ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,970 Commits 329 Branches 2 Tags
Commit Graph

2970 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Martin Strecker
d84dc21774
Add VS code schema support for manifest.json (#2767) 
Adds json schema support for VS Code (especially [IntelliSense and
validation](https://code.visualstudio.com/docs/languages/json#_intellisense-and-validation)):


![image](https://github.com/SonarSource/rspec/assets/103252490/45145852-08d2-4bf3-af82-7f176afb29c6)
 2023-08-03 09:02:47 +02:00
Marcin Stachniuk
8dbe0e2ed2
Modify rule S6413: Defining a short log retention duration is security-sensitive, add Bicep format (#2743) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-08-03 08:42:07 +02:00
SonarTech
b9614645f8 update coverage information 2023-08-03 00:31:08 +00:00
Balázs Benics
fb00cb04fd
Modify rule S5314: Expand and adjust for LaYC (#2748) 2023-08-02 17:22:40 +02:00
Maksim Grebeniuk
7bca7afd5d
Create rule S6659: 'startswith' or 'endswith' methods should be used instead of string slicing in condition expressions (#2476) 2023-08-02 17:20:30 +02:00
Irina Batinic
87a286cd90
Modify rule S2039: SONARJAVA-4467 Remove deprecation S2039 for Java (#2762) 2023-08-02 17:07:01 +02:00
Anton Haubner
714ee0bb94
Merge S6658 into S935 (#2761) 
This merges S6658 into S935, see also this discussion on slack:
https://sonarsource.slack.com/archives/CFUS31LRE/p1690534750237959

This is the previous PR for merging S6658 which this PR is based on:
https://github.com/SonarSource/rspec/pull/2450

---------

Original S6658 rule authored-by: Maksim Grebeniuk <maksim.grebeniuk@sonarsource.com>
 2023-08-02 16:55:20 +02:00
Arseniy Zaostrovnykh
46a58e80ca
Modify rule S2107: Expand and adjust for LaYC 
I moved and closed the Java rule description because they do not plan to
implement it, but it is nice to preserve the description for posterity.
 2023-08-02 14:52:06 +00:00
Amélie Renard
2cc06788de
Modify rule S5489: modernize example 2023-08-02 16:34:08 +02:00
github-actions[bot]
d644d018db
Create rule S6662: Set members and dictionary keys should be hashable (#2477) 
You can preview this rule
[here](https://sonarsource.github.io/rspec/#/rspec/S6662/python)
(updated a few minutes after each push).

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: guillaume-dequenne-sonarsource <guillaume-dequenne-sonarsource@users.noreply.github.com>
Co-authored-by: Guillaume Dequenne <guillaume.dequenne@sonarsource.com>
 2023-08-02 14:12:20 +00:00
github-actions[bot]
45c9727f72
Create rule S6663: Sequence indexes must have an __index__ method (#2487) 
Authored-by: guillaume-dequenne-sonarsource <guillaume-dequenne-sonarsource@users.noreply.github.com>
 2023-08-02 15:49:32 +02:00
Pierre-Loup
4ba4fc489e
Modify rule S6379: Add language AzureResourceManager (Bicep) (#2244) 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
 2023-08-02 15:34:14 +02:00
github-actions[bot]
3d7b200c37
Create rule S6379: Add language AzureResourceManager (APPSEC-776) (#2242) 
[Specification
ticket](https://sonarsource.atlassian.net/browse/APPSEC-776)
[Implementation
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-885)
[RSPEC
Preview](https://sonarsource.github.io/rspec/#/rspec/S6379/azureresourcemanager)

PR for adding Bicep code examples
https://github.com/SonarSource/rspec/pull/2244

## Review

A dedicated reviewer checked the rule description successfully for:

- [x] logical errors and incorrect information
- [x] information gaps and missing content
- [x] text style and tone
- [x] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: pierre-loup-tristant-sonarsource <pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
 2023-08-02 15:18:05 +02:00
Pierre-Loup
2336aba6a7
Modify rule S6648: Add language AzureResourceManager (Bicep) (#2277) 
[Specification
ticket](https://sonarsource.atlassian.net/browse/APPSEC-803)
[Implementation
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-896)

Main PR for ARM templates:
https://github.com/SonarSource/rspec/pull/2250

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: pierre-loup-tristant-sonarsource <pierre-loup-tristant-sonarsource@users.noreply.github.com>
Co-authored-by: Rudy Regazzoni <110470341+rudy-regazzoni-sonarsource@users.noreply.github.com>
 2023-08-02 15:17:24 +02:00
Maksim Grebeniuk
da1a2a77e3
Create rule S6660: isinstance() should be preferred to direct type comparisons (#2480) 2023-08-02 14:13:04 +02:00
Maksim Grebeniuk
78a77b9d50
Create rule S6661: Assignments of lambdas to variables should be replaced by function definitions. (#2483) 2023-08-02 14:11:14 +02:00
Marco Borgeaud
6cae06f38c
Modify rule S1916: LaYC format (#2711) 
Share content with S2323.
 2023-08-02 09:47:38 +00:00
Martin Strecker
ebcace66f8
Modify rule S4023: Fix spelling (#2755) 2023-08-02 09:57:53 +02:00
Marco Borgeaud
8c7e94cd08
Run include and cross-references validation on all files (#2685) 
The previous validation code was taking about 3 minutes when running on
all rules, which is the case when modifying anything outside rules/,
including shared_content/.

The runtime was marginal when only the content specific to one rule was
modified, e.g. only rules/S100/cfamily/rule.adoc is modified.

The new validation code always takes about 30 seconds on the CI. This is
a slight increase for small PR but a large reduction for PR affecting
the whole system.

Furthermore, the new approach validates includes and cross-references
properly. An issue is now raised when:
 * The last include to shared_content/lang/foo.adoc is removed.
 * A shared_content doc includes a file from another rule, e.g.
   rules/S100/lang/rule.adoc includes shared_content/lang/foo.adoc,
   which includes rules/S200/bar.adoc.

This is achieved with proper Asciidoc extensions written in Ruby.
See https://docs.asciidoctor.org/asciidoctor/latest/extensions/
 2023-08-02 09:21:56 +02:00
Marco Borgeaud
a523a5d6e4
Do not clone the repo in all_required_checks_task 
Save about 20s of CPU time on each commit/PR.
 2023-08-02 09:03:03 +02:00
SonarTech
8f76da4f61 update coverage information 2023-08-02 00:30:36 +00:00
Martin Strecker
7de7c899ae
Modify rule S4023: LayC and improve rule description (#2691) 
see also
https://github.com/SonarSource/sonar-dotnet/issues/7633#issuecomment-1653156163

---------

Co-authored-by: Cristian Ambrosini <114916336+cristian-ambrosini-sonarsource@users.noreply.github.com>
 2023-08-01 18:23:30 +02:00
Irina Batinic
643dc1ff45
Modify rule S6625: Fix typo (#2749) 2023-08-01 10:39:34 +02:00
Yassin Kammoun
ba3d54e57f
Modify rule S6650: Add diff-tag (#2741) 2023-08-01 08:49:22 +02:00
Yassin Kammoun
10b328a50d
Modify rule S3799: Use let instead of var in noncompliant snippet (#2730) 2023-08-01 08:49:12 +02:00
Yassin Kammoun
625613d7c1
Modify rule S1763: Fix compliant diff-tag (#2724) 2023-08-01 08:48:59 +02:00
Yassin Kammoun
737826dea9
Modify rule S6637: Quote method's name in rule title (#2740) 2023-08-01 08:31:45 +02:00
Yassin Kammoun
902df156aa
Modify rule S6645: Fix noncompliant comments and links' titles (#2742) 2023-08-01 08:31:36 +02:00
Yassin Kammoun
610de1f332
Modify rule S6635: Fix link title (#2729) 2023-08-01 08:05:56 +02:00
Yassin Kammoun
9f95a6f49c
Modify rule S6676: Quote methods' names in rule title (#2739) 2023-08-01 08:05:46 +02:00
Yassin Kammoun
2b50c336db
Modify rule S6647: Add diff-tag and fix noncompliant comment (#2744) 2023-08-01 08:05:25 +02:00
Yassin Kammoun
00ea7bea23
Modify rule S1128: Fix related rules section (#2738) 2023-08-01 08:05:14 +02:00
Yassin Kammoun
2cd7fc725e
Modify rule S6671: Fix related rules section (#2732) 2023-08-01 07:27:35 +02:00
Yassin Kammoun
7fb97094c8
Modify rule S108: Fix exceptions section and replace 'var' with 'let' (#2733) 2023-08-01 07:27:26 +02:00
Yassin Kammoun
4922fc9fc5
Modify rule S6551: Fix documentation section (#2734) 2023-08-01 07:27:18 +02:00
Yassin Kammoun
d3cb89c529
Modify rule S6657: Replace 'var' with 'let' in snippets and fix case (#2735) 2023-08-01 07:27:11 +02:00
Yassin Kammoun
eeda8468ea
Modify JS/TS rules: Uniform links to TypeScript and MDN references (#2736) 2023-08-01 07:27:02 +02:00
Yassin Kammoun
b338b61b84
Modify rule S6666: Quote method's name in rule title (#2746) 2023-07-31 20:59:28 +02:00
Yassin Kammoun
5d5bdb92e2
Modify rule S6509: Fix links' titles (#2731) 2023-07-31 20:59:17 +02:00
Yassin Kammoun
6b8f65c342
Modify rule S6092: Prefix documentation links with bullet points (#2727) 2023-07-31 20:59:04 +02:00
Yassin Kammoun
6533b0165f
Modify rule S4143: Remove leading space in code snippets (#2728) 2023-07-31 19:51:50 +02:00
Yassin Kammoun
7a83669eb3
Modify rule S4043: Delimite consecutive snippets with a description (#2725) 2023-07-31 19:51:39 +02:00
Yassin Kammoun
5dec24baf9
Modify rule S6654: Add diff-tag and fix noncompliant comments (#2723) 2023-07-31 18:17:05 +02:00
Yassin Kammoun
fbd75c6f86
Modify rule S6594: Fix link and remove extra section (#2722) 2023-07-31 18:16:55 +02:00
Yassin Kammoun
351047c3df
Modify rule S2692: Fix snippet and documentation section (#2721) 2023-07-31 18:16:41 +02:00
Yassin Kammoun
ec0a9ae6d6
Modify rule S4619: Fix code snippets (#2720) 2023-07-31 18:01:52 +02:00
Yassin Kammoun
dd75e8143b
Modify rule S4524: Add link to documentation (#2719) 2023-07-31 18:01:31 +02:00
Yassin Kammoun
c2bc16f386
Modify rule S2737: Add links to documentation (#2718) 2023-07-31 18:01:10 +02:00
Marco Borgeaud
02dae8e652
Clean ci/validate_asciidoc.sh 
* Regroup read-only variable declaration. `declare -xr` is used for
an exported read-only variable.
 * Use more accurate log messages.
 * Use consistent indentation of 2 spaces.
 * Fail fast if dependencies cannot be installed.
 * Regroup HTML generation & its validation.
 * Document the main validation points.
 * Simplify some commands and address some ShellCheck warnings.
 2023-07-31 15:37:06 +02:00
Marco Borgeaud
f6a887100c
Revert "Clean ci/validate_asciidoc.sh (09a2902fe3b86)" 
This reverts commit 09a2902fe3b8688ca6bc818c7c6055e2307e6235. It
introduced some regressions.
 2023-07-31 13:11:14 +00:00