1095 Commits

Author SHA1 Message Date
Pierre-Loup
dfc25a812c
Modify rule S6308: Update issue message (#888)
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-03-16 13:32:29 +00:00
Pierre-Loup
2d910e276c
Modify rule S6303: Update issue message (#886)
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-03-16 12:32:37 +00:00
Pierre-Loup
19b4026a2d
Modify rule S6252: Update message and title (#880)
* Update message

* Update rule title "Ask Yourself: questions.

Ask Yourself question is update with the content from S6412

* Update code examples

* Apply suggestions from code review

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-03-16 09:27:31 +00:00
Pierre-Loup
0236f41b98
Modify rule S6255: Update issue message (#881)
* Update message

* Update code examples

* Fix extra coma

Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-03-16 08:54:32 +00:00
Pierre-Loup
b6c6fd7320
Modify rule S6275: update issue message and code examples (#883)
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-03-15 15:46:48 +00:00
marco-bearzi-sonarsource
5f47dbbe15
Modify rule S2761: Rectify comments (#905) 2022-03-15 15:50:38 +01:00
Pierre-Loup
c54b8f8b6c
Modify rule S6329: Update issue message (#891) 2022-03-15 10:55:32 +00:00
Pierre-Loup
8088852221
Modify rule S6375: Add secondary locations (#877) 2022-03-15 10:33:40 +00:00
Pierre-Loup
f3d3c4c8e3
Modify rule S6330: Update issue message (#892) 2022-03-15 09:32:09 +00:00
SonarTech
a7a6ac40d7 update coverage information 2022-03-15 00:31:58 +00:00
Pierre-Loup
9b3d87a04b
Modify rule S6378: Update issue message (#876) 2022-03-14 15:29:40 +00:00
Pierre-Loup
856eeb79b1
Modify rule S6385: Update highlighting (#904) 2022-03-14 16:06:04 +01:00
Pierre-Loup
fde6a5f0df
Modify rule S6245: Update issue message (#875) 2022-03-14 14:41:19 +00:00
Andrea Guarino
23a9a29023
Modify rule S2761: edit title and description for Python (#837)
* Edit title and description of rule S2761 for Python

* Fix after review

* Update type to code smell

* Update message

Co-authored-by: Marco Bearzi <marco.bearzi@sonarsource.com>
2022-03-14 15:07:47 +01:00
Pierre-Loup
c3ae588343
Modify rule S5332: Update issue message (#874)
For Terraform and Cloudformation
2022-03-14 14:00:11 +00:00
Pierre-Loup
faa24755ff
Modify S4423: Fix messages for Terraform and Cloudformation 2022-03-14 13:28:34 +00:00
Pierre-Loup
d69417e02d
Modify rule S6383: Add secondary location (#895)
* Modify rule S6383: Add secondary location

* Change secondary location message

Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>

* Update message for primary location

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2022-03-14 13:15:31 +00:00
Costin Zaharia
58fd91de71
Modify rule S3459: document exception (#900) 2022-03-14 12:22:38 +00:00
Costin Zaharia
cf211533a6
Modify rule S4226: document exception (#899) 2022-03-14 12:12:29 +00:00
Elena Vilchik
72c111c062
Update noncompliant code example for S1126 (JS) (#885) 2022-03-14 11:19:40 +00:00
Massimo Paladin
20d130a152
CPP-3597: Remove CFamily legacy rules id 2022-03-14 11:09:00 +00:00
marco-bearzi-sonarsource
27cf7b278f
Modify rule S1940: Add code examples for python (#897)
* Modify rule S1940: Add code examples for python

* Fix path
2022-03-14 11:23:49 +01:00
Arseniy Zaostrovnykh
a1ef6b440c
Modify Rule S6006: implement quickfix (#769) 2022-03-14 08:46:31 +00:00
SonarTech
3eaceb80f7 update coverage information 2022-03-12 00:33:02 +00:00
SonarTech
7c20cf9bce update coverage information 2022-03-11 00:32:22 +00:00
github-actions[bot]
94b673efbb
Modify rule S1659: mark quick fix as "partial" 2022-03-10 16:00:02 +00:00
Loïc Joly
8a7ecd051b
S1988 Delete never implemented duplicated rule
Removed as discussed in CPP-1071
2022-03-09 15:13:41 +00:00
github-actions[bot]
7f154a7617
Modify rule S5955: mark quick fix as "partial" (#854) 2022-03-09 11:01:23 +00:00
Arseniy Zaostrovnykh
f7353489fc
Enable rules removal: do not validate deleted rules 2022-03-08 12:26:53 +00:00
Marco Antognini
02cae0ceb0
Fix SonarQube warning about missing reference for analysis (#796) 2022-03-08 10:31:27 +00:00
github-actions[bot]
08d650ab42
Modify rule S6016: mark quick fix as "partial" 2022-03-08 10:16:18 +00:00
Fred Tingaud
0bc6aa81ce
Deprecate rule S3400: deprecate rule for CFamily (CPP-3456)
Deprecate rule for CFamily as it would have too many exceptions and brings little value.
2022-03-08 10:47:32 +01:00
SonarTech
ad709a4fe2 update coverage information 2022-03-08 00:32:29 +00:00
eric-therond-sonarsource
20d51427a0
Modify rule S6258[terraform]: Add GCP modules (#778)
* modify S6285: add terraform gcp

* add additional flags for sql logging

* fixes after review

* Add code highlighted tag to code example

Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-07 10:45:11 +00:00
Pierre-Loup
c66125093d
Modify rule S6413: Add Google Cloud Logging bucket support (#804)
* Create rule S6413

* Add first draft

* Extend highlighting

* Rewrite recommended

* Rewrite recommended

* Update rules/S6413/recommended.adoc

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

* Add missing dot

* Add additional description

* Add code GCP code examples

* Add missing "gcp" tag

Co-authored-by: hendrik-buchwald-sonarsource <hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Hendrik Buchwald <hendrik.buchwald@sonarsource.com>
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
2022-03-07 09:14:13 +00:00
Arseniy Zaostrovnykh
89c7e09b35
Fix source history information shadowing for rspec-tools project 2022-03-07 09:47:57 +01:00
Čaba Šagi
f1c09da3ff
Modify rule S3453: Fix compliant code example for VBNet (#851) 2022-03-04 13:55:49 +00:00
Čaba Šagi
3758a4c96e
Fix doc (#866) 2022-03-04 14:49:40 +01:00
github-actions[bot]
00cae9e326
Create rule S6412[terraform]: Unversioned Google Cloud Storage buckets are security-sensitive (#749)
* Create rule S6412

* init s6412

* fixes after review

* remove one ask yourself question

* Add code highlighted tag to code example

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-04 13:27:35 +00:00
github-actions[bot]
e7aa3e8c2e
Create rule S6414[terraform]: Excluding users or groups activities from audit logs is security-sensitive (#805)
* Create rule S6414

* init s6414

* fixes after review

* fix noncompliant sample

* Fix typo in the rule title

* Add code highlighted tag to code example

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Pierre-Loup Tristant <pierre-loup.tristant@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-04 12:52:46 +00:00
github-actions[bot]
a0db1c44a0
Modify rule S1481: mark quick fix as "partial" (only lambda captures) 2022-03-04 13:36:32 +01:00
github-actions[bot]
e682cccbd5
Modify rule S6230: mark quick fix as "partial" 2022-03-04 13:11:56 +01:00
marco-bearzi-sonarsource
e254f3328d
Modify rule S1135: Add non-compliant code example for python (#860) 2022-03-03 17:31:30 +01:00
github-actions[bot]
4c9626049e
Modify rule S6230: mark quick fix as "covered" (#859) 2022-03-03 11:46:37 +01:00
hendrik-buchwald-sonarsource
4e659743db
Modify Rule S6329: Make generic and add GCP (#733)
* Create rule S6392

* Add first draft

* improve title

* add last commit to this PR regarding public network access

* add metadata tags

* changed title

* converted ask yourself into generic cloud

* converted description into generic cloud

* moved aws links to see

* converted recommended to generic cloud

* convertion of recommended -- added a special case

* add cwe

* add note in recommended section, not sure about this one

* add another cwe

* add first version of rule conversion

* final rule version

* removed leftover code

* Update rules/S6329/description.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* Update rules/S6329/terraform/rule.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* changed case for bulleted list

* improved specs after review

* removed potential confusion

* changed company<->organization

* Update rules/S6329/ask-yourself.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* Update rules/S6329/description.adoc

Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>

* Make generic

* Add GCP code sample

* Update rules/S6329/terraform/rule.adoc

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

* Fix syntax

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com>
2022-03-03 09:41:02 +01:00
github-actions[bot]
0357b3b2df
Create rule S6409: Enabling Attribute-Based Access Control for Kubernetes is security-sensitive (#737)
* Create rule S6409

* Add description

* Update rules/S6409/terraform/rule.adoc

Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>

Co-authored-by: hendrik-buchwald-sonarsource <hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Hendrik Buchwald <hendrik.buchwald@sonarsource.com>
Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
Co-authored-by: Loris S. <91723853+loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2022-03-02 20:54:36 +00:00
github-actions[bot]
5e09bc9f04
Create rule S6404[terraform]: Granting public access to GCP resources is security-sensitive (#713)
* Create rule S6404

* initial draft

* new ideas

* last little fixes before draft v1

* draftv1

* final version

* improved the text

* last commit

* very last

* Add code highlighted tag to code example

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 20:31:57 +00:00
github-actions[bot]
0aeb50c127
Create rule S6400[Terraform]: Granting highly privileged GCP resource rights is security-sensitive (#685)
* Create rule S6400

* first draft

* second draft

* relecture

* last relecture du matin

* another idea, last paragraph may be overkill

* add small precision for new resources

* Add code highlighted tag to code example

Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com>
Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 20:25:17 +00:00
eric-therond-sonarsource
3069550d46
Modify rule S5332[terraform]: add GCP load balancers (#760)
* add GCP balancers

* rephrase sentence

* fix after review

* Add code highlighted tag to code example

Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:19:10 +00:00
github-actions[bot]
b486a5246d
Create rule S6407[terraform]: Creating App Engine handlers without requiring TLS is security-sensitive (#725)
* Create rule S6407

* add rspecs6407 terraform

* fix typo in see section

* fixes after review

* Add code highlighted tag to code example

Co-authored-by: eric-therond-sonarsource <eric-therond-sonarsource@users.noreply.github.com>
Co-authored-by: eric-therond-sonarsource <eric.therond@sonarsource.com>
Co-authored-by: Nils Werner <nils.werner@sonarsource.com>
2022-03-02 14:02:00 +00:00