Modify rule S6945: Upgrade severity and impact to Critical and HIGH

Following the documentation, MAINTAINABILITY issues should have at least HIGH impact, and Critical severity, if they can lead to the introduction of bugs. RELIABILITY issues should have at least HIGH impact, and Critical severity, if they can for example cause corrupted data. Both applies here. Hence, we upgrade the `defaultSeverity` and impact levels. These are the documentation link: https://docs.sonarsource.com/sonarqube-server/2025.1/extension-guide/adding-coding-rules/#setting-severities-in-mqr-mode https://docs.sonarsource.com/sonarqube-server/2025.1/extension-guide/adding-coding-rules/#setting-severities-in-se-mode
Modify rule S6945: Add MAINTAINABILITY quality.
2025-02-25 13:14:35 +01:00 · 2025-02-25 13:14:35 +01:00 · 2025-02-25 13:14:35 +01:00
2 changed files with 4 additions and 3 deletions
--- a/rules/S6945/jcl/metadata.json
+++ b/rules/S6945/jcl/metadata.json
@ -8,7 +8,7 @@
  },
  "tags": [
  ],
-  "defaultSeverity": "Major",
+  "defaultSeverity": "Critical",
  "ruleSpecification": "RSPEC-6945",
  "sqKey": "S6945",
  "scope": "All",
@ -16,7 +16,8 @@
  "quickfix": "unknown",
  "code": {
    "impacts": {
-      "RELIABILITY": "MEDIUM"
+      "RELIABILITY": "HIGH",
+      "MAINTAINABILITY": "HIGH"
    },
    "attribute": "LOGICAL"
  }
--- a/rules/S6977/jcl/metadata.json
+++ b/rules/S6977/jcl/metadata.json
@ -1,6 +1,6 @@
 {
  "title": "RLSE should be used in SPACE directive",
-  "type": "CODE_SMELL",
+  "type": "BUG",
  "status": "ready",
  "remediation": {
    "func": "Constant\/Issue",