56 lines
1.1 KiB
Plaintext
56 lines
1.1 KiB
Plaintext
== Why is this an issue?
|
|
|
|
include::../description.adoc[]
|
|
|
|
== How to fix it
|
|
|
|
include::../how-to-fix-it.adoc[]
|
|
|
|
=== Code examples
|
|
|
|
==== Noncompliant code example
|
|
|
|
[source,sql,diff-id=1,diff-type=noncompliant]
|
|
----
|
|
CREATE PROCEDURE SalesByCustomer
|
|
@CustomerName nvarchar(50) -- Noncompliant
|
|
AS
|
|
SELECT c.customer_name, sum(ctr.amount) AS TotalAmount
|
|
FROM customers c, contracts ctr
|
|
WHERE c.customer_id = ctr.customer_id
|
|
GROUP BY c.customer_name
|
|
ORDER BY c.customer_name
|
|
----
|
|
|
|
==== Compliant solution
|
|
|
|
[source,sql,diff-id=1,diff-type=compliant]
|
|
----
|
|
CREATE PROCEDURE SalesByCustomer
|
|
@CustomerName nvarchar(50)
|
|
AS
|
|
SELECT c.customer_name, sum(ctr.amount) AS TotalAmount
|
|
FROM customers c, contracts ctr
|
|
WHERE c.customer_id = ctr.customer_id
|
|
AND c.customer_name = @CustomerName
|
|
GROUP BY c.customer_name
|
|
ORDER BY c.customer_name
|
|
----
|
|
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|