51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
66 lines
1.1 KiB
Plaintext
66 lines
1.1 KiB
Plaintext
== Why is this an issue?
|
|
|
|
include::../description.adoc[]
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,sql]
|
|
----
|
|
CREATE TABLE employee
|
|
(
|
|
employee_id INTEGER NOT NULL,
|
|
first_name VARCHAR(42) NOT NULL,
|
|
last_name VARCHAR(42) NOT NULL
|
|
);
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,sql]
|
|
----
|
|
CREATE TABLE employee
|
|
(
|
|
employee_id INTEGER NOT NULL PRIMARY KEY,
|
|
first_name VARCHAR(42) NOT NULL,
|
|
last_name VARCHAR(42) NOT NULL
|
|
);
|
|
----
|
|
|
|
[source,sql]
|
|
----
|
|
CREATE TABLE employee
|
|
(
|
|
employee_id INTEGER NOT NULL,
|
|
first_name VARCHAR(42) NOT NULL,
|
|
last_name VARCHAR(42) NOT NULL,
|
|
CONSTRAINT PK_Employee PRIMARY KEY (employee_id)
|
|
);
|
|
----
|
|
|
|
=== Exceptions
|
|
|
|
No issue is reported on temporary tables as they are often used to manipulate data and do not always require a primary key.
|
|
|
|
Example:
|
|
|
|
[source,sql]
|
|
----
|
|
CREATE TABLE #EmployeeName (last_name VARCHAR(42) NOT NULL); -- Compliant
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|