40 lines
1.3 KiB
Plaintext
40 lines
1.3 KiB
Plaintext
=== relates to: S1724
|
|
|
|
=== on 21 Nov 2014, 16:26:21 Freddy Mallet wrote:
|
|
What about extending RSPEC-1724 [~ann.campbell.2] ? Thanks
|
|
|
|
=== on 24 Nov 2014, 13:50:27 Ann Campbell wrote:
|
|
\[~freddy.mallet] IIRC, I specifically asked [~nicolas.peru] about that & he saw it as a separate rule. @Nico, am I mis-remembering?
|
|
|
|
=== on 24 Nov 2014, 13:55:18 Nicolas Peru wrote:
|
|
\[~ann.campbell.2]You remember well.
|
|
|
|
\[~freddy.mallet] You can have a method that is deprecated but not its enclosing class and therefore you should avoid override this method but not necessarily drop the usage of the class all together (this is not the deprecation path @SonarSource but it is still a valid one)
|
|
|
|
And for simplicity and customization matters I would keep that as a separate rule.
|
|
|
|
|
|
|
|
=== on 25 Nov 2014, 10:27:23 Freddy Mallet wrote:
|
|
Ok fine for me and that means that in following case, I'll get two issues [~ann.campbell.2] and [~nicolas.peru] :
|
|
|
|
----
|
|
@Deprecated
|
|
public class Foo {
|
|
public void doSomething(){...}
|
|
}
|
|
|
|
public class Bar extends Foo{ //<- one on the class : RSPEC-1724
|
|
@Override
|
|
public void DoSomething(){...} //<- one on the rule: this RSPEC
|
|
}
|
|
|
|
----
|
|
|
|
=== on 15 Dec 2014, 16:30:32 Ann Campbell wrote:
|
|
R#: CSharpWarnings::CS0672
|
|
|
|
=== on 8 May 2015, 15:34:19 Dinesh Bolkensteyn wrote:
|
|
LGTM
|
|
|