16f6c0aecf
Inline adoc files when they are included exactly once. Also fix language tags because this inlining gives us better information on what language the code is written in.
91 lines
3.7 KiB
Plaintext
91 lines
3.7 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
== Recommended Secure Coding Practices
|
|
|
|
Check whether your regular expression engine (the algorithm executing your regular expression) has any known vulnerabilities. Search for vulnerability reports mentioning the one engine you're are using.
|
|
|
|
|
|
If the regular expression is vulnerable to ReDos attacks, mitigate the risk by using a "match timeout" to limit the time spent running the regular expression.
|
|
|
|
|
|
Remember also that a ReDos attack is possible if a user-provided regular expression is executed. This rule won't detect this kind of injection.
|
|
|
|
== Sensitive Code Example
|
|
|
|
----
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Runtime.Serialization;
|
|
using System.Text.RegularExpressions;
|
|
using System.Web;
|
|
|
|
namespace N
|
|
{
|
|
public class RegularExpression
|
|
{
|
|
void Foo(RegexOptions options, TimeSpan matchTimeout, string input,
|
|
string replacement, MatchEvaluator evaluator)
|
|
{
|
|
// All the following instantiations are Sensitive.
|
|
new System.Text.RegularExpressions.Regex("(a+)+");
|
|
new System.Text.RegularExpressions.Regex("(a+)+", options);
|
|
new System.Text.RegularExpressions.Regex("(a+)+", options, matchTimeout);
|
|
|
|
// All the following static methods are Sensitive.
|
|
System.Text.RegularExpressions.Regex.IsMatch(input, "(a+)+");
|
|
System.Text.RegularExpressions.Regex.IsMatch(input, "(a+)+", options);
|
|
System.Text.RegularExpressions.Regex.IsMatch(input, "(a+)+", options, matchTimeout);
|
|
|
|
System.Text.RegularExpressions.Regex.Match(input, "(a+)+");
|
|
System.Text.RegularExpressions.Regex.Match(input, "(a+)+", options);
|
|
System.Text.RegularExpressions.Regex.Match(input, "(a+)+", options, matchTimeout);
|
|
|
|
System.Text.RegularExpressions.Regex.Matches(input, "(a+)+");
|
|
System.Text.RegularExpressions.Regex.Matches(input, "(a+)+", options);
|
|
System.Text.RegularExpressions.Regex.Matches(input, "(a+)+", options, matchTimeout);
|
|
|
|
System.Text.RegularExpressions.Regex.Replace(input, "(a+)+", evaluator);
|
|
System.Text.RegularExpressions.Regex.Replace(input, "(a+)+", evaluator, options);
|
|
System.Text.RegularExpressions.Regex.Replace(input, "(a+)+", evaluator, options, matchTimeout);
|
|
System.Text.RegularExpressions.Regex.Replace(input, "(a+)+", replacement);
|
|
System.Text.RegularExpressions.Regex.Replace(input, "(a+)+", replacement, options);
|
|
System.Text.RegularExpressions.Regex.Replace(input, "(a+)+", replacement, options, matchTimeout);
|
|
|
|
System.Text.RegularExpressions.Regex.Split(input, "(a+)+");
|
|
System.Text.RegularExpressions.Regex.Split(input, "(a+)+", options);
|
|
System.Text.RegularExpressions.Regex.Split(input, "(a+)+", options, matchTimeout);
|
|
}
|
|
}
|
|
}
|
|
----
|
|
|
|
include::../exceptions.adoc[]
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
=== on 16 Oct 2018, 11:38:07 Nicolas Harraudeau wrote:
|
|
*Implementation details*:
|
|
|
|
This rules highlights regular expression patterns. Sometime the pattern is compiled using the ``++new System.Text.RegularExpressions.Regex.Regex++`` constructor, but it can also be in the form of a ``++String++`` fed to one of Regex static methods ``++isMatch++``, ``++Match++``, ``++Matches++``, ``++Replace++``. ``++Split++``. Note that we *do not match non static methods* as the pattern was given to the ``++Regex++`` constructor.
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|