rspec/rules/S3221/comments-and-links.adoc
2021-06-08 14:23:48 +02:00

29 lines
1.1 KiB
Plaintext

=== on 1 Jul 2015, 18:09:22 Ann Campbell wrote:
http://codeblog.jonskeet.uk/2014/06/03/anti-pattern-parallel-collections/
=== on 2 Jul 2015, 07:19:56 Tamas Vajk wrote:
\[~ann.campbell.2] looks good
=== on 24 Nov 2015, 21:22:13 Ann Campbell wrote:
\[~tamas.vajk] the message is unusually long now. Also, I don't agree with raising issues on both collections; they're not parallel until there are 2 of them.
=== on 25 Nov 2015, 08:38:10 Tamas Vajk wrote:
\[~ann.campbell.2] Shortened the message, WDYT?
The collections might not be this close next to each other, so I think it helps if all of them are marked symmetrically.
=== on 1 Dec 2015, 08:37:41 Tamas Vajk wrote:
\[~ann.campbell.2] It's just to note that the following is okay:
----
var output = new List<int>();
for(int i = 0; i < input.Count; i++)
{
output[i] = input[i]; // two collections are being indexed by the same variable, but it's compliant.
}
----
=== on 24 Dec 2015, 16:16:12 Dinesh Bolkensteyn wrote:
This rule's idea was good, and the implementation was done, but unfortunately there were too many "good exceptions" to this rule to make it valuable.