51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
39 lines
924 B
Plaintext
39 lines
924 B
Plaintext
== Why is this an issue?
|
|
|
|
The size of a collection and the length of an array are always greater than or equal to zero. Testing it doesn't make sense, since the result is always ``++true++``.
|
|
|
|
|
|
[source,csharp]
|
|
----
|
|
if(collection.Count >= 0){...} // Noncompliant: always true
|
|
|
|
if(array.Length >= 0){...} // Noncompliant: always true
|
|
----
|
|
|
|
Similarly testing that it is less than zero will always return ``++false++``.
|
|
|
|
[source,csharp]
|
|
----
|
|
if(enumerable.Count() < 0){...} // Noncompliant: always false
|
|
----
|
|
|
|
Fix the code to properly check for emptiness if it was the intent, or remove the redundant code to keep the current behavior.
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|