51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
39 lines
634 B
Plaintext
39 lines
634 B
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
[source,php]
|
|
----
|
|
$targetPid = (int)$_GET["pid"];
|
|
posix_kill($targetPid, 9); // Sensitive
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,php]
|
|
----
|
|
$targetPid = (int)$_GET["pid"];
|
|
|
|
// Validate the untrusted PID,
|
|
// With a pre-approved list or authorization checks
|
|
if (isValidPid($targetPid)) {
|
|
posix_kill($targetPid, 9);
|
|
}
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|