51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
43 lines
886 B
Plaintext
43 lines
886 B
Plaintext
== Why is this an issue?
|
|
|
|
A test case without assertions ensures only that no exceptions are thrown. Beyond basic runnability, it ensures nothing about the behavior of the code under test.
|
|
|
|
|
|
This rule raised an issue when no assertions are found within a PHPUnit test method.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,php]
|
|
----
|
|
public function testDoSomething() { // Compliant
|
|
$myClass = new MyClass();
|
|
$myClass->getSomething();
|
|
}
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,php]
|
|
----
|
|
public function testDoSomething() { // Noncompliant
|
|
$myClass = new MyClass();
|
|
$this->assertEquals("foo", $myClass->getSomething());
|
|
}
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|