51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
84 lines
2.6 KiB
Plaintext
84 lines
2.6 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
----
|
|
import android.content.BroadcastReceiver;
|
|
import android.content.Context;
|
|
import android.content.Intent;
|
|
import android.os.Build;
|
|
import android.os.Bundle;
|
|
import android.os.Handler;
|
|
import android.os.UserHandle;
|
|
import android.support.annotation.RequiresApi;
|
|
|
|
public class MyIntentBroadcast {
|
|
@RequiresApi(api = Build.VERSION_CODES.JELLY_BEAN_MR1)
|
|
public void broadcast(Intent intent, Context context, UserHandle user,
|
|
BroadcastReceiver resultReceiver, Handler scheduler, int initialCode,
|
|
String initialData, Bundle initialExtras,
|
|
String broadcastPermission) {
|
|
context.sendBroadcast(intent); // Sensitive
|
|
context.sendBroadcastAsUser(intent, user); // Sensitive
|
|
|
|
// Broadcasting intent with "null" for receiverPermission
|
|
context.sendBroadcast(intent, null); // Sensitive
|
|
context.sendBroadcastAsUser(intent, user, null); // Sensitive
|
|
context.sendOrderedBroadcast(intent, null); // Sensitive
|
|
context.sendOrderedBroadcastAsUser(intent, user, null, resultReceiver,
|
|
scheduler, initialCode, initialData, initialExtras); // Sensitive
|
|
}
|
|
}
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,java]
|
|
----
|
|
import android.content.BroadcastReceiver;
|
|
import android.content.Context;
|
|
import android.content.Intent;
|
|
import android.os.Build;
|
|
import android.os.Bundle;
|
|
import android.os.Handler;
|
|
import android.os.UserHandle;
|
|
import android.support.annotation.RequiresApi;
|
|
|
|
public class MyIntentBroadcast {
|
|
@RequiresApi(api = Build.VERSION_CODES.JELLY_BEAN_MR1)
|
|
public void broadcast(Intent intent, Context context, UserHandle user,
|
|
BroadcastReceiver resultReceiver, Handler scheduler, int initialCode,
|
|
String initialData, Bundle initialExtras,
|
|
String broadcastPermission) {
|
|
|
|
context.sendBroadcast(intent, broadcastPermission);
|
|
context.sendBroadcastAsUser(intent, user, broadcastPermission);
|
|
context.sendOrderedBroadcast(intent, broadcastPermission);
|
|
context.sendOrderedBroadcastAsUser(intent, user,broadcastPermission, resultReceiver,
|
|
scheduler, initialCode, initialData, initialExtras);
|
|
}
|
|
}
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|