51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
58 lines
1.2 KiB
Plaintext
58 lines
1.2 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
== Recommended Secure Coding Practices
|
|
|
|
It's recommended to enforce HTTPS only access by setting ``++enforceSSL++`` property to ``++true++``
|
|
|
|
|
|
== Sensitive Code Example
|
|
|
|
S3 bucket objects access through TLS is not enforced by default:
|
|
|
|
[source,javascript]
|
|
----
|
|
const s3 = require('aws-cdk-lib/aws-s3');
|
|
|
|
const bucket = new s3.Bucket(this, 'example'); // Sensitive
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,javascript]
|
|
----
|
|
const s3 = require('aws-cdk-lib/aws-s3');
|
|
|
|
const bucket = new s3.Bucket(this, 'example', {
|
|
bucketName: 'example',
|
|
versioned: true,
|
|
publicReadAccess: false,
|
|
enforceSSL: true
|
|
});
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
* https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_s3.Bucket.html[AWS CDK version 2] - Bucket
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
=== Message
|
|
|
|
* Make sure authorizing HTTP requests is safe here.
|
|
* Omitting 'enforceSSL' authorize HTTP requests. Make sure it is safe here.
|
|
|
|
|
|
=== Highlighting
|
|
|
|
* ``++aws_cdk.aws_s3.Bucket.enforceSSL++`` property
|
|
* ``++aws_cdk.aws_s3.Bucket++`` constructor when ``++enforceSSL++`` property is missing
|
|
|
|
|
|
endif::env-github,rspecator-view[]
|