51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
95 lines
2.5 KiB
Plaintext
95 lines
2.5 KiB
Plaintext
== Why is this an issue?
|
|
|
|
Using `break`, `continue`, `return` and `throw` inside of a `finally` block suppresses the propagation of any unhandled `Throwable` thrown in the `try` or `catch` block.
|
|
|
|
|
|
This rule raises an issue when a jump statement (`break`, `continue`, `return`, `throw`) would force control flow to leave a `finally` block.
|
|
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,kotlin]
|
|
----
|
|
fun main() {
|
|
try {
|
|
doSomethingWhichThrowsException(5)
|
|
println("OK") // incorrect "OK" message is printed
|
|
} catch (e: RuntimeException) {
|
|
println("ERROR") // this message is not shown
|
|
}
|
|
try {
|
|
doSomethingThatAlsoThrowsException(5)
|
|
println("OK") // incorrect "OK" message is printed
|
|
} catch (e: RuntimeException) {
|
|
println("ERROR") // this message is not shown
|
|
}
|
|
}
|
|
|
|
fun doSomethingWhichThrowsException(q: Int) {
|
|
try {
|
|
throw RuntimeException()
|
|
} finally {
|
|
//...
|
|
if (someOtherCondition) {
|
|
return // Noncompliant - prevents the RuntimeException from being propagated
|
|
}
|
|
if (aLastConditionIsVerified) {
|
|
throw IllegalStateException() // Noncompliant - prevents the RuntimeException from being propagated
|
|
}
|
|
}
|
|
}
|
|
|
|
fun doSomethingThatAlsoThrowsException(q: Int) {
|
|
while (someConditionIsVerified) {
|
|
try {
|
|
throw RuntimeException()
|
|
} finally {
|
|
//...
|
|
if (someOtherCondition) {
|
|
continue // Noncompliant - prevents the RuntimeException from being propagated
|
|
}
|
|
break // Noncompliant - prevents the RuntimeException from being propagated
|
|
}
|
|
}
|
|
}
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,kotlin]
|
|
----
|
|
fun main() {
|
|
try {
|
|
doSomethingWhichThrowsException()
|
|
println("OK")
|
|
} catch (e: RuntimeException) {
|
|
println("ERROR") // prints "ERROR" as expected
|
|
}
|
|
}
|
|
|
|
fun doSomethingWhichThrowsException(q: Int) {
|
|
try {
|
|
throw RuntimeException()
|
|
} finally {
|
|
while (someConditionIsVerified) {
|
|
//...
|
|
if (someOtherCondition) {
|
|
continue // Compliant - does not prevent the RuntimeException from being propagated
|
|
|
|
}
|
|
break // compliant - does not prevent the RuntimeException from being propagated
|
|
}
|
|
}
|
|
}
|
|
----
|
|
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|