51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
69 lines
1.2 KiB
Plaintext
69 lines
1.2 KiB
Plaintext
== Why is this an issue?
|
||
|
||
There's no point in having a PHPUnit test case without any test methods. Similarly, you shouldn't have a file in the tests directory which extends PHPUnit\Framework\TestCase but no tests in the file. Doing either of these things may lead someone to think that uncovered classes have been tested. Add some test method or make the class abstract if it is used by a real test case class.
|
||
|
||
=== Noncompliant code example
|
||
|
||
[source,php]
|
||
----
|
||
use PHPUnit\Framework\TestCase;
|
||
|
||
class MyTest extends TestCase {
|
||
|
||
protected function setUp() {
|
||
doSomethind();
|
||
}
|
||
|
||
|
||
private function doSomethind() {
|
||
//...
|
||
}
|
||
}
|
||
----
|
||
|
||
=== Compliant solution
|
||
|
||
[source,php]
|
||
----
|
||
use PHPUnit\Framework\TestCase;
|
||
|
||
class MyTest extends TestCase {
|
||
|
||
public function testBehaviour() {
|
||
//...
|
||
}
|
||
|
||
//...
|
||
}
|
||
|
||
// or
|
||
|
||
abstract class MyAbstractTest extends TestCase {
|
||
|
||
protected function setUp() {
|
||
doSomethind();
|
||
}
|
||
|
||
|
||
private function doSomethind() {
|
||
//...
|
||
}
|
||
}
|
||
----
|
||
|
||
ifdef::env-github,rspecator-view[]
|
||
|
||
'''
|
||
== Implementation Specification
|
||
(visible only on this page)
|
||
|
||
include::../message.adoc[]
|
||
|
||
'''
|
||
== Comments And Links
|
||
(visible only on this page)
|
||
|
||
include::../comments-and-links.adoc[]
|
||
|
||
endif::env-github,rspecator-view[]
|