55 lines
1023 B
Plaintext
55 lines
1023 B
Plaintext
When two functions have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, the code should be refactored.
|
|
|
|
== Noncompliant Code Example
|
|
|
|
----
|
|
class MyClass {
|
|
fun calculateCode(): String {
|
|
doTheThing()
|
|
doOtherThing()
|
|
return "done"
|
|
}
|
|
|
|
fun getStatus(): String { // Noncompliant
|
|
doTheThing()
|
|
doOtherThing()
|
|
return "done"
|
|
}
|
|
}
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
----
|
|
class MyClass {
|
|
fun calculateCode(): String {
|
|
doTheThing()
|
|
doOtherThing()
|
|
return "done"
|
|
}
|
|
|
|
fun getStatus(): String = calculateCode()
|
|
}
|
|
----
|
|
|
|
== Exceptions
|
|
|
|
Methods with fewer than 2 statements are ignored.
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::message.adoc[]
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
endif::env-github,rspecator-view[]
|