51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
110 lines
2.0 KiB
Plaintext
110 lines
2.0 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
Node.js https://nodejs.org/api/fs.html[``++fs++``]
|
|
|
|
----
|
|
const fs = require('fs');
|
|
|
|
fs.chmodSync("/tmp/fs", 0o777); // Sensitive
|
|
----
|
|
|
|
----
|
|
const fs = require('fs');
|
|
const fsPromises = fs.promises;
|
|
|
|
fsPromises.chmod("/tmp/fsPromises", 0o777); // Sensitive
|
|
----
|
|
|
|
----
|
|
const fs = require('fs');
|
|
const fsPromises = fs.promises
|
|
|
|
async function fileHandler() {
|
|
let filehandle;
|
|
try {
|
|
filehandle = fsPromises.open('/tmp/fsPromises', 'r');
|
|
filehandle.chmod(0o777); // Sensitive
|
|
} finally {
|
|
if (filehandle !== undefined)
|
|
filehandle.close();
|
|
}
|
|
}
|
|
----
|
|
|
|
Node.js https://nodejs.org/api/process.html#process_process_umask_mask[``++process.umask++``]
|
|
|
|
----
|
|
const process = require('process');
|
|
|
|
process.umask(0o000); // Sensitive
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
Node.js https://nodejs.org/api/fs.html[``++fs++``]
|
|
|
|
[source,javascript]
|
|
----
|
|
const fs = require('fs');
|
|
|
|
fs.chmodSync("/tmp/fs", 0o770); // Compliant
|
|
----
|
|
|
|
[source,javascript]
|
|
----
|
|
const fs = require('fs');
|
|
const fsPromises = fs.promises;
|
|
|
|
fsPromises.chmod("/tmp/fsPromises", 0o770); // Compliant
|
|
----
|
|
|
|
[source,javascript]
|
|
----
|
|
const fs = require('fs');
|
|
const fsPromises = fs.promises
|
|
|
|
async function fileHandler() {
|
|
let filehandle;
|
|
try {
|
|
filehandle = fsPromises.open('/tmp/fsPromises', 'r');
|
|
filehandle.chmod(0o770); // Compliant
|
|
} finally {
|
|
if (filehandle !== undefined)
|
|
filehandle.close();
|
|
}
|
|
}
|
|
----
|
|
|
|
Node.js https://nodejs.org/api/process.html#process_process_umask_mask[``++process.umask++``]
|
|
|
|
[source,javascript]
|
|
----
|
|
const process = require('process');
|
|
|
|
process.umask(0o007); // Compliant
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|