62 lines
1.3 KiB
Plaintext
62 lines
1.3 KiB
Plaintext
== Why is this an issue?
|
|
|
|
Nested control flow statements ``++CASxx++``, ``++DO++``, ``++DOU++``, ``++DOW++``, ``++DOUxx++``, ``++DOWxx++``, ``++FOR++``, ``++IF++``, ``++IFxx++``, ``++MONITOR++`` and ``++SELECT++`` are often key ingredients in creating
|
|
what's known as "Spaghetti code". This code smell can make your program difficult to understand and maintain.
|
|
|
|
When numerous control structures are placed inside one another, the code becomes a tangled, complex web.
|
|
This significantly reduces the code's readability and maintainability, and it also complicates the testing process.
|
|
|
|
== How to fix it
|
|
|
|
=== Code examples
|
|
|
|
The following example demonstrates the behavior of the rule with the default threshold of 3 levels of nesting:
|
|
|
|
==== Noncompliant code example
|
|
|
|
[source,rpg]
|
|
----
|
|
IF A <> B
|
|
IF B <> C
|
|
DOW B <> A
|
|
IF A <> D
|
|
...
|
|
ENDIF
|
|
ENDDO
|
|
ENDIF
|
|
ENDIF
|
|
----
|
|
|
|
[source,rpg]
|
|
----
|
|
if a <> b;
|
|
if b <> c;
|
|
dow b <> a;
|
|
if a <> d;
|
|
...
|
|
endif;
|
|
enddo;
|
|
endif;
|
|
endif;
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
include::../parameters.adoc[]
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|