16f6c0aecf
Inline adoc files when they are included exactly once. Also fix language tags because this inlining gives us better information on what language the code is written in.
73 lines
1.5 KiB
Plaintext
73 lines
1.5 KiB
Plaintext
== Why is this an issue?
|
|
|
|
`ToCharArray` can be omitted when the operation on the array could have been done directly on the string, such as when iterating over the characters in a string, and when accessing a character in a string via an array index. In those cases, explicit `ToCharArray` calls should be omitted.
|
|
|
|
C#11 introduced support for UTF-8 string literals, which are stored as `ReadOnlySpan<byte>` objects.
|
|
For that reason, the rule also raises on `ToArray` invocations of `ReadOnlySpan<T>`.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,csharp]
|
|
----
|
|
string str = "some string";
|
|
foreach (var c in str.ToCharArray()) // Noncompliant
|
|
{
|
|
// ...
|
|
}
|
|
|
|
ReadOnlySpan<byte> span = "some UTF-8 string literal"u8;
|
|
foreach (var c in span.ToArray()) // Noncompliant
|
|
{
|
|
// ...
|
|
}
|
|
----
|
|
|
|
|
|
=== Compliant solution
|
|
|
|
[source,csharp]
|
|
----
|
|
string str = "some string";
|
|
foreach (var c in str)
|
|
{
|
|
// ...
|
|
}
|
|
|
|
ReadOnlySpan<byte> span = "some UTF-8 string literal"u8;
|
|
foreach (var b in span) // Compliant
|
|
{
|
|
// ...
|
|
}
|
|
----
|
|
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
=== Message
|
|
|
|
Remove this redundant ["ToCharArray"|"ToArray"] call.
|
|
|
|
|
|
=== Highlighting
|
|
|
|
- `ToCharArray()`
|
|
|
|
- `ToArray()`
|
|
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
=== on 10 Dec 2015, 09:05:47 Tamas Vajk wrote:
|
|
\[~ann.campbell.2] Applied minor changes.
|
|
|
|
=== on 10 Dec 2015, 14:43:16 Ann Campbell wrote:
|
|
looks good [~tamas.vajk]
|
|
|
|
endif::env-github,rspecator-view[]
|